Permalink
Browse files

Configure Simplecov correctly (#2457)

* Configure simplecov correctly

Simplecov 0.15.x allows regexps for filtering paths that seems to
break out naively configured relative paths, unsure if we were correct
beforehand but this change fixes the build.

* Removing pending for JRuby 9000, issue fixed upstream

* Update spec suffix for latest JRuby
  • Loading branch information...
1 parent b90fd3c commit 18d0e0e5bf471ff46048bd4a1266e20cefee2217 @JonRowe JonRowe committed on GitHub Aug 22, 2017
@@ -28,9 +28,9 @@ begin
require 'simplecov'
SimpleCov.start do
- add_filter "./bundle/"
- add_filter "./tmp/"
- add_filter "./spec/"
+ add_filter "bundle/"
+ add_filter "tmp/"
+ add_filter "spec/"
minimum_coverage(100)
end
end
@@ -8,7 +8,7 @@
let(:failure_exit_code) { rand(97) + 2 } # 2..99
if RSpec::Support::Ruby.jruby_9000?
- let(:spec_line_suffix) { ":in `<top>'" }
+ let(:spec_line_suffix) { ":in `<main>'" }
elsif RSpec::Support::Ruby.jruby?
let(:spec_line_suffix) { ":in `(root)'" }
elsif RUBY_VERSION == "1.8.7"
@@ -284,10 +284,6 @@ module RSpec::Core
describe "#notify_non_example_exception" do
it "sends a `message` notification that contains the formatted exception details" do
- if RSpec::Support::Ruby.jruby_9000?
- pending "RSpec gets `Unable to find matching line from backtrace` on JRuby 9000"
- end
-
formatter_out = StringIO.new
formatter = Formatters::ProgressFormatter.new(formatter_out)
reporter.register_listener formatter, :message

0 comments on commit 18d0e0e

Please sign in to comment.