Commits on Feb 18, 2016
  1. @JonRowe
Commits on Feb 17, 2016
  1. @JonRowe

    Merge pull request #2177 from rspec/fix-pattern-docs

    Fix docs for pattern option so they are more accurate.
    JonRowe committed Feb 17, 2016
  2. @myronmarston
Commits on Feb 13, 2016
  1. @JonRowe

    Merge pull request #2172 from rspec/remove-execution-result-from-group

    Groups should not have an execution result.
    JonRowe committed Feb 14, 2016
  2. @myronmarston

    Merge pull request #2173 from rspec/support-do-end-block-snippet-extr…

    …action
    
    Extract snippets containing do-end block and ending with "end"-only line
    myronmarston committed Feb 12, 2016
  3. @yujinakayama
Commits on Feb 12, 2016
  1. @myronmarston
Commits on Feb 9, 2016
  1. @JonRowe

    Merge pull request #2170 from rspec/issue-2136

    When filtering, do not consider declaration lines from other files.
    JonRowe committed Feb 9, 2016
  2. @myronmarston

    When filtering, do not consider declaration lines from other files.

    Before this, our logic for line number filtering asked `RSpec.world`
    for the preceding declaration line of a particular line number,
    *without* passing it a file name, which meant that it looked at
    the declaration line numbers from _all_ files. This was prone to
    producing weird filtering behavior.
    
    Fixes #2136.
    myronmarston committed Dec 20, 2015
  3. @myronmarston

    Refactor: accept a file path in `preceding_declaration_line`.

    ...but do not use it yet.
    myronmarston committed Feb 8, 2016
  4. @myronmarston
  5. @myronmarston

    Fix typos in doc string.

    myronmarston committed Feb 8, 2016
Commits on Feb 8, 2016
  1. @myronmarston

    Trim excess whitespace.

    myronmarston committed Feb 7, 2016
Commits on Feb 7, 2016
  1. @JonRowe

    Merge pull request #2166 from rspec/remove-logged-messages

    Remove logged messages
    JonRowe committed Feb 7, 2016
  2. @JonRowe

    Merge pull request #2165 from rspec/fix-drb-weirdness

    Fix drb weirdness
    JonRowe committed Feb 7, 2016
  3. @myronmarston

    Avoid logged messages showing up as part of our spec suite output.

    Before this change, `rspec --seed 31448` would result in some extra
    messages showing up as part of the output of our spec suite:
    
    > RSpec is shutting down and will print the summary report... Interrupt again to force quit.
    
    This fixes the issue, expecting the output instead.
    myronmarston committed Feb 6, 2016
  4. @myronmarston
  5. @myronmarston

    Fix DRb specs that were failing for me locally.

    As the comment explains, I have had to configure my network
    adapter in a non-standard way, and it causes
    `IPSocket.getaddress(Socket.gethostname)` to raise an error
    for me.
    
    A couple of the DRb specs were failing as a result. The use of
    `return` from `ensure` caused the error to be ignored (the fact
    that `local_drb` was not set caused it to return false). This was
    confusing, and using `return` from `ensure` is a horrible practice. I have refactored to avoid the issue, rescuing
    errors explicitly.
    myronmarston committed Feb 6, 2016
  6. @myronmarston

    Remove duplicate spec.

    myronmarston committed Feb 6, 2016
  7. @myronmarston

    Remove extra blank line.

    myronmarston committed Feb 6, 2016
  8. @JonRowe

    changelog for 2161

    [skip ci]
    JonRowe committed Feb 7, 2016
  9. @JonRowe

    Merge pull request #2161 from paddor/master

    avoid TypeError when exiting
    JonRowe committed Feb 7, 2016
Commits on Feb 6, 2016
  1. @samphippen
  2. @samphippen
Commits on Jan 28, 2016
  1. @paddor

    avoid TypeError when exiting

    paddor committed Jan 28, 2016
Commits on Jan 26, 2016
  1. @myronmarston

    Forward port 3.4.2 release notes.

    [ci skip]
    myronmarston committed Jan 26, 2016
Commits on Jan 23, 2016
  1. @myronmarston

    Merge pull request #2159 from rspec/dont-use-kernel-require

    Make syntax highlighting work when the coderay gem is installed but n…
    myronmarston committed Jan 23, 2016
  2. @myronmarston

    Make syntax highlighting work when the coderay gem is installed but n…

    …ot on your path.
    
    Apparently, `::Kernel.require` is _only_ ruby's built-in require
    (based on the `$LOAD_PATH`) and does not get the enhanced capabilities
    of rubygems when rubygems is loaded. Rubygems only monkey patches
    `::Kernel#require`, not `::Kernel.require`.
    
    Originally, I had used `::Kernel.require` to load coderay to make
    it easier to stub `require` to simulate coderay not being available,
    as it allowed me to treat coderay as a collaborator. Using bare
    `require` instead forces me to stub the object-under-test, which is
    a bit smelly, but it fixes things so that you can get syntax
    highlighting without using something like bundler to manage your
    project and setup load paths.
    
    Compare:
    
    $ ruby -rubygems -e "p method(:require).source_location"
    ["/Users/myron/.rubies/ruby-2.1.5/lib/ruby/2.1.0/rubygems/core_ext/kernel_require.rb", 38]
    $ ruby -rubygems -e "p ::Kernel.method(:require).source_location"
    nil
    myronmarston committed Jan 22, 2016
Commits on Jan 18, 2016
  1. @JonRowe

    Merge pull request #2158 from mrageh/ma-update-one-liner-documentation

    Clarify one-liner syntax cannot be used with block matchers
    JonRowe committed Jan 19, 2016
  2. @mrageh

    Clarify one-liner syntax cannot be used with block matchers

    Users sometimes try to use the one-liner syntax with block matchers,
    which can cause RSpec to behave in strange ways. This behaviour is not
    supported in RSpec because the complexity of implementing it would
    greatly outweigh the benefits.
    
    This commit just clarifies in the documentation that the one-liner
    syntax does not support block matchers.
    
    Possible fix for rspec/rspec-expectations#805
    mrageh committed Jan 18, 2016
Commits on Jan 11, 2016
  1. @JonRowe

    Merge pull request #2156 from rspec/issue-2155

    Fix `--drb` option to not list DRb connection error as exception cause.
    JonRowe committed Jan 12, 2016
  2. @myronmarston

    Fix `--drb` option to not list DRb connection error as exception cause.

    If we start the spec run in a `rescue` block, ruby will set the
    rescued exception to be the cause of all exceptions that occur
    during the run.
    myronmarston committed Jan 10, 2016
Commits on Jan 8, 2016
  1. @yujinakayama

    Merge pull request #2154 from rspec/fix-order-dependent-failure-on-jruby

    Fix order dependent spec on JRuby
    yujinakayama committed Jan 8, 2016
  2. @yujinakayama

    Fix order dependent spec failure on JRuby

    The bisect feature internally uses DRb server. It properly stops the
    server after the processing, but DRb.current_server won't be nil even
    after invoking DRbServer#stop_service. Thus Runner.running_in_drb? will
    unintentionally continue returning true once Bisect::Server.run is
    invoked in the process. In that case we need to check DRbServer.alive?.
    
    ```
    $ ruby --version
    jruby 1.7.22 (1.9.3p551) 2015-08-20 c28f492 on Java HotSpot(TM) 64-Bit Server VM 1.8.0_25-b17 +jit [darwin-x86_64]
    $ bundle exec rspec './spec/integration/bisect_spec.rb[1:2:1]' './spec/rspec/core/configuration_spec.rb[1:13:13:3]' --seed 36379 --format doc
    
    Randomized with seed 36379
    
    Bisect
      when the spec ordering is inconsistent
        stops bisecting and surfaces the problem to the user
    
    RSpec::Core::Configuration
      #files_to_run
        with default default_path
          does not load files in the default path when run by ruby (FAILED - 1)
    
    Failures:
    
      1) RSpec::Core::Configuration#files_to_run with default default_path does not load files in the default path when run by ruby
         Failure/Error: expect(config.files_to_run).to be_empty
           expected `["/Users/nkymyj/Projects/rspec-dev/repos/rspec-core/spec/integration/bisect_spec.rb", "/Users/nkymyj/...ec/core/world_spec.rb", "/Users/nkymyj/Projects/rspec-dev/repos/rspec-core/spec/rspec/core_spec.rb"].empty?` to return true, got false
         # ./spec/rspec/core/configuration_spec.rb:553:in `Core'
         # ./spec/support/sandboxing.rb:14:in `(root)'
         # ./spec/support/sandboxing.rb:7:in `(root)'
    ```
    yujinakayama committed Jan 4, 2016
Commits on Jan 6, 2016
  1. @myronmarston

    Merge pull request #2152 from rspec/update-travis-build-scripts-2016-…

    …01-06-for-master
    
    Updates from rspec-dev (2016-01-06)
    myronmarston committed Jan 6, 2016