Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Commits on May 18, 2015
  1. @JonRowe

    Merge pull request #1963 from bentheax/issue-1961-line-filter-regression

    JonRowe authored
    Use :rerun_file_path when checking location filters
  2. @bentheax

    Use :rerun_file_path when checking location filters

    bentheax authored
    Fixes #1961
    
    The problem with using :absolute_file_path is that it doesn't function
    correctly for shared examples in an external file. The filter manager thinks
    that there are no location filters set, when actually there are. Since
    MetadataFilter already handles location filtering correctly across multiple
    nested examples / files, correcting the path that is checked is sufficient to
    fix the line filtering issue.
Commits on May 16, 2015
  1. @myronmarston

    Ensure exception formatting is applied recursively.

    myronmarston authored
    This is necessary for niche situations where `aggregate_failures` is nested.
  2. @myronmarston

    Allow description to be omitted.

    myronmarston authored
    This is necessary to support nested aggregation blocks.
  3. @myronmarston
  4. @myronmarston
  5. @myronmarston

    Exclude shared group backtrace from sub-failure backtraces.

    myronmarston authored
    It is already listed on the aggregate failure backtrace,
    and would be redundant to list it on each sub-failure.
  6. @myronmarston

    Fix formatting for pending MultipleExpectationsNotMetError.

    myronmarston authored
    To get this to work properly, we have to compose the
    exception presenter options for pending and for
    MultipleExpectationsNotMetError.
  7. @myronmarston

    Refactor: centralize exception presenter options.

    myronmarston authored
    We need to combine some of these cases (such
    as when we get a `MultipleExpectationsNotMetError`
    in a pending spec), and to do that we need to combine
    the options, so having the options listed in the same
    method is a stepping stone towards that.
  8. @myronmarston
  9. @myronmarston
  10. @myronmarston
  11. @myronmarston
  12. @myronmarston

    Move exception formatting logic into its own class.

    myronmarston authored
    - Simplifies the notification classes.
    - Provides something we can use to format multiple
      expectation failures packaged as a single exception
      for `aggregate_failures`.
  13. @myronmarston

    Favor constructor arg injection over subclass method overriding.

    myronmarston authored
    This will make it easier to extract an `ExceptionFormatter`.
  14. @myronmarston
Commits on Apr 30, 2015
  1. @myronmarston

    Refactor example creation.

    myronmarston authored
    - Remove unnecessary `Array#last` call.
    - This version is threadsafe, whereas the prior
      version wasn’t.  Consider what would happen if
      another thread added an example to the `examples`
      array while this was happening: it would have returned
      a different example than the one created here. We don’t
      actually do any multithreading when examples are defined,
      and have no plans to do so, but it’s always nice to make
      things more threadsafe.
Commits on Apr 29, 2015
  1. @myronmarston

    Merge pull request #1950 from JoshCheek/1921_fix_memory_leak

    myronmarston authored
    Allows user code to retain references to memoized helpers
  2. @JoshCheek

    Allows user code to retain references to memoized helpers

    JoshCheek authored
    Accomplish this by no longer clearing the example's ivars.
    
    Fixes rspec/rspec-core#1921
    
    Context
    -------
    
    * This pull request:
      #1950
    * Originally clearing ivars due to memory leak:
      #321
    * Threadsafe memoized helpers caused `__memoized` to stop lazily initializing:
      #321
    * This caused it to be permawiped by by the resetting of the example's ivars:
      #1921
    
    However, this patch tests the behaviour of the memory leak,
    rather than its mechanics, which shows that it was fixed at some point.
    So we simply remove that code.
Commits on Apr 28, 2015
  1. @JonRowe
Commits on Apr 27, 2015
  1. @JonRowe

    Merge pull request #1945 from rspec/prevent_run_all_when_filtered_ign…

    JonRowe authored
    …oring_only_failures
    
    `--only-failures` takes precedence over `run_all_when_everything_filtered`
  2. @JonRowe
Commits on Apr 18, 2015
  1. @myronmarston

    Tell users where the invalid options came from.

    myronmarston authored
    Addresses the confusion reported in rspec/rspec-rails#1356.
Commits on Apr 13, 2015
  1. @eugeneius

    Apply helper modules to existing groups when added

    eugeneius authored
    When a helper module is configured, it is now applied to all existing
    matching example groups. This means that the order in which example
    groups are defined and helper modules are configured no longer matters.
Commits on Apr 12, 2015
  1. @JonRowe

    Merge pull request #1933 from rspec/fix_enable_global_dsl

    JonRowe authored
    Fixing the default behaviour of `expose_dsl_globally`
  2. @JonRowe
Commits on Apr 9, 2015
  1. @myronmarston
  2. @myronmarston
Commits on Apr 7, 2015
  1. @myronmarston

    Prefer localhost over 127.0.0.1.

    myronmarston authored
    127.0.0.1 is ipv4, whereas localhost should work
    for ipv4 and ipv6.
Commits on Apr 6, 2015
  1. @myronmarston

    Fix help text grammar.

    myronmarston authored
  2. @myronmarston

    Ignore flapping examples that did not fail on original run.

    myronmarston authored
    We only care that all the failures from the original
    run are still failing; additional failures can be
    ignored.
  3. @myronmarston
  4. @myronmarston
  5. @myronmarston
  6. @myronmarston
Something went wrong with that request. Please try again.