Skip to content


Subversion checkout URL

You can clone with
Download ZIP
branch: master
Commits on Jun 3, 2015
  1. @myronmarston

    Merge pull request #1981 from rspec/remove-unneeded-jruby-file

    myronmarston authored
    We no longer need this file.
  2. @myronmarston

    We no longer need this file.

    myronmarston authored
    With the changes in rspec/rspec-expectations#796,
    this file is no longer necessary.
Commits on Jun 1, 2015
  1. @myronmarston

    Make backtrace truncation much more robust.

    myronmarston authored
    This is necessary for the changes in rspec/rspec-support#210.
    That adds an additional stack frame to the parent exception
    (for the lambda that wraps `raise`) and our truncation wasn’t
    working properly with it. Really, the old way just happened to
    work. This is much more robust.
  2. @myronmarston
Commits on May 18, 2015
  1. @myronmarston

    Merge pull request #1964 from JoshCheek/more_reliable_gc_test

    myronmarston authored
    Run GC multiple times if necessary
Commits on May 16, 2015
  1. @myronmarston

    Add changelog entry for #1946.

    myronmarston authored
    [ci skip]
  2. @myronmarston

    Merge pull request #1946 from rspec/aggregate-failures

    myronmarston authored
    Aggregate failures Integration
  3. @myronmarston

    Reword cuke step.

    myronmarston authored
  4. @myronmarston
  5. @myronmarston

    Ensure exception formatting is applied recursively.

    myronmarston authored
    This is necessary for niche situations where `aggregate_failures` is nested.
  6. @myronmarston

    Allow description to be omitted.

    myronmarston authored
    This is necessary to support nested aggregation blocks.
  7. @myronmarston

    Remove `:in ...` portion of backtrace lines from example output.

    myronmarston authored
    - The presence of backticks within that part was causing rendering
      problems on relish.
    - Different rubies have different output there so we already ignore
      that part when comparing the expected to actual output.
  8. @myronmarston
  9. @myronmarston
  10. @myronmarston
  11. @myronmarston

    Mask .java lines in Ruby backtraces.

    myronmarston authored
    This should hopefully make the travis build go green...
  12. @myronmarston

    Exclude shared group backtrace from sub-failure backtraces.

    myronmarston authored
    It is already listed on the aggregate failure backtrace,
    and would be redundant to list it on each sub-failure.
  13. @myronmarston

    Fix formatting for pending MultipleExpectationsNotMetError.

    myronmarston authored
    To get this to work properly, we have to compose the
    exception presenter options for pending and for
  14. @myronmarston

    Refactor: centralize exception presenter options.

    myronmarston authored
    We need to combine some of these cases (such
    as when we get a `MultipleExpectationsNotMetError`
    in a pending spec), and to do that we need to combine
    the options, so having the options listed in the same
    method is a stepping stone towards that.
  15. @myronmarston
  16. @myronmarston
  17. @myronmarston
  18. @myronmarston
  19. @myronmarston

    Move exception formatting logic into its own class.

    myronmarston authored
    - Simplifies the notification classes.
    - Provides something we can use to format multiple
      expectation failures packaged as a single exception
      for `aggregate_failures`.
  20. @myronmarston

    Favor constructor arg injection over subclass method overriding.

    myronmarston authored
    This will make it easier to extract an `ExceptionFormatter`.
  21. @myronmarston
Commits on May 12, 2015
  1. @myronmarston
Commits on May 8, 2015
  1. @myronmarston

    Merge pull request #1959 from mxie/mx-fix-context-typo

    myronmarston authored
    Rephrase the explanation of using shared contexts via metadata
Commits on May 6, 2015
  1. @myronmarston

    Merge pull request #1957 from JoshCheek/more_helpful_assertions_for_m…

    myronmarston authored
    More helpful assertions on memory leak test
Commits on May 5, 2015
  1. @myronmarston

    Merge pull request #1955 from rspec/update-travis-build-scripts-2015-…

    myronmarston authored
    Updates from rspec-dev (2015-05-05)
Commits on Apr 30, 2015
  1. @myronmarston

    Refactor example creation.

    myronmarston authored
    - Remove unnecessary `Array#last` call.
    - This version is threadsafe, whereas the prior
      version wasn’t.  Consider what would happen if
      another thread added an example to the `examples`
      array while this was happening: it would have returned
      a different example than the one created here. We don’t
      actually do any multithreading when examples are defined,
      and have no plans to do so, but it’s always nice to make
      things more threadsafe.
Commits on Apr 29, 2015
  1. @myronmarston

    Merge pull request #1950 from JoshCheek/1921_fix_memory_leak

    myronmarston authored
    Allows user code to retain references to memoized helpers
Commits on Apr 25, 2015
  1. @myronmarston

    `c.mock_framework = :foo` => `c.mock_with :foo`

    myronmarston authored
    Both work but the latter is the way we document the
    config elsewhere, so it's worth standardizing here.
Commits on Apr 22, 2015
  1. @myronmarston

    Merge pull request #1944 from fabschurt/fix-typo

    myronmarston authored
    Correct a misspelled word in a feature
Commits on Apr 18, 2015
  1. @myronmarston

    Tell users where the invalid options came from.

    myronmarston authored
    Addresses the confusion reported in rspec/rspec-rails#1356.
Something went wrong with that request. Please try again.