Permalink
Switch branches/tags
Commits on Aug 1, 2013
  1. be truthy

    JonRowe committed Aug 1, 2013
  2. Convert Metadata to use composition rather than inheritance.

    myronmarston committed with JonRowe Jul 17, 2013
    - It's best to avoid subclassing core types like Hash.
    - Remove runtime module extensions, since that blows MRIs method
      caches and has an affect on perf.
    - Instantiation was a two part process: `.new` followed by `process`.
      Conceptually, these belong together, so switch to using a single
      method for instantiation.
    
    Two gotchas I discovered:
    
    - The `include` matcher didn't initially work properly with `Metadata`.
      It uses an `is_a?(Hash)` check to know how to treat the object.
      To solve this, we override `is_a?` to return true for Hash.
    - `dup` didn't work as expected. `dup` is used to get a copy that can be
      modified without affecting the original; however, `dup` was simply
      duping the wrapping object, and each retained a reference to the same
      wrapped hash, causing changes on one to show up on the other. I override
      `dup` and `clone` to address this.
  3. Refactor metadata setup code in specs.

    myronmarston committed with JonRowe Jul 19, 2013
    Rather than instantiating it and calling `process`, it makes more sense
    to pass in all the args into one method. This prepares the way for that.
Commits on Jul 29, 2013
  1. Merge pull request #1023 from rspec/fix_toplevel_definition_in_modules

    JonRowe committed Jul 29, 2013
    deprecation warnings when spec enclosed in a module
  2. Change log entry

    JonRowe committed Jul 29, 2013
    [skip ci]
  3. fix build when run in certain ordering

    JonRowe committed Jul 29, 2013
    TIL SharedExampleGroups aren't world safe (i.e. contained to the
    world), this is a temporary fix to allow the build to pass regardless
    of order, but I'm going to refactor this at some point
Commits on Jul 25, 2013
  1. Merge pull request #1019 from rspec/warn_if_pattern_set_after_specs

    soulcutter committed Jul 25, 2013
    Warn if pattern is set after spec files loaded
Commits on Jul 24, 2013
  1. label bugfixes

    JonRowe committed Jul 24, 2013
  2. Merge pull request #1015 from rspec/safely_clear_shared_example_groups

    JonRowe committed Jul 24, 2013
    Safely clear shared example groups, rebased, speced and changelogged.
Commits on Jul 23, 2013
  1. reword changelog

    JonRowe committed Jul 23, 2013
  2. Change SharedExampleGroup::Registry from a singleton module to a class.

    myronmarston committed Jul 23, 2013
    This makes it far easier to test it in isolation without need
    for any gymnastics.
  3. Revert "update docstring and simulate spec circumstances"

    myronmarston committed Jul 23, 2013
    This reverts commit e7d7856.
Commits on Jul 22, 2013
  1. fixing nilclass error when clearing shared example groups

    thepoho committed with JonRowe Jul 22, 2013
    Problem occurred for me running guard-jruby-rspec on windows.
  2. Merge pull request #1013 from rspec/switch_to_truthy_matchers

    JonRowe committed Jul 22, 2013
    Switch to be_truthy and be_falsey
  3. switch to truthy and falsey

    JonRowe committed Jul 22, 2013
  4. Reword changelog message.

    myronmarston committed Jul 22, 2013
    [ci skip]
  5. Merge pull request #999 from rspec/warn_for_non_integer_profile_counts

    myronmarston committed Jul 22, 2013
    Warn about non integer --profile arguments
  6. Merge pull request #1002 from rspec/autoload_other_rspec_libs_master

    myronmarston committed Jul 22, 2013
    Autoload RSpec::Mocks and RSpec::Expectations. (master)
  7. Merge pull request #1005 from rspec/update_alias_example_to_cuke

    myronmarston committed Jul 22, 2013
    alias_example_to cuke shows how to define `fit` as if it's not part of rspec-core but it is now
  8. update alias example spec

    JonRowe committed Jul 21, 2013
Commits on Jul 21, 2013
  1. Merge pull request #1004 from alindeman/current_example

    alindeman committed Jul 21, 2013
    Adds `RSpec.current_example`
  2. Uses thread-local variables

    alindeman committed Jul 21, 2013
    * While RSpec isn't necessarily thread safe right now, it might be in
      the future.