Permalink
Switch branches/tags
Commits on Mar 12, 2013
  1. 2.13.1 release.

    myronmarston committed Mar 12, 2013
  2. Add missing changelog entry for #808.

    myronmarston committed Mar 12, 2013
    [ci skip]
  3. Clarify changelog entry.

    myronmarston committed Mar 12, 2013
    [ci skip]
  4. Merge pull request #827 from cupakromer/fix-issue-820

    myronmarston committed Mar 12, 2013
    Ensure let block is not passed to super call.
  5. I'm still getting undefined const RbConfig on travis.

    myronmarston committed Mar 12, 2013
    I think this should fix it.
  6. Fix travis CI build.

    myronmarston committed Mar 12, 2013
    - Bundler 1.3 needs rbconfig to be required to run `bin/rspec` after
      installing with `--standalone --binstubs`.
      bundler/bundler#2382
    - The Travis VMs no longer have 32-bit JVMs available. Aruba 0.4.11
      forced the -d32 flag. 0.5 just documents it and makes a file available
      to require that will set it. We've updated Aruba here so that the jruby
      ENV vars aren't set automatically; we've kept the flag to disable JIT
      but removed -d32.
    - Aruba now has a "the file xyz shoudl contain" step.
  7. Merge pull request #824 from pjg/readme_tweaks

    myronmarston committed Mar 12, 2013
    Fix README example spec to display actual output
Commits on Mar 11, 2013
  1. Relax the ZenTest dependency.

    myronmarston committed Mar 11, 2013
    4.6.2 will no longer install on travis because it requires rubygems ~> 1.8, and travis now has rubygems 2.0 installed.
Commits on Mar 10, 2013
  1. Ensure let block is not passed to super call.

    cupakromer committed Mar 10, 2013
    Fix #820. This is directly related to bug
    http://bugs.ruby-lang.org/issues/8059.  It seems to affect Ruby 1.9.3
    but not Ruby 2.0.0. As per the notes, it is a heisenbug, so simply
    looking at it causes the bug to disappear.
    
    Force the call to super to make sure the let block is not passed in.
Commits on Mar 9, 2013
  1. Merge pull request #823 from rspec/let_before_all

    myronmarston committed Mar 9, 2013
    Revise before(:all)/let behavior based on feedback from @dchelimsky.
  2. Add changelog entries for #823, #821, #813, #811, and #802.

    myronmarston committed Mar 9, 2013
    [ci skip]
  3. Revise before(:all)/let behavior based on feedback from @dchelimsky.

    myronmarston committed Mar 9, 2013
    - This is closer to the behavior we've had in 2.12 and earlier. `let`
      declarations that are accessed in `before(:all)` will preserve their
      memoized value for all examples in the group.
    - On 2.12 and earlier, this would cause additional `let` declarations
      that were not accessed in `before(:all)` but were accessed in individual
      examples to "leak", because the same `__@memoized` ivar got shared
      with each example in the group, and would be mutated each time an
      additional `let` declaration was accessed. This commit changes
      that behavior. The fact that one `let` declaration is accessed in
      `before(:all)` does not affect the lifecycle of other `let` declarations
      in any way.
Commits on Mar 3, 2013
  1. Merge pull request #813 from rspec/let_before_all_warn_caller

    myronmarston committed Mar 3, 2013
    Include caller in warning msg for `let` usage in `before(:all)`.
Commits on Mar 2, 2013
  1. Merge pull request #811 from rspec/let_before_all

    myronmarston committed Mar 2, 2013
    Clear let/subject memoization when referenced in before(:all).
  2. Use `double` rather than `mock` or `stub`.

    myronmarston committed Mar 2, 2013
    ...since `mock` and `stub` have been deprecated in rspec-mocks.
Commits on Mar 1, 2013
  1. Changelog for #800 / #804.

    myronmarston committed Mar 1, 2013
    [ci skip]
  2. Merge pull request #804 from rspec/issue-800

    myronmarston committed Mar 1, 2013
    Candidate fix for #800
Commits on Feb 28, 2013
  1. Merge pull request #809 from youdevise/master

    myronmarston committed Feb 28, 2013
    Require set where it's needed. Fixes #808
  2. Require set where it's needed. Fixes #808

    Tom Anderson committed Feb 28, 2013
  3. Merge pull request #806 from vfrride/patch-1

    myronmarston committed Feb 28, 2013
    Uses secure RubyGems URL
  4. Uses secure RubyGems URL

    vfrride committed Feb 28, 2013
Commits on Feb 27, 2013
  1. Improve on e93b5d0.

    myronmarston committed Feb 27, 2013
    - Ensure the NamedSubject override module gets inserted in the
      ancestor chain at the right place (this wasn't guaranteed before).
    - Raise an error when `super` is used in a named subject. I don't
      think we should support it.
  2. Add missing changelog entry for #730.

    myronmarston committed Feb 27, 2013
    [ci skip]
  3. Fix inner/outer subject confusion when using a named subject.

    myronmarston committed Feb 25, 2013
    Fixes #800.
    
    Note that the complexity of supporting `super` in a named subject makes me think that we should disable `super` in named subjects altogether instead.
Commits on Feb 24, 2013
  1. Improve on 0c56b9b.

    myronmarston committed Feb 24, 2013
    - The options state really belongs with the hook when the instance is created.
      Better to pass it in the initializer than to have a separate `with` method
      for setting it.
    - No need to wrap/unwrap the block with a proc an extra time; we can just
      pass the proc directly into the initializer.