Skip to content
This repository
branch: master

Apr 18, 2014

  1. Myron Marston

    Merge pull request #1490 from rspec/metadata-regression

    Fix a regression in our metadata backwards compatibility
    authored April 17, 2014
  2. Myron Marston

    Fix another bug in metadata backwards compatibility.

    In RSpec 2.x, an example's `metadata[:example_group]`
    did not returned it's example group's `metadata`,
    but rather it's example group's `metadata[:example_group]`,
    which is where all the computed values for the example
    group went.
    
    In RSpec 3, we've simplified this nesting structure
    (it's silly to put an example group's computed
    properties on a nested subhash keyed by `:example_group`),
    but our backwards compatibility didn't work properly with this.
    
    The problem was that `example.metadata[:example_group][:example_group]`
    returned the `LegacyExampleGroupHash` available off of
    `example.example_group.metadata[:example_group]`, which contains
    the computed properties of the example group, but on 2.99 this
    returned the computed properties of the parent group of the example's
    group.
    
    Unfortunately, I had to make one spec pending as I can't find
    a way to keep it passing with the difference in how the
    metadata is exposed from an example vs a group, but it really
    only matters when people mutate the metadata hash and that's
    not a normal, supported use case.  I think the backwards compatibility
    is more important right now.  We may revert this at some point
    after 3.0's been out for awhile and people have had time to
    adjust to the deprecation warnings issued for the metadata changes.
    authored April 17, 2014

Apr 17, 2014

  1. Myron Marston

    Fix metadata backwards compat to handle deep nesting.

    This is a bit confusing, but the behavior in 2.x was:
    
    * a group's `metadata` did not have it's computed
      keys directly available; they were exposed off of
      the `:example_group` subhash.
    * The `:example_group` subhash had a `:example_group`
      key that exposed the parent group's metadata
      (both user metadata and computed keys).
    
    Before this, we were inserting extra `:example_group`
    subhashes between the layers.
    authored April 17, 2014

Apr 13, 2014

  1. Myron Marston

    Merge pull request #1470 from rspec/remove_legacy_formatter_support

    Remove support for inherited legacy formatters [WIP]
    authored April 12, 2014

Apr 10, 2014

  1. Myron Marston

    Merge pull request #1479 from rspec/fix-around-hook-yielded-arg

    Fix around hook yielded arg
    authored April 09, 2014
  2. Myron Marston

    Improve Example docs.

    authored April 09, 2014
  3. Myron Marston

    Provide Example interface on around hook yielded arg.

    Fixes #1477.
    authored April 09, 2014

Apr 06, 2014

  1. Myron Marston

    Merge pull request #1449 from rspec/match_core_to_expectations_mocks

    Make rspec-cores Gemfile match mocks/expectations setup for yard
    authored April 06, 2014

Apr 03, 2014

  1. Myron Marston

    Run against all examples (including `describe` one).

    authored April 03, 2014
  2. Myron Marston

    Add changelog for #1465.

    [ci skip]
    authored April 03, 2014
  3. Myron Marston

    Merge pull request #1465 from waterlink/issue-1433-disable-all-monkey…

    …-patching-option
    
    Added option to disable all monkey patching
    authored April 03, 2014

Mar 31, 2014

  1. Myron Marston

    Add :parent_example_group to RESERVED_KEYS.

    It's managed by us so users shouldn't pass that metadata.
    authored March 31, 2014
  2. Myron Marston

    Merge pull request #1462 from rspec/issue-1354

    Provide assertions accessor for minitest.
    authored March 30, 2014

Mar 30, 2014

  1. Myron Marston

    Merge pull request #1467 from rspec/update-travis-build-scripts-2014-…

    …03-30-for-master
    
    Updates from rspec-dev (2014-03-30)
    authored March 30, 2014
  2. Myron Marston

    Updated travis build scripts (from rspec-dev)

    authored March 30, 2014
  3. Myron Marston

    Merge pull request #1464 from rspec/try_travis_without_rubysl

    Try Travis RBX builds without specific gemfile dependencies
    authored March 30, 2014
  4. Myron Marston

    Merge pull request #1463 from rspec/update-travis-build-scripts-2014-…

    …03-29-for-master
    
    Updates from rspec-dev (2014-03-29)
    authored March 29, 2014

Mar 29, 2014

  1. Myron Marston

    Updated travis build scripts (from rspec-dev)

    authored March 29, 2014

Mar 28, 2014

  1. Myron Marston

    Merge pull request #1458 from rspec/deprecation-stream-fixes-3-0

    Deprecation stream fixes 3 0
    authored March 28, 2014
  2. Myron Marston

    Warn if setting `config.deprecation_stream` is ignored.

    authored March 25, 2014
  3. Myron Marston

    Update the "too many deprecations" message.

    ...so that it mentions the new `--deprecation-out` CLI option.
    authored March 25, 2014
  4. Myron Marston

    Add `--deprecation-out` CLI option.

    authored March 27, 2014

Mar 27, 2014

  1. Myron Marston

    Merge pull request #1456 from rspec/add-ordering-changelogs

    Add missing change logs for 3.0.0.beta1 ordering changes.
    authored March 27, 2014
  2. Myron Marston

    Merge pull request #1457 from rspec/make-ConfigurationOptions-public

    Make configuration options public
    authored March 27, 2014
  3. Myron Marston

    Cleanup some more docs.

    authored March 26, 2014
  4. Myron Marston

    Implement the last pending spec.

    authored March 26, 2014
  5. Myron Marston

    Add missing change logs for 3.0.0.beta1 ordering changes.

    [ci skip]
    authored March 26, 2014
  6. Myron Marston

    Declare DRb classes private.

    There's no good reason for these to be public.
    As far as I can tell, there is no external code
    using them. I did a github search and couldn't
    find anything, and looked in detail at the one
    project I expected to use them (spark) and it
    does not.
    authored March 26, 2014
  7. Myron Marston

    Rename `DRbCommandLine` to `DRbRunner`.

    As in 7c02260,
    I don't feel like `CommandLine` describes
    what the class did. Runner makes more sense.
    authored March 26, 2014
  8. Myron Marston

    Rename `DrbOptions` to `DRbOptions`.

    All the stdlib DRb stuff uses the "DRb" casing,
    so we should follow that.
    authored March 26, 2014
  9. Myron Marston

    Move `drb_argv_for` into the class where it belongs.

    authored March 26, 2014
  10. Myron Marston

    Make ConfigurationOptions officially public.

    Closes #1355.
    authored March 26, 2014

Mar 26, 2014

  1. Myron Marston

    Merge pull request #1454 from rspec/runner-improvements

    Runner improvements
    authored March 26, 2014
  2. Myron Marston

    Add changelog entries.

    authored March 26, 2014
  3. Myron Marston

    I prefer `.` for message sends.

    `::` is primarily for constant scoping. Using it
    for message sends is a bit non-standard.
    authored March 26, 2014
Something went wrong with that request. Please try again.