Permalink
Commits on Oct 1, 2016
  1. Forward port 3.5.4 release notes.

    [ci skip]
    myronmarston committed Oct 1, 2016
Commits on Sep 28, 2016
  1. Merge pull request #2335 from yui-knk/fix_typos

    [ci skip] Fix typos
    yujinakayama committed on GitHub Sep 28, 2016
  2. [ci skip] Fix typos

    yui-knk committed Sep 28, 2016
  3. Merge pull request #2334 from rspec/update-common-markdown-files-2016…

    …-09-28-for-master
    
    Updates from rspec-dev (2016-09-28)
    JonRowe committed on GitHub Sep 28, 2016
Commits on Sep 19, 2016
  1. Changelog for #2328

    [skip ci]
    JonRowe committed on GitHub Sep 19, 2016
  2. Merge pull request #2328 from TravisSpangle/master

    Fix for #2312
    JonRowe committed on GitHub Sep 19, 2016
Commits on Sep 18, 2016
  1. cleaned up coding style with rubocop.

    TravisSpangle committed Sep 18, 2016
  2. Calling on top level groups so that it is not redundandtly called on …

    …lower level groups.
    TravisSpangle committed Sep 18, 2016
  3. Merge pull request #2331 from rspec/myron/move-options-in-help-output

    Organize options in `--help` output more logically.
    JonRowe committed on GitHub Sep 18, 2016
  4. Organize options in `--help` output more logically.

    * `--init` belongs in the utility section with `--version`
      and `--help`.  It's not a normal option that warrants being
      listed near the top.
    * `--dry-run` is an output option and belongs in that section.
    myronmarston committed Sep 18, 2016
Commits on Sep 11, 2016
  1. Merge pull request #2327 from rspec/change_git_to_https

    Change gemfile read only git from git to https
    JonRowe committed on GitHub Sep 11, 2016
Commits on Sep 10, 2016
  1. word reset clears example group constants to prevent leaks #2312

    TravisSpangle committed Sep 10, 2016
  2. Merge pull request #2323 from rspec/myron/handle-spec-file-load-errors

    Handle errors during spec file load time in a nicer manner.
    JonRowe committed on GitHub Sep 10, 2016
  3. change from read only git to https

    JonRowe committed Sep 10, 2016
Commits on Sep 9, 2016
  1. Handle errors during spec file load time in a nicer manner.

    - Format them like other errors.
    - Allow other files to be loaded so you can see all
      the load-time errors.
    - Abort the test suite before running any examples.
    
    This has a slight affect on the bisect server: previously
    it would get no run results at all if a load-time error
    occurred in the spec files. Now it gets run results but
    they are empty. The change happens because the error is handled,
    allowing the bisect formatter to report results in `start_dump`.
    myronmarston committed Sep 2, 2016
Commits on Sep 8, 2016
  1. Ensure `ConsoleCodes` is loaded in all files that reference it.

    Previously, it was required from `base_text_formatter`
    and `profile_formatter`, but was used from a number of
    other places. An unrelated change I was making that affected
    bisect caused it to hit a code path that tried to use
    `ConsoleCodes` without it being loaded, resulting in an error.
    
    Note: I had to change `CONFIG_COLORS_TO_METHODS` from a constant
    to a method to delay the `Configuration.instance_methods` call.
    With the require changes, the `console_codes` file is now loaded
    before `configuration` and therefore cannot query it at load
    time.
    myronmarston committed Sep 6, 2016
Commits on Sep 2, 2016
  1. Forward port 3.5.3 release notes.

    myronmarston committed Sep 2, 2016
  2. Merge pull request #2320 from rspec/myron/fix-after-context-failures

    Set the exit status to non-zero for `after(:context)` errors.
    JonRowe committed on GitHub Sep 2, 2016
Commits on Sep 1, 2016
  1. Set the exit status to non-zero for `after(:context)` errors.

    Fixes #2084.
    myronmarston committed Sep 1, 2016
Commits on Aug 29, 2016
  1. Merge pull request #2316 from rspec/myron/handle-errors-in-suite-hooks

    Handle errors in :suite hooks.
    JonRowe committed on GitHub Aug 29, 2016
Commits on Aug 25, 2016
  1. Merge pull request #2318 from rspec/myron/address-slowness

    Fix issue causing our spec suite to run much slower.
    JonRowe committed on GitHub Aug 25, 2016
  2. Fix issue causing our spec suite to run much slower.

    Before this change:
    
    $ bin/rspec | egrep 'Finished|(examples.*failure)'
    Finished in 45.99 seconds (files took 0.89765 seconds to load)
    2014 examples, 4 failures, 1 pending
    
    After this change:
    
    $ bin/rspec | egrep 'Finished|(examples.*failure)'
    Finished in 11.16 seconds (files took 1.16 seconds to load)
    2014 examples, 4 failures, 1 pending
    
    I believe the issue was requiring 'rspec/rails/version'. Since
    rspec-rails is not available, rubygems would exhaustively search
    all my installed gems before raising `LoadError`. I have ~300 gems
    installed and this was quite slow.
    
    It's better to just force it to raise `LoadError` and not wait on
    RubyGems to do the same thing.
    myronmarston committed Aug 25, 2016
  3. Address code review feedback.

    - s/exception/example/ in a comment
    - Do not run later `before(:suite)` hooks when an earlier
      one has failed. This aligns with `before(:example)` and
      `before(:context)` hooks.  However, `after(:suite)` hooks
      all get run even if one fails, which again aligns with
      `after(:example)` and `after(:suite)` hooks.
    myronmarston committed Aug 25, 2016
  4. Handle errors in :suite hooks.

    Previously, we just allowed the error to propagate to
    the user, which was a subpar experience for a few reasons:
    
    - The error would cause RSpec to crash, leading to a long
      stack trace containing lots of extraneous info the user
      did not see.
    - The error was not formatted nicely like other errors
      that happen while RSpec runs.
    - If the error happened in an `after(:suite)` hook, the test
      suite had finished running all specs but the summary of the
      results would not get printed since RSpec had crashed.
    
    Now, we handle errors in :suite hooks and format the output
    the same way failures and errors are normally printed.
    myronmarston committed Jul 11, 2016
Commits on Aug 24, 2016
Commits on Aug 23, 2016
Commits on Aug 22, 2016
  1. Refactor: support `FailedExampleNotification.new(example)`.

    Previously, a second `exception_presenter` argument was required.
    myronmarston committed Jul 11, 2016
Commits on Aug 20, 2016
  1. Make `ExceptionPresenter#fully_formatted` support a `nil` arg.

    This is necessary for cases where the error is not part
    of a numbered sequence (such as a :suite hook error).
    myronmarston committed Aug 20, 2016
  2. Merge pull request #2313 from rspec/myron/make-spec-resilient

    Make spec resilient to changes to this spec file.
    myronmarston committed on GitHub Aug 20, 2016
  3. Make spec resilient to changes to this spec file.

    Hard coding the line number was very brittle.
    myronmarston committed Aug 20, 2016