Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Comparing changes

Choose two branches to see what's changed or to start a new pull request. If you need to, you can also compare across forks.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also compare across forks.
base fork: rspec/rspec-core
base: v2.11.0
...
head fork: rspec/rspec-core
compare: hooks
Checking mergeability… Don't worry, you can still create the pull request.
Commits on Apr 08, 2012
@dchelimsky dchelimsky no need to wrap the proc in another proc 6dd8346
@dchelimsky dchelimsky store around hooks in the order they'll be run (less reversal) 30aeca9
@dchelimsky dchelimsky remove unused implementation ad6dba5
@dchelimsky dchelimsky less indirection d6f74cd
@dchelimsky dchelimsky collect before/after each hooks and then run them 644577b
@dchelimsky dchelimsky refactor around hooks - move the running to Hooks, like before/after
hooks
28adc87
@dchelimsky dchelimsky extend proc objects as hooks rather than wrapping them 1847c8b
@dchelimsky dchelimsky add global before/after each/all hooks when creating the ExampleGroup
subclass.

This allows us to use `prepend_before` to actually prepend a before hook
even before the global hooks. Same with `append_after`.
d0eb31c
@dchelimsky dchelimsky less feature envy 91a36b3
@dchelimsky dchelimsky refer to around_each_hooks for consistency b782040
@dchelimsky dchelimsky align shape of xxx_hooks_for methods 434c42f
@dchelimsky dchelimsky silly whitespace e59f32c
@dchelimsky dchelimsky move all the xxx_hooks_for methods to hooks 11e6bb8
@dchelimsky dchelimsky better alignment in hooks - patterns emerging 47caa63
@dchelimsky dchelimsky remove redundant filtering e9dcc66
@dchelimsky dchelimsky prune once (where possible) de3b50e
@dchelimsky dchelimsky just use arrays until extensions are needed b455381
@dchelimsky dchelimsky there is no else 3b7f32c
@dchelimsky dchelimsky more alignment of collection/filtering of around,before,after :each h…
…ooks
15cf1f3
@dchelimsky dchelimsky remove unnecessary args 0dae6c0
@dchelimsky dchelimsky align sigs across more hooks 322017f
@dchelimsky dchelimsky shorten some method names a374041
@dchelimsky dchelimsky remove obsolete find_hook 83060d3
@dchelimsky dchelimsky around hooks should not be reversed 2e0eb89
@dchelimsky dchelimsky turns out there was an else a007d67
@dchelimsky dchelimsky delegate from the proxy, not through it 6009512
@dchelimsky dchelimsky add a default dc81c68
@dchelimsky dchelimsky delegate instance_eval_with_args 0ada067
@dchelimsky dchelimsky assign group earlier 7abc508
@dchelimsky dchelimsky just call prune for ea55b2e
@dchelimsky dchelimsky finish normalizing the collection of each type of hook edef60b
Something went wrong with that request. Please try again.