Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Comparing changes

Choose two branches to see what's changed or to start a new pull request. If you need to, you can also compare across forks.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also compare across forks.
base fork: rspec/rspec-core
base: v2.2.0
...
head fork: rspec/rspec-core
compare: rspec-mocks-configuration
This comparison is big! We're only showing the most recent 250 commits
Commits on Mar 18, 2012
@preethiramdev preethiramdev Adding prepend before 15fa016
@preethiramdev preethiramdev Comments 70433f3
@preethiramdev preethiramdev Adding append_after, prepend_after, changes to after hooks storage an…
…d run method
b310288
@dchelimsky dchelimsky Hook collections are all the same now, so we only need one type. 76899a6
@dchelimsky dchelimsky rdoc tweaks for #579 d46c857
@dchelimsky dchelimsky provide a default ExampleGroup to eliminate conditionals running hooks 6999128
@dchelimsky dchelimsky refactor the [prepend|append]_[before|after] examples 9401cba
@dchelimsky dchelimsky Changelog for #579 f85d405
Commits on Mar 23, 2012
@justinko justinko Properly parse `SPEC_OPTS` options. Fixes #586 268eeb4
@dchelimsky dchelimsky add benchmark comparing block.call v yield
[ci skip]
5436bc2
@dchelimsky dchelimsky example.description returns the location of the example if there is no
explicit description or matcher-generated description.

- Fixes #585.
34cb8f9
Commits on Mar 24, 2012
@gswirski gswirski Fixed formatting of code examples in documentation.
Some `@example` tags were missing, I believe.
a481276
@dchelimsky dchelimsky Merge pull request #589 from sognat/patch-1
Fixed formatting of code examples in documentation.
49966db
@dchelimsky dchelimsky Changelog for #589 26e9548
@dchelimsky dchelimsky Use relative path for example.location. 107d676
@grosser grosser Do not modify example ancestry when dumping errors
This causes bugs (Notably that after blocks / transaction rollback is not executed properly)
when errors are dumped while examples are still running
as is done by [rspec-instafail](https://github.com/grosser/rspec-instafail) and therefore fuubar formatter.
91dbe44
@dchelimsky dchelimsky Merge pull request #588 from grosser/preserve_ancestry_on_failure
Do not modify example ancestry when dumping errors
3ff65ad
@dchelimsky dchelimsky Changelog for #588 [ci skip] fbe0e75
Commits on Mar 31, 2012
@dchelimsky dchelimsky beef up rdoc about let 78eb9e8
@dchelimsky dchelimsky more doc for subject method [ci skip] d39157b
@dchelimsky dchelimsky embrassed? seriously?
[ci skip]
cbfa05a
Commits on Apr 04, 2012
@dchelimsky dchelimsky add doc files to .yardopts
[ci skip]
ba9b62d
Commits on Apr 07, 2012
@dchelimsky dchelimsky add info to README about storing command line options in .rspec and a…
…utotest integration

[ci skip]
9d37689
Commits on Apr 08, 2012
@dchelimsky dchelimsky remove unnecessary guard 62ae302
@dchelimsky dchelimsky Remove obsolete guard against building in ruby 1.9
[ci skip]
331a6e4
@dchelimsky dchelimsky prepend_before now prepends local hooks before global hooks.
- Provides support for rspec/rspec-rails#391.
- Also refactored the hooks infrastructure such that most of the work is
  done within the hooks module rather than spreading it out across its
  different consumers.
82e398e
Commits on Apr 13, 2012
@moro moro refactor test, return identically same object from stubbed examples() b08810b
@moro moro prints ocuppied time of slow tests. 361cd64
@moro moro fix ZeroDivisionError when no test ran. 1708e15
@moro moro fix broken test fbe337e
Commits on Apr 16, 2012
@moro moro Improve result message. 9e8643d
Commits on Apr 18, 2012
@justinko justinko Merge pull request #602 from moro/display-slow-tests-occupied-time
Display slow tests occupied time
e9b1776
@justinko justinko Remove extraneous word. 4d9472e
@justinko justinko Fix for 1.8 1c0ce8d
@justinko justinko changelog [ci skip] a777f09
@justinko justinko JRuby is too fast!! (need to get an execution result time) 343c9e2
@justinko justinko line break [ci skip] a1cae36
@justinko justinko Handle zero execution time for profiling. This could happen if nothin…
…g is called in an example block.
0a039ad
@justinko justinko Attempt to get JRuby to report an execution time for profiling. 6c37ec5
Commits on Apr 20, 2012
@exviva exviva Fix warning
lib/rspec/core/subject.rb:91: warning: shadowing outer local variable - subject
a9d1b7b
@exviva exviva Fix a bunch of warnings
spec/rspec/core/example_spec.rb: warning: `-' after local variable
is interpreted as binary operator even though it seems like unary operator
1ef1719
@justinko justinko Merge pull request #603 from exviva/fix_warnings
Fix warnings
c38797d
@eregon eregon raise an ArgumentError when the arity of a Proc filter is wrong
Otherwise the filter is not evaluated and considered to return nil
06d9646
@myronmarston myronmarston Merge pull request #604 from eregon/filter-proc-arity
raise an ArgumentError when the arity of a Proc filter is wrong
346f71c
@eregon eregon do not assume the user has the default progress formatter in its conf…
…iguration
675e060
@myronmarston myronmarston Merge pull request #571 from eregon/formatter_config
Some tests depend on absence of formatter in ~/.rspec
25e854f
Commits on Apr 21, 2012
@dchelimsky dchelimsky minor refactoring: extract method 999d04c
@dchelimsky dchelimsky dev: align use of FakeFS 8e816eb
Commits on Apr 22, 2012
@dchelimsky dchelimsky Changelog formatting tweak [ci skip] 36f6e22
@dchelimsky dchelimsky don't need file list in .yardopts 1359ae2
@dchelimsky dchelimsky dev: align Gemfiles across rspec projects 7eaa1f6
Commits on Apr 23, 2012
@jarmo jarmo fixes #396 2ea6f20
Commits on Apr 26, 2012
@dchelimsky dchelimsky make append_before and prepend_after aliases of before and after 18e452d
Commits on Apr 27, 2012
@dchelimsky dchelimsky minor refactoring and making private things private c98d538
Commits on May 01, 2012
@dchelimsky dchelimsky update yard to 0.8 9d8a6cc
@alexch alexch formatters run better when $SAFE mode is on
Setting $SAFE=3 causes some file operations to raise a SecurityError. This patch allows you to run in SAFE mode without those SecurityErrors masking the real errors raised by the code under test and/or by RSpec matcher failures.

I extracted the SAFE setting/resetting logic into a helper method called "safely" since it's called from several places.
576b82d
@alexch alexch improve rdoc comments in BaseFormatter f87b634
@alexch alexch basic JsonFormatter 972591b
Commits on May 02, 2012
@dblock dblock Shellsplitting input in -O. 531c0a6
Commits on May 03, 2012
@dchelimsky dchelimsky Merge pull request #610 from dblock/shellsplit-dahs-o
Shellsplitting input in custom options file.
ff8d188
Commits on May 04, 2012
@dchelimsky dchelimsky update changelog for 2.10 release 89c44ef
@dchelimsky dchelimsky bump to 2.10.0 95bf11b
@dblock dblock Ported support for mutliple -e options from #596. 2f88804
Commits on May 06, 2012
@dchelimsky dchelimsky dev: remove obsolete filter 1ad7087
@dchelimsky dchelimsky dev: clean up some specs b1b2ae6
Commits on May 08, 2012
@dchelimsky dchelimsky `config.mock_with` and `config.expect_with` yield custom config object
to a block if given

This supports decoupled config for other rspec and 3rd party libs.

    RSpec.configure do |c|
      c.expect_with ExpectationFramework do |other_framework_config|
        other_framework_config.custom_setting = true
      end
      c.mock_with OtherFramework do |other_framework_config|
        other_framework_config.custom_setting = true
      end
    end
651d8d9
@dblock dblock A prettier implementation via @justinko. dc33f77
Commits on May 09, 2012
@dchelimsky dchelimsky rdoc format [ci skip] a0202ea
Commits on May 13, 2012
@justinko justinko Merge pull request #614 from dblock/multiple-eees
Allow specifying multiple -e (--example) options
22e689c
@justinko justinko changelog [ci skip] 1004353
Commits on May 16, 2012
@dchelimsky dchelimsky spec refactoring: replace subject with intention revealing name e343cba
@dchelimsky dchelimsky Support a 'name' arg to subject declaration
Closes #619.

Example:

    describe Article do
      subject(:article) { Article.new }
      it { supports_one_liners }
      it "supports intention revealing name" do
        article.should do_something
      end
    end
2e20683
@dchelimsky dchelimsky more Changelog for #619 [ci skip] 19e1eaf
@dchelimsky dchelimsky doc tweaks [ci skip] #619 5ea6d86
Commits on May 18, 2012
@dchelimsky dchelimsky RSpec.reset resets filters
- Fixes #621
ba15a2e
@dchelimsky dchelimsky Revert "RSpec.reset resets filters"
This reverts commit ba15a2e.
2d61d16
@dchelimsky dchelimsky RSpec.reset reinits configuration and world
- Fixes #621 (for realz)
e8eae4d
@dchelimsky dchelimsky Changelog for #621 c9b8681
@slyphon slyphon call #to_s on exception_message before calling #split
When 1.8.7 is shutting down its threads, and you're stuck in a Monitor,
it will eventually raise a SystemExit, and that SystemExit may have an
instance of Exception as its `#message` (instead of a String) which
causes the formatter to blow up.
2d39c46
@slyphon slyphon causes rspec without #622 to raise NoMethodError 6ab7614
@dchelimsky dchelimsky Merge pull request #622 from slyphon/dump_failure_info_fix
call #to_s on exception_message before calling #split
0d26b06
Commits on May 19, 2012
@dchelimsky dchelimsky RDoc improvements for shared examples, Example, and Procsy.
Also did some minor refactoring in order to be able to use Yard to
document internal-DSL-generated methods like `it`, `example`, and
`specify`.
43ec3a8
@dchelimsky dchelimsky Changelog for #622 [ci skip] 1482bfe
@dchelimsky dchelimsky Fix typo in changelog: Grzegorz M-E~Zwirski [ci skip] 18aacf7
@dchelimsky dchelimsky Revert "Fix typo in changelog: Grzegorz M-E~Zwirski [ci skip]"
It was correct before - just looked wrong in my editor.

This reverts commit d342861.
254e7c9
@dchelimsky dchelimsky Changelog after 2.10.1 release [ci skip] 03b72af
@dchelimsky dchelimsky Changelog - link url [ci skip] acf2fdf
@dchelimsky dchelimsky rdoc - use the {name} syntax for links [ci skip] d024dc9
Commits on May 20, 2012
@justinko justinko Merge pull request #605 from jarmo/bug_396
fixes #396
d7c250a
@justinko justinko Use File::ALT_SEPARATOR if it is not nil (it is on nix systems). 1d49eb6
@justinko justinko Only run windows specific specs if on the windows OS.
travis-ci will be supporting multiple OS's in the future.
e675bc3
@justinko justinko Remove redundant logic. 2a7fafb
@justinko justinko changelog 3705abd
@dchelimsky dchelimsky Re-reformat failure message.
Fixes cuke broken by 43ec3a8 caused
by reformatting a file, which accidentally re-indented a HERE doc.
3c1ed24
Commits on May 22, 2012
@myronmarston myronmarston Don't silence 2nd exceptions.
When an example raises an error and an after or around hook also raises an error, the 2nd error was being silenced, since `set_exception` was a no-op when the exception was already set.  Silencing errors is bad, so we should print the error instead.

See https://github.com/myronmarston/vcr/issues/167#issuecomment-5814249 for the issue that triggered this change.
27059bf
@myronmarston myronmarston Update changelog. 0b34e42
Commits on May 23, 2012
@myronmarston myronmarston Improve on 27059bf.
* Fix specs. The `should_receive(:message).with(/.../)` wasn't working as
  expected...it passed even if the message text didn't match the regex.
  I figured out that it was because of the fact that the error was being
  raised within the example-under-test, which already had two errors and
  was simply printing (or, previously, silencing) the extra error.  The
  solution is to capture the reported message using a stub implementation,
  and then assert on it after running the example.
* The added context ("in an after hook") for 2nd errors happening in an
  after hook wasn't being included in the printed message. This is fixed now.
d0cb324
@alexch alexch add command-line 'j' or 'json' formatter option dcfaa67
Commits on May 25, 2012
@brynary brynary Add Code Climate badge e2cc637
@dchelimsky dchelimsky Merge pull request #623 from brynary/codeclimate-badge
Add Code Climate badge
8010fc3
Commits on May 27, 2012
@justinko justinko Merge pull request #443 from nicknovitski/patch-2
use RR's rspec2 adapter (re: issue #136)
ea668aa
@justinko justinko Revert "Merge pull request #443 from nicknovitski/patch-2"
This reverts commit ea668aa, reversing
changes made to 8010fc3.
5090cc3
@dchelimsky dchelimsky minor refactoring: reduce duplication in hooks module 6837910
@dchelimsky dchelimsky remove some unnecessary conditionals 894dd4c
@dchelimsky dchelimsky Add travis-ci badge to README 80bb038
@dchelimsky dchelimsky fix typo in README [ci skip] 553608e
@dchelimsky dchelimsky README tweaks 7bfe871
Commits on May 31, 2012
@dchelimsky dchelimsky refactor: move some hooks behavior to Hooks module 0592aca
Commits on Jun 04, 2012
@dchelimsky dchelimsky use `define_method` instead of `let` for named subject
`subject` already memoizes the value
f87dfbf
@dchelimsky dchelimsky `include_examples` and `include_context` now accept a customization b…
…lock.

- Closes #615.
092a9c6
@dchelimsky dchelimsky run share_examples_for examples against shared_examples and shared_co…
…ntext
4feeec6
Commits on Jun 06, 2012
@myronmarston myronmarston Delay the loading of DRB.
- Most of the time users don't use DRB. This'll speed up the start time a bit
  by not unnecessarily loading it when it's not used.
- Apparently jruby 1.7.0-preview1 loads the delegate library when DRB is loaded [1][2].
  This causes expectations on delegate objects to fail because `should` never gets added
  to them. By delaying when delegate gets loaded, it allows a user to load
  `rspec/expectations` and then `delegate` and ensure it works.

[1] rspec/rspec-expectations#148 (comment)
[2] The backtrace at the point delegate is loaded:
/Users/myron/.rvm/rubies/jruby-head/lib/ruby/1.9/drb/drb.rb:1:in `require'
/Users/myron/.rvm/rubies/jruby-head/lib/ruby/1.9/drb/drb.rb:1:in `(root)'
/Users/myron/.rvm/rubies/jruby-head/lib/ruby/1.9/drb/drb.rb:57:in `require'
/Users/myron/.rvm/rubies/jruby-head/lib/ruby/1.9/drb/drb.rb:57:in `(root)'
/Users/myron/.rvm/gems/jruby-head/gems/rspec-core-2.10.1/lib/rspec/core/runner.rb:1:in `require'
/Users/myron/.rvm/gems/jruby-head/gems/rspec-core-2.10.1/lib/rspec/core/runner.rb:1:in `(root)'
/Users/myron/.rvm/gems/jruby-head/gems/rspec-core-2.10.1/lib/rspec/core/runner.rb:1:in `(root)'
file:/Users/myron/.rvm/rubies/jruby-head/lib/jruby.jar!/jruby/kernel19/kernel.rb:1:in `(root)'
file:/Users/myron/.rvm/rubies/jruby-head/lib/jruby.jar!/jruby/kernel19/kernel.rb:19:in `require'
file:/Users/myron/.rvm/rubies/jruby-head/lib/jruby.jar!/jruby/kernel19/kernel.rb:19:in `require_relative'
/Users/myron/.rvm/gems/jruby-head/gems/rspec-core-2.10.1/lib/rspec/core.rb:4:in `require'
/Users/myron/.rvm/gems/jruby-head/gems/rspec-core-2.10.1/lib/rspec/core.rb:4:in `require_rspec'
/Users/myron/.rvm/gems/jruby-head/bin/rspec:23:in `load'
/Users/myron/.rvm/gems/jruby-head/bin/rspec:23:in `(root)'
3646611
@hynkle hynkle fix typo 3215ad0
@justinko justinko Merge pull request #630 from hynkle/typo
fix typo
41a8efb
Commits on Jun 09, 2012
@dchelimsky dchelimsky Bump version to 2.10.1
This was done already before the 2.10.1 release, but only on the 2-10
maintenance branch.
2cf3b45
@alindeman alindeman `--require` is merged among different configuration sources
* e.g., `--require` specified in SPEC_OPTS will be merged with
  `--require` specified in `.rspec`
* Fixes #594
9518119
@alindeman alindeman Changelog for #594 [ci skip] d89c87b
Commits on Jun 11, 2012
@myronmarston myronmarston Merge pull request #629 from rspec/delay-drb-loading
Delay the loading of DRB.
9a79082
@alindeman alindeman -I is merged among configuration sources 5f730b0
Commits on Jun 15, 2012
@dchelimsky dchelimsky remove dead code 18903e1
Commits on Jun 16, 2012
@myronmarston myronmarston Don't add `describe` to every object.
Instead, make it only available on:
  - The main object--so it can be used at the top level.
  - Modules--so example groups can be declared nested
    within modules, as is the common practice.

Besides this, the only other place we need describe is from within
example groups (so we can nest them), and this is taken care of by
RSpec::Core::ExampleGroup.describe.

I got the idea for this from a recent change in Sinatra that similarly
limits the DSL to just the main object rather than all objects:

sinatra/sinatra@46bdb7d
de01e05
Commits on Jun 21, 2012
@dchelimsky dchelimsky refactoring: alias prepend and append on HookCollection
- a bit more OO
- one less conditional per hook registration
076d683
@dchelimsky dchelimsky Merge pull request #609 from alexch/json-formatter
JSON formatter
8e41f1a
@dchelimsky dchelimsky Changelog for #609 [ci skip] cfb465f
@dchelimsky dchelimsky Revert "Merge pull request #609 from alexch/json-formatter"
Failed in ci build for 1.8.7, jruby, ree

This reverts commit 8e41f1a, reversing
changes made to 076d683.
359cd38
@dchelimsky dchelimsky Restore "Merge pull request #609 from alexch/json-formatter""
Most of the commits with this merge are fine - only one is causing failures
in some rubies - we can deal with that issue separately.

This reverts commit 359cd38.
afa4250
@dchelimsky dchelimsky Revert "formatters run better when $SAFE mode is on"
This is causing failures in Ruby 1.8.7, jruby, and ree

This reverts commit 576b82d.
713ad6f
@dchelimsky dchelimsky Revert "Revert "formatters run better when $SAFE mode is on""
This reverts commit 713ad6f.
7695456
@dchelimsky dchelimsky Revert "Merge pull request #609 from alexch/json-formatter"
This reverts commit 8e41f1a, reversing
changes made to 076d683.
ed9ec72
Commits on Jun 29, 2012
@dchelimsky dchelimsky Add `config.order = 'random' to the generated spec_helper.
- Closes #635
bcd0cc2
@dchelimsky dchelimsky don't need redcarpet when running in jruby b5354ef
Commits on Jul 04, 2012
@dchelimsky dchelimsky delegate instead of alias from mocha adapter 2c60898
Commits on Jul 07, 2012
@dchelimsky dchelimsky refactor: rename method f1e2024
@dchelimsky dchelimsky update Changelog baf4c31
@dchelimsky dchelimsky bump to 2.11.0 f9ed7ab
@dchelimsky dchelimsky improve automation for publishing to relishapp.com 394e356
Commits on Jul 11, 2012
@myronmarston myronmarston Fix ruby warnings.
- lib/rspec/core/shared_example_group.rb:41: warning: `&' interpreted as argument prefix
- spec/rspec/core/configuration_spec.rb:86: warning: ambiguous first argument; put parentheses or even spaces
- spec/rspec/core/configuration_spec.rb:182: warning: ambiguous first argument; put parentheses or even spaces
- spec/rspec/core/option_parser_spec.rb:71: warning: possibly useless use of == in void context

Closes #645.
9a2f2c5
Commits on Jul 12, 2012
@myronmarston myronmarston Don't override #ancestors.
This is a core ruby method we shouldn't touch. Instead, define #parent_groups.

Closes #646.
9e8b6b9
Commits on Jul 13, 2012
@myronmarston myronmarston Make it so that other top-level DSL methods are not added to every ob…
…ject.

I did this for #describe in de01e05 but didn't notice that the shared example/context definition methods have the same issue.
3e82044
@myronmarston myronmarston Provide a more flexible ordering API.
For #547.
d0df8cb
@myronmarston myronmarston Refactor ordering/randomization logic in terms of new APIs.
For #547.
d79960b
@myronmarston myronmarston Set #order to "custom" when providing a custom ordering block.
For #547.
542dfe8
@myronmarston myronmarston Use DEFAULT_ORDERING constant. c76f471
@myronmarston myronmarston Update change log. 09bc03d
@myronmarston myronmarston Combine a few specs into one.
There's not much value in keeping these as separate individual specs--no needed for the added overhead of 3 specs when one will suffice here.
7ca3c01
@joliss joliss Fix typo
This used to be a multi-line string with "',\n    '" in it.
d8e3982
@justinko justinko Merge pull request #648 from joliss/typo
Fix typo
bf66db3
@rsperberg rsperberg Corrected misspelling of expectations 740a70f
@rsperberg rsperberg Added backticks around run_all_when_everything_filtered to prevent ge…
…nerating <em> tag
a094493
@rsperberg rsperberg Added backticks around setup_mocks_for_rspec etc to prevent underscor…
…es becoming <em> tags
3c99b70
@rsperberg rsperberg Corrected three misspellings of "arbitrary" 58967b4
@justinko justinko Merge pull request #649 from rsperberg/master
Typos in documentation
91b97be
Commits on Jul 16, 2012
@myronmarston myronmarston Fix the way we autoload RSpec::Matchers.
`autoload`, besides being deprecated by Matz, does not work to require files
that are in unactivated gems--it only works with ruby's built in require, for
files that are available relative to a directory on the load path. Instead,
we use `const_missing` to make it work.

Closes #647.
e6ecc0b
@myronmarston myronmarston Don't pollute every object in the system with a method like `require_…
…rspec`.

Instead use a local variable lambda. To make this work I had to move the
"core/extensions/*" requires into rspec/core.rb, but I think this is a
good change, anyway…given the well-known performance issues with require
on MRI 1.9.2, this change will remove one extra require.
9579895
Commits on Jul 18, 2012
@myronmarston myronmarston Ignore mock expectation failures when the example has already failed.
Mock expectation failures have always been ignored in this situation,
but due to my changes in 27059bf it was printing a confusing message.

Closes #651.
e22ce0b
@myronmarston myronmarston Fix ruby warnings.
- lib/rspec/core/shared_example_group.rb:41: warning: `&' interpreted as argument prefix
- spec/rspec/core/configuration_spec.rb:86: warning: ambiguous first argument; put parentheses or even spaces
- spec/rspec/core/configuration_spec.rb:182: warning: ambiguous first argument; put parentheses or even spaces
- spec/rspec/core/option_parser_spec.rb:71: warning: possibly useless use of == in void context

Closes #645.
1f78187
@joliss joliss Fix typo
This used to be a multi-line string with "',\n    '" in it.
e75df2c
@myronmarston myronmarston Fix the way we autoload RSpec::Matchers.
`autoload`, besides being deprecated by Matz, does not work to require files
that are in unactivated gems--it only works with ruby's built in require, for
files that are available relative to a directory on the load path. Instead,
we use `const_missing` to make it work.

Closes #647.
2e32d6e
@myronmarston myronmarston Update change log. c2ea08c
@myronmarston myronmarston Ignore mock expectation failures when the example has already failed.
Mock expectation failures have always been ignored in this situation,
but due to my changes in 27059bf it was printing a confusing message.

Closes #651.
30e81b5
Commits on Jul 19, 2012
@myronmarston myronmarston 2.11.1 release. b819726
@myronmarston myronmarston Merge branch '2-11-maintenance'
Conflicts:
	Changelog.md
340eb56
Commits on Jul 31, 2012
Sam Goldman Fix Metadata#fetch to support computed values.
If example.metadata.fetch(:description) was called before example.metadata[:description], fetch would raise a KeyError.
b28da55
Commits on Aug 01, 2012
@dchelimsky dchelimsky Merge pull request #657 from samwgoldman/fetch
Fix Metadata#fetch to support computed values.
215bdb4
@dchelimsky dchelimsky Changelog for #657. 07be957
Commits on Aug 04, 2012
@moredip moredip start extracting HTML printing into a seperate class 38306ae
@moredip moredip more WIP moving extracting HtmlPrinter b6c9c14
@moredip moredip more WIP on HtmlPrinter extraction - main flow done 4433bd8
@moredip moredip pretty much all HTML is now extracted into HtmlPrinter 2f005dc
@moredip moredip HtmlPrinter: define big blocks of html with constants rather than met…
…hods
a8ef955
@moredip moredip Cleaning up last bits of cruft from HtmlFormatter refactor b18a575
@moredip moredip Use 1.8.x hash syntax 7b387ae
@moredip moredip fix typo 67227f3
Commits on Aug 15, 2012
@dchelimsky dchelimsky dev: use debugger gem for ruby 1.9 d833934
Commits on Aug 17, 2012
@alexch alexch ignore .idea (RubyMine project files) f0ebce3
@alexch alexch Restore json formatter
This reverts commit ed9ec72.
7e076bc
@alexch alexch fix up tests for JsonFormatter d549bc8
@alexch alexch add --format json to the command-line option parser 0496c0a
@alexch alexch fix a few more tests on 1.8.7 and JRuby 72efe86
@alexch alexch curse you, randomly ordered hashes\! a0e4fa6
@dchelimsky dchelimsky Merge pull request #661 from alexch/json-formatter
JSON formatter
cb2e14a
Commits on Aug 18, 2012
@dchelimsky dchelimsky Changelog for #661 8752b9a
Commits on Aug 24, 2012
@myronmarston myronmarston Update build so that it runs specs together, then file-by-file.
We want to keep each spec passing on its own, so this is a good
way to ensure that. There were some missing requires, actually.

The test_all script is derived from a script from Gary Bernhardt:

https://github.com/garybernhardt/raptor/blob/master/script/test_all
d35b6b5
Commits on Aug 25, 2012
@myronmarston myronmarston Update script/test_all so that it runs specs w/o loading bundler.
As per rspec/rspec-mocks#174, we want all specs to pass when run in isolation w/o bundler being loaded, so this helps us ensure that remains true.

Also, running w/o bundler in this fashion is about 3x faster than using bundle exec.
c2dcdd4
@myronmarston myronmarston After running all specs, we only want to run cucumber.
...rather than running the specs again, and then cucumber.
4f101b3
Commits on Aug 31, 2012
@dchelimsky dchelimsky refactor spec for improved output f1ef071
@soulcutter soulcutter Documentation for RakeTask rspec_opts. Fixes #280 f920afc
Commits on Sep 01, 2012
@tomykaira tomykaira Named subject can be referred from an inside subject block
Example:

    describe "list" do
      subject(:list) { [1,2,3] }
      describe 'first' do
        subject(:first_element) { list.first }
        it { should eq(1) }
      end
    end

With the previous implementation, this fails with "stack level too deep".
This error is not obvious and irritating to me.

I believe this behaviour is more natural.
c83eaf9
@tomykaira tomykaira Use a simpler way to invoke a method by name b311627
@dchelimsky dchelimsky Merge pull request #670 from tomykaira/nest_named_subject
Named subject can be referred from an inside subject block in a nested group
6b286e6
@dchelimsky dchelimsky changelog for #670 4a061c7
Commits on Sep 03, 2012
@alindeman alindeman Merge pull request #671 from soulcutter/rspec_opts_docs
Documentation for RakeTask rspec_opts. Fixes #280
31516a0
@alindeman alindeman Also send test_all STDERR to STDOUT b7368ed
@dchelimsky dchelimsky refactor spec efa5c14
Commits on Sep 05, 2012
@soulcutter soulcutter Fixed #567 halt on toplevel before(:all) exceptions 36702f4
@myronmarston myronmarston Update changelog. c04b99a
Commits on Sep 08, 2012
@dchelimsky dchelimsky run should_clean gem (it "does v it "should) 400da5a
@myronmarston myronmarston Fix funny indentation. fcef568
@myronmarston myronmarston Use #stub_const rather than hand-rolled constant manipulation. 2ce7ee3
@myronmarston myronmarston Use some helper methods to manage ENV manipulation. e789ce2
@joliss joliss Make glob order alphabetical, not file-system dependent
Dir[] and FileList[] have undefined order, so sorting them is strictly
better than not. Sorting should not have a performance impact in any
realistic use case: Sorting 100k shuffled elements is
near-instantaneous, and sorting 1M elements takes ~3 seconds, so file
system access time will always dominate.

One particular reason why this is useful is that undefined ordering is a
major source of flickering test suite failures.
c76c1e6
@myronmarston myronmarston Add specs for the consistent ordering of the files to run.
These are for #660.
279a6d6
@myronmarston myronmarston Changlog entry for #660. 2bfe288
Commits on Sep 09, 2012
@dchelimsky dchelimsky Check output.tty? on each formatter's output instead of global setting.
This fixes a bug where color is config'd but a formatter is given a file.

- Fixes #675.
1852a7f
@dchelimsky dchelimsky minor refactoring for clarity 137201a
Commits on Sep 10, 2012
@myronmarston myronmarston Amend 279a6d6 based on @dchelimsky's code review comments. ced0638
@myronmarston myronmarston Remove obselete scripts we no longer need. ace84f8
@myronmarston myronmarston Use `stub_const` rather than defining an empty module.
The old way "leaked" in the sense that it globally added an empty
module that only a few tests need.
7c537b7
Commits on Sep 11, 2012
M. Scott Ford Outputs random seed before loading files
Ordering dependencies between files can result in a raised exception
when rspec is loading files. If random ordering is turned on, then the
exception will prevent the random seed from being displayed. This
always outputs the random seed before file are loaded, so that the
ordering that produced the exception can be repeated.
f6565c7
Commits on Sep 12, 2012
@moredip moredip refactor from keyword params to plain old vanilla params for HtmlPrinter
Did leave keyword params in for methods that took 5 or more params.
1732ed7
David Chelimsky update Gemfile-custom ddc2c37
David Chelimsky more custom Gemfile updates 29fb56e
@samphippen samphippen Break the rake task constructor up a bit
Signed-off-by: Sam Phippen <samphippen@googlemail.com>
5412602
@samphippen samphippen Remove explicit "self." in the rake task
Signed-off-by: Sam Phippen <samphippen@googlemail.com>
6b76ced
@samphippen samphippen Simplify instance variable creation
Before we were creating instance variables both before and after
yielding to the user. Now we set all defaults before we yield to the
user and then it's up to them to change any of the values.

Signed-off-by: Sam Phippen <samphippen@googlemail.com>
fffab90
Commits on Sep 13, 2012
@dchelimsky dchelimsky Merge pull request #677 from samphippen/refactor-rake-task
Refactor internals of the rake task constructor.
fb7f189
@dchelimsky dchelimsky changelog for #677 35eb45a
@samphippen samphippen Break the inline default spec command block into a method.
I think that it's cleaner to have this glob of functionality in it's
own method rather than starting a new block halfway through the
function.

Signed-off-by: Sam Phippen <samphippen@googlemail.com>
2538849
@samphippen samphippen Remove a duplicate "private" declaration in rake_task
Signed-off-by: Sam Phippen <samphippen@googlemail.com>
db23e27
@dchelimsky dchelimsky Merge pull request #678 from samphippen/refactor-default-spec-command
Break up RakeTask#spec_command method.
43b4eb2
@patmaddox patmaddox Merge pull request #679 from samphippen/remove-rake-task-duplicate-pr…
…ivate

Remove a duplicate "private" declaration from rake_task.rb
f0eb079
Commits on Sep 15, 2012
@moredip moredip remove last two usages of keyword params from HtmlPrinter 77e7ef4
@dchelimsky dchelimsky Merge pull request #659 from moredip/pr/html_formatter_cleanup
Clean up html formatter
20268ed
@dchelimsky dchelimsky changelog for #659 a1bf4fe
@dchelimsky dchelimsky reformat 410155e
@alindeman alindeman Quotes ruby command in case it contains spaces
* Closes #674
4d3b610
Commits on Sep 17, 2012
M. Scott Ford Ensures that error commands always throw an error dbee8b6
@alindeman alindeman Fixes regression introduced by earlier refactoring in 5412602
* args was being double wrapped in an Array after being splatted twice
2a85bc7
@myronmarston myronmarston Merge pull request #676 from mscottford/output-seed-before-loading-files
Outputs random seed before loading files
fb0f06e
@myronmarston myronmarston Changelog for #676.
[ci skip]
824119e
Commits on Sep 26, 2012
@samphippen samphippen Ensure before(:all) state is always propagated to after(:all)
...even if an error occurs in before(:all).

Fixes #558.
49370db
@markburns markburns slightly more useful exception message in case of finding a duplicate…
… shared_example_group
34b17ed
@markburns markburns change to warning rather than raising ArgumentError when duplicate bl…
…ock called
8b0cb5a
@myronmarston myronmarston Fixup the improved duplicate shared example group warning.
- No need to stub the private formatted_location method.
- More detailed message.
- Changelog entry.
d2f831d
@myronmarston myronmarston Fix build on 1.8.7.
Proc#source_location is only available on 1.9, apparently.
a5b7209
@myronmarston myronmarston Refactor shared example code so we don't leak methods onto Module/main.
We should limit the number of methods we add onto objects we don't own.
21c415f
@samphippen samphippen Command line arguments consistently use hyphens
`--default_path` has been replaced with `--default-path` and `--line_number`
has been replaced with `--line-number`.

The old, underscore based args still work. The new hyphen based args now
show in the help text in `--help`.

Closes #497
Closes #691
ef74478
@alindeman alindeman Changelog for #497, #691 [ci skip] 92038d3
Commits on Sep 27, 2012
@alindeman alindeman "--init" no longer generates an incorrect warning
* Closes #693
* Fixes #686
336f201
@samphippen samphippen Deprecate SharedExampleGroup#share_as
Signed-off-by: Sam Phippen <samphippen@googlemail.com>
aa294e7
@samphippen samphippen Add a spec for the share_as deprecation
Signed-off-by: Sam Phippen <samphippen@googlemail.com>
faf6d4f
Commits on Sep 28, 2012
@jcarres-mdsol jcarres-mdsol A more useful error message is shown when an invalid command line opt…
…ion is used

* Closes #688
ccedfcb
@amatsuda amatsuda s/map/each/ 64fbdca
@dchelimsky dchelimsky Merge pull request #696 from amatsuda/load_each_file
avoid creating unused Array instance
5012aea
Commits on Oct 01, 2012
@myronmarston myronmarston Merge pull request #694 from samphippen/deprecate-share-as
Deprecate SharedExampleGroup#share_as
701f901
@myronmarston myronmarston Silence share_as deprecation warning in our specs. 5882cff
@myronmarston myronmarston Fix warning: already initialized constant NestedFoo2 cfb6029
@myronmarston myronmarston Update changelog. 94fd7a8
@myronmarston myronmarston Unify error message for invalid option.
No need to `puts` part of it and `abort` with the rest.
45f23ab
Commits on Oct 03, 2012
@myronmarston myronmarston Delegate #configuration through to rspec-mocks.
This allows our block config API to be used.

This depends on rspec/rspec-mocks#188 and should be merged after that.
2aca56e