Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also compare across forks.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also compare across forks.
base fork: rspec/rspec-core
base: v2.5.1
...
head fork: rspec/rspec-core
compare: v2.6.0
Commits on Feb 06, 2011
@dchelimsky dchelimsky date typo 79f9af6
Commits on Feb 07, 2011
@dchelimsky dchelimsky docs/nav 5a2b75b
Commits on Feb 10, 2011
@joliss joliss better error message if no block given for hook
- Closes #309.
57007dc
@dchelimsky dchelimsky remove quotes (less noise) 8bfc602
Commits on Feb 14, 2011
@dchelimsky dchelimsky doc tweaks d832c61
@dnurzynski dnurzynski Fix exit_status after Exception raised in before :all hook
- Closes #301.
- Closes #302.
79273a7
Commits on Feb 15, 2011
@dchelimsky dchelimsky clear ivars declared before(:all) after a group is run ff18091
@dchelimsky dchelimsky docs dd8b9e4
Commits on Feb 16, 2011
@dchelimsky dchelimsky docs 011b1ce
Commits on Feb 21, 2011
Hans Hasselberg don't stumble over an exception without a message.
- Closes #308.
6a12e37
@dchelimsky dchelimsky changelog 1a09d44
Geoffrey Byers Removed non-ascii characters from comments
- Closes #315.
4f0a131
@dchelimsky dchelimsky changelog 9557f98
@dnurzynski dnurzynski Add config.for_groups_matching
- extend groups matching specific metadata with:
  - method definitions
  - subject declarations
  - let/let! declarations
  - etc (anything you can do in a group)

- Closes #300.
f0dc666
@dchelimsky dchelimsky change log dc24065
@dchelimsky dchelimsky Modify config.for_groups_matching to add methods using def as instance
methods instead of class methods. This exposes them to the examples
rather than the example groups.

Also updated the specs and cukes to make them more generic (less
rails specific).
08889b4
@dchelimsky dchelimsky Refactor peding declared in an example to raise and capture an exception
instead of throwing/catching a symbol. This fixes a bug in which
post-example processing in an around hook would be skipped if the
example was declared pending from within the example.

- Closes #322.
4ac234e
Commits on Feb 22, 2011
@Peeja Peeja `its([:key]) {}` works for any subject with #[].
- Closes #323.
- Closes #296.
fda4a12
@dchelimsky dchelimsky change log 696ef3e
@dchelimsky dchelimsky Require file from spec that is not autoloaded (so the spec file can be
run individually).

- Closes #318.
d0218cd
@myronmarston myronmarston Fixed backtrace so it doesn't include lines from before the autorun a…
…t_exit hook.

- Closes #101.
e4b8f5c
@myronmarston myronmarston Add cuke for user-defined metadata. ebc4bff
Commits on Feb 23, 2011
@myronmarston myronmarston Add new treat_symbols_as_metadata_keys_with_true_values option.
Closes #304.
41d11e2
Commits on Feb 25, 2011
@myronmarston myronmarston Removed unused matcher. d6e84c3
Commits on Feb 26, 2011
@myronmarston myronmarston Move custom matchers into spec/support/matchers.rb. da49bee
@myronmarston myronmarston Downgrade flexmock to last version that is compatible with 1.8.6 so o…
…ur cukes pass on 1.8.6.
d37bc38
@myronmarston myronmarston Fix specs on 1.9.1p378.
I have no idea why, but on 1.9.1p378, I was getting errors like "undefined method `to_int' for class `#<Class:0x00000101ae3a18>::String'".  This fixes it.  Apparently `class String` was creating a new class rather than re-opening the existing String class.  `String.class_eval do` ensures we run the alias/undef code in the context of the existing string class.

Yes, this does make no sense whatsoever.  Must be a weird 1.9.1 bug.
91d1b0a
@myronmarston myronmarston Regenerated html fixtures for 1.9.1.
The specs that use them were failing.
bc046aa
@myronmarston myronmarston Remove coupling to rspec-expectations.
Generated example descriptions only work when using rspec-expectations and the code should not use RSpec::Matchers when configured to use :stdlib.
aa0d179
Commits on Feb 27, 2011
@dchelimsky dchelimsky gemspec tweaks dbe818b
Commits on Mar 02, 2011
@dchelimsky dchelimsky changelog b801160
Commits on Mar 06, 2011
@myronmarston myronmarston Remove unused local variable. 0394f4a
@dchelimsky dchelimsky no need to include matchers in spec helper 56616ec
@dchelimsky dchelimsky point Gemfile to git instead of published gems cfa9837
Commits on Mar 07, 2011
@myronmarston myronmarston Fix how RSpec::Matchers is included in RSpec::Core::Example group to …
…prevent SystemStackError on 1.9.
622a4b7
@myronmarston myronmarston Fix how we spec expect_with so its not so fragile. ab861a7
@myronmarston myronmarston Print a warning when users configure RSpec after defining an example …
…group.
fc70cee
@myronmarston myronmarston Update changelog. 62c9f03
@justinko justinko Use #double as #mock and #stub will be deprecated in the future e3eb542
Commits on Mar 08, 2011
@myronmarston myronmarston Rewrite hook filtering cukes so they are more clear.
Making assertions on the output of `puts` in the hooks interleaved with the documentation formatter output is a poor way to demonstrate this feature.
d90f1c1
@dchelimsky dchelimsky Change class level instance var to class's class var so the block is
only executed once per suite.
2b2ef40
@myronmarston myronmarston Add additional examples. 24ec6c8
@myronmarston myronmarston Add cuke documenting how to include/extend a module in your example g…
…roups.
51cb016
Commits on Mar 09, 2011
@dchelimsky dchelimsky move require to right file 734aa81
@dchelimsky dchelimsky Change --debug option to --debugger
- --debug was not working for reasons unknown.
- Closes #282.
9e8c7f4
@dchelimsky dchelimsky require 'stringio'
- Closes #328.
ba04227
@myronmarston myronmarston Abstract out the metadata symbol deprecation warning.
The current message won't make sense for config options that use symbol metadata so this provides an easy way to define another module with a different warning message for use by configuration.
b654495
@myronmarston myronmarston Allow symbols to be treated as metadata filters for hooks. 5c5aa52
@myronmarston myronmarston Allow symbols to be treated as metadata for the inclusion filter. 3de3b32
@myronmarston myronmarston Allow symbols to be treated as metadata for the exclusion filter. 5e0ac37
@myronmarston myronmarston Allow symbols to be treated as metadata for config.include/config.ext…
…end.
c38394d
@myronmarston myronmarston Add new feature to nav. 75dd47f
@myronmarston myronmarston Add cuke documenting `config.alias_example_to`. 750fe14
@myronmarston myronmarston Allow symbols to be treated as metadata for `config.alias_example_to`. 253b272
@myronmarston myronmarston Clarify warning. 6fe8316
@myronmarston myronmarston Reword cuke narative. 1dea593
@myronmarston myronmarston Allow symbols to be treated as metadata for `config.for_groups_matchi…
…ng`.
9cee5e2
Commits on Mar 10, 2011
@myronmarston myronmarston Force users to explicitly specify hook scope when using symbols as me…
…tadata for hooks.
d8cb628
Commits on Mar 13, 2011
@dchelimsky dchelimsky docs 0dea1af
@ilkka ilkka Pass exit status of DRb run to invoking process
This change causes rspec to exit with a non-zero exit status when specs
fail, even when running with DRb. Failover to local run is done by not
catching DRb::DRbConnError exceptions in RSpec::Core::DRbCommandLine,
instead letting them come up to Runner.run.
00d842b
@ilkka ilkka Fix specs to reflect new DRb behaviour expectations
DRbCommandLine.run no longer outputs a connection error message, instead
it lets raised DRbConnError exceptions pass through. Also it returns
false for the dummy spec because of the raise() therein.
38d43c3
@justinko justinko More detailed spec for running your specs with DRb. e322223
Commits on Mar 14, 2011
@myronmarston myronmarston Fix indentation. d313384
Commits on Mar 15, 2011
@justinko justinko changelog 548dda4
@alindeman alindeman Since fda4a12, ostruct is no longer used. Remove the require. Closes #… 1758f81
Commits on Mar 22, 2011
@dchelimsky dchelimsky Don't call example_group_[started|finished] unless the group or any of
its children have at least one example to run.

- Closes #317.
40758a1
@dchelimsky dchelimsky fix cuke i broke last commit :( d0e5fa2
Commits on Mar 23, 2011
@kaiwren kaiwren Fix `:ruby => "!jruby"` metadata logic. Fixes #338 Fixes #339 3260cb5
@dchelimsky dchelimsky remove comment in feature a1064cf
Commits on Mar 24, 2011
@kaiwren kaiwren Get build to pass on jruby.
- Closes #341.
bd3aac8
@dchelimsky dchelimsky Don't run rr spec in jruby (failure coming from rr itself).
- Closes #3.
36b0a1f
@dchelimsky dchelimsky same as last time, only this time it actually works 8fd03d2
Artur Małecki Fix bug where mixing nested groups and outer-level examples gave
unpredictable :line_number behavior

- Closes #337.
- Closes #340.
a368a1a
@dchelimsky dchelimsky changelog a9ed36a
@dchelimsky dchelimsky add cuke for accessing example from within the example b007362
@dchelimsky dchelimsky rename feature and tweak nav 4ee9369
Commits on Mar 25, 2011
@dchelimsky dchelimsky upgrade cucumber and aruba 8f74614
Commits on Mar 27, 2011
@dchelimsky dchelimsky Change config.for_groups_matching to shared_context
- not in the context of config
- aligns with shared_examples_for API
- also add `include_context` method to example group
  - so shared context can be included ...
    - using include_context
    - by matching metadata
d57065d
Commits on Mar 28, 2011
@myronmarston myronmarston Add travis config file. 95458f1
@myronmarston myronmarston Use git protocol rather than https for bundled rspec gems.
The https url failed when travis-ci tried to build rspec-core.  This might fix it.

Fetching https://github.com/rspec/rspec-expectations.git
error:  while accessing https://github.com/rspec/rspec-expectations.git/info/refs

fatal: HTTP request failed
An error has occurred in git when running `git clone "https://github.com/rspec/rspec-expectations.git" "/home/travis/.rvm/gems/ruby-1.8.7-p330/cache/bundler/git/rspec-expectations-1c518ec8c1880aa81941a7a8c7fa04b29ec74c91" --bare --no-hardlinks`. Cannot complete bundling.
ddaf0af
@myronmarston myronmarston Use RUBY_PLATFORM rather than RUBY_ENGINE to detect jruby.
RUBY_ENGINE is not defined when using MRI.  RUBY_PLATFORM is.
96ca109
@kaiwren kaiwren All tests now green on jruby. 6 failing cukes to go before we're all …
…green.

- Closes #343.
37d97f9
Commits on Mar 29, 2011
@dchelimsky dchelimsky Regexp.escape the argument to --example.
- Closes #299.
- Thanks to Elliot Winkler for the suggestion.
d0ee3df
@myronmarston myronmarston Looks like more rubies are installed on travis, so let's build on som…
…e more.
096e586
@dchelimsky dchelimsky clean const_missing backtraces dff001d
@dchelimsky dchelimsky cleaner backtrace cleansing 0ff66c4
@dchelimsky dchelimsky less invasive cleansing of const_missing backtrace 1ffd47d
Commits on Apr 01, 2011
@justinko justinko Define a `framework_name` class method on all mocking adapter modules…
… so we can get `RSpec.configuration.mock_framework.framework_name`
622505d
@justinko justinko Cukes for RSpec.configuration.mock_framework.framework_name 398c74c
Commits on Apr 03, 2011
@myronmarston myronmarston Only build the rubies travis has available. 875cb05
Commits on Apr 07, 2011
@dchelimsky dchelimsky remove deprecated default_executable from gemspec 7070a15
@dchelimsky dchelimsky Address memory leaks.
- set each example's instance of the group to nil after processing.

This dereferences the example group instance which contains all of the
example's state, thereby releasing each example for garbage collection
after processing.

Note that this does not dereference state initialized in before(:all),
but those instance variables are cleared out in a separate process.

2. nullify ivars after each example

- Closes #321.
b51be2c
Commits on Apr 08, 2011
@dchelimsky dchelimsky add spec output a7b7afe
Commits on Apr 09, 2011
@dchelimsky dchelimsky run ci against more rubies a4ad3ff
Commits on Apr 10, 2011
@dchelimsky dchelimsky update Gemfile to address build issues with 1.9.1 4656bd9
@dchelimsky dchelimsky add travis build status 851d199
Commits on Apr 13, 2011
@dchelimsky dchelimsky Correctly pass/fail pending block with message expectations
- Closes #257
644e372
@dchelimsky dchelimsky changelog 7169b56
Commits on Apr 15, 2011
@dchelimsky dchelimsky add parens to silence warning 44d305c
@rosenfeld rosenfeld Refactoring of ConfigurationOptions#parse_options
- Closes #346.
9e91291
Commits on Apr 16, 2011
@dchelimsky dchelimsky use the names shared_examples and shared_context in the features 029e697
@patmaddox patmaddox Report the exclusion filter eae6b43
@patmaddox patmaddox Report exclusion filters (closes #347) 3623784
@patmaddox patmaddox whoops forgot to commit updated feature 03a13bc
@patmaddox patmaddox words 87a0f38
Commits on Apr 17, 2011
@justinko justinko Give credit. f7ff6c0
@dchelimsky dchelimsky Add shared_examples/include_examples pair.
Now we have:

  shared_examples / include_examples
  shared_context  / include_context

These actually do the same thing, but the names make different use cases
more intention revealing.
5e035ea
@dchelimsky dchelimsky doc tweaks 98f811d
@dchelimsky dchelimsky --tag key:value supports symbols and strings 57fe719
Commits on Apr 18, 2011
@dchelimsky dchelimsky prep for 2.6.0.rc1 f10e8bb
@dchelimsky dchelimsky comment aruba/cukes in Gemfile 059aa96
@dchelimsky dchelimsky update changelog bf3ca8c
@dchelimsky dchelimsky bump to 2.6.0.rc2 422e334
@dchelimsky dchelimsky update the changelog 0b63cc6
Commits on Apr 19, 2011
@dchelimsky dchelimsky reinstate cucumber and aruba 9490893
@dchelimsky dchelimsky update docs edb06bb
Commits on Apr 20, 2011
@dchelimsky dchelimsky doc updates fd5ef93
Commits on Apr 21, 2011
@myronmarston myronmarston Improve the filter announcement messaging.
- Don't include the default filters.
- Remove the noisy hex number from procs.

Closes #350.
aecda56
Commits on Apr 23, 2011
@dchelimsky dchelimsky even shorter description of Proc location 52eca40
@dchelimsky dchelimsky friendly description for both inclusion and exclusion filters c66049a
@dchelimsky dchelimsky remove commented example 0ac4e6e
Commits on Apr 28, 2011
@dchelimsky dchelimsky remove redundant statement 86a0813
@dchelimsky dchelimsky inclusion/exclusion filter refactoring ee66acb
@dchelimsky dchelimsky fix some failing (brittle) cukes 4909f5f
Commits on Apr 30, 2011
@dchelimsky dchelimsky prep for 2.6.0.rc3 c9851eb
Commits on May 01, 2011
@dchelimsky dchelimsky bump to 2.6.0.rc4 83db5d5
Commits on May 05, 2011
@dchelimsky dchelimsky restore --pattern/-P command line option (from rspec-1) 0c7a676
Andreas Tolf Tolfsen Suppport both true and false on config.full_backtrace=
- Closes #355.
2c71a88
Commits on May 06, 2011
@dchelimsky dchelimsky no need for the rubygems version in the gemspec 4c0f32e
@dchelimsky dchelimsky prep for 2.6.0.rc5 3bbeb31
@dchelimsky dchelimsky prep for rc6 a37ff24
Commits on May 07, 2011
@dchelimsky dchelimsky CommandLine.run returns 0/1 instead of true/false
- Closes #366
7410e6f
Commits on May 08, 2011
@dchelimsky dchelimsky Document that around hooks don't share state with examples
- Closes #364.
e979ab5
@marekj marekj Create path to formatter output file if it doesn't exist.
- Closes #361.
890d6c6
@dchelimsky dchelimsky make utility method private 169c725
@dchelimsky dchelimsky don't announce 'Running filtered' when there are no filters 9f62063
@dchelimsky dchelimsky don't call autorun when registering an example group
- the rspec command already does this
- if you want to use the ruby command, require 'rspec/autorun'
bfd0765
@dchelimsky dchelimsky Dev: just require 'rspec/core' 67ab2ac
@dchelimsky dchelimsky Set $stderr and $stdout as defaults for RSpec::Core::Runner.run
- See #367.
73b8714
@dchelimsky dchelimsky Dev: remove obsolete file 7658d8b
@dchelimsky dchelimsky add comment to remove spork monkey patch 1466f60
@dchelimsky dchelimsky fix cuke broken by bfd0765 f994d21
@dchelimsky dchelimsky clear the world after each run
- Closes #367.
71cb7af
@dchelimsky dchelimsky update docs e58c0a3
@dchelimsky dchelimsky reset only which needs resetting 9124a62
Commits on May 10, 2011
@dchelimsky dchelimsky refactoring: clarify intent of applying filters 9d61d59
Commits on May 11, 2011
@dchelimsky dchelimsky easier on the eyes 17782b0
Commits on May 12, 2011
@dchelimsky dchelimsky Revert "refactoring: clarify intent of applying filters"
- it was more expressive, but caused errors in rspec-rails - will
  revisit later

This reverts commit 9d61d59.
58926bb
@justinko justinko typo b0161c7
@justinko justinko typo a530faf
@dchelimsky dchelimsky prep for 2.6.0 6766e18