Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Autotest fails if filename contains spaces #132

Closed
zargony opened this Issue · 3 comments

2 participants

Andreas Neuhaus David Chelimsky
Andreas Neuhaus

If an expanded filename contains spaces (the project directory does, in my case), autotest fails to run specs since the filenames are not quoted in make_text_cmd.

Patch: http://github.com/zargony/rspec-core/commit/e9dee5128b7bb071292d6e093f456400c9eb17e2

(I chose to simply put single quotes around each filename, like the original autotest code does. Actually it might be even better to properly shell escape filenames)

David Chelimsky
Owner

Please add a spec that fails without this change and I'll be happy to merge it.

Andreas Neuhaus

Sorry, I didn't realize that the autotest stuff is covered by specs. Here's a spec that ensures that paths are quoted in commands.

http://github.com/zargony/rspec-core/commit/03dae7c5594ecae155ce4174893dd3900a08100b

David Chelimsky
Owner

Closed by 5aa6ae3

Tim Harper timcharper referenced this issue from a commit in timcharper/rspec-core
Andreas Neuhaus zargony Fixed autotest for paths with spaces
- Closes #132.
5aa6ae3
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.