Autotest fails if filename contains spaces #132

Closed
zargony opened this Issue Sep 2, 2010 · 3 comments

Projects

None yet

2 participants

@zargony

If an expanded filename contains spaces (the project directory does, in my case), autotest fails to run specs since the filenames are not quoted in make_text_cmd.

Patch: http://github.com/zargony/rspec-core/commit/e9dee5128b7bb071292d6e093f456400c9eb17e2

(I chose to simply put single quotes around each filename, like the original autotest code does. Actually it might be even better to properly shell escape filenames)

@dchelimsky
RSpec member

Please add a spec that fails without this change and I'll be happy to merge it.

@zargony

Sorry, I didn't realize that the autotest stuff is covered by specs. Here's a spec that ensures that paths are quoted in commands.

http://github.com/zargony/rspec-core/commit/03dae7c5594ecae155ce4174893dd3900a08100b

@dchelimsky
RSpec member

Closed by 5aa6ae3

@timcharper timcharper pushed a commit to timcharper/rspec-core that referenced this issue Aug 19, 2011
@zargony zargony Fixed autotest for paths with spaces
- Closes #132.
5aa6ae3
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment