Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Mixing files and ids doesn't work correctly #1920
This is more complex than I first realized and not limited to mixing ids and files -- it also applies to mixing locations (e.g.
To describe the problem in more detail:
Thoughts from @rspec/rspec ?
rather than me guessing, could you provide some expected inputs/outputs as to what is current vs desired behaviour? i.e.
Sorry I'm not as familiar with the behaviour here.
Line number and id filters are considered to be "scoped" filters in that they are attached to a specific file and don't apply to examples in other files. Thus, w/o any other filters in affect:
When you throw focus filtering into the mix (e.g. under the typical configuration):
Does that help, @xaviershay?
So I think we should fix this, line numbers / ids etc aren't meant to have the same semantics as metadata filtering so the behaviour is incorrect in my opinion
I guess this is semantically the same concept, I'm on board as long as we make it clear why we're ignoring the filter.
I think we should only have one way of doing things, so I think we should deprecate
referenced this issue
Apr 20, 2015
just ran into this issue. my workaround was to remove
I've been thinking about this some more, and I've realized that while the solution I proposed above --
What I've realized is that a global option to ignore is generally problematic. IIRC,
So now I'm thinking we should introduce a new config option that is a sibling of
Besides fixing this issue and avoiding an option that globally changes how filters work in undesirable ways, it also reduces the number of lines of config needed to get focus filtering to just one.
Thoughts? And if we go this direction, what should we call the new config option?