Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Using both --drb and --format on the command line raises error when Spork is not running #267

Closed
iconara opened this Issue Jan 6, 2011 · 3 comments

Comments

Projects
None yet
2 participants

iconara commented Jan 6, 2011

I just updated to RSpec 2.4, running

rspec --drb --format d spec

raises an error, running either without --drb, or without --format d works fine, but running with both does not. This only happens when Spork is not running. RSpec 2.2 did not have this issue.

This is the error in detail:

% rspec --drb --format d --color spec                                                                              master 13:14 reventon
No DRb server is running. Running in local process instead ...
/Users/theo/.rvm/gems/ruby-1.9.2-p0@xyz/gems/rspec-core-2.4.0/lib/rspec/core/configuration.rb:266:in `add_formatter': wrong number of arguments (0 for 1) (ArgumentError)
    from /Users/theo/.rvm/gems/ruby-1.9.2-p0@xyz/gems/rspec-core-2.4.0/lib/rspec/core/configuration_options.rb:27:in `block in configure'
    from /Users/theo/.rvm/gems/ruby-1.9.2-p0@xyz/gems/rspec-core-2.4.0/lib/rspec/core/configuration_options.rb:26:in `each'
    from /Users/theo/.rvm/gems/ruby-1.9.2-p0@xyz/gems/rspec-core-2.4.0/lib/rspec/core/configuration_options.rb:26:in `configure'
    from /Users/theo/.rvm/gems/ruby-1.9.2-p0@xyz/gems/rspec-core-2.4.0/lib/rspec/core/command_line.rb:17:in `run'
    from /Users/theo/.rvm/gems/ruby-1.9.2-p0@xyz/gems/rspec-core-2.4.0/lib/rspec/core/runner.rb:55:in `run_in_process'
    from /Users/theo/.rvm/gems/ruby-1.9.2-p0@xyz/gems/rspec-core-2.4.0/lib/rspec/core/runner.rb:44:in `run'
    from /Users/theo/.rvm/gems/ruby-1.9.2-p0@xyz/gems/rspec-core-2.4.0/lib/rspec/core/runner.rb:10:in `block in autorun'

I have Autotest 4.4.6 and Spork 0.8.4 installed too.

spec_helper.rb doesn't do much more than the Spork generated default + a few require's of stdlib things.

iconara commented Jan 6, 2011

I downgraded to 2.3 (I was running 2.2 before) and the command works fine there, so this is something introduced in 2.4.

Owner

dchelimsky commented Jan 6, 2011

I added support for multiple formatters to 2.4, so it's likely related to that. I'll try to get a 2.4.1 release out this weekend with this fixed.

Owner

dchelimsky commented Jan 7, 2011

Don't clobber formatter options when generating drb_argv

  • fixes bug in which --drb + formatters would raise an error when not
    running in drb
  • Closed by 3e17efe

@timcharper timcharper pushed a commit to timcharper/rspec-core that referenced this issue Aug 19, 2011

@dchelimsky dchelimsky Don't clobber formatter options when generating drb_argv
- fixes bug in which --drb + formatters would raise an error when not
  running in drb
- Closes #267
3e17efe

This issue was closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment