Skip to content

Don't show default filters #350

dchelimsky opened this Issue Apr 19, 2011 · 4 comments

2 participants

RSpec member

With rspec-core-2.6.0.rc2:

$ be rspec spec
No examples were matched by {:focus=>true}, running all
Run filtered excluding {:ruby=>#<Proc:0x00000001017b5578@/Users/dchelimsky/projects/ruby/rspec2/repos/rspec-core/spec/spec_helper.rb:78>, :unless=>#<Proc:0x000000010189e480@/Users/dchelimsky/projects/ruby/rspec2/repos/rspec-core/lib/rspec/core/configuration.rb:53>, :if=>\#<Proc:0x000000010189e638@/Users/dchelimsky/projects/ruby/rspec2/repos/rspec-core/lib/rspec/core/configuration.rb:52>}

Too much noise. Let's not show the :if and :unless defaults.

RSpec member

Additionally - procs should identify their location but don't need object IDs.

RSpec member

Sounds good--I'll try to take care of this later in the week.

@myronmarston myronmarston was assigned Apr 19, 2011
@myronmarston myronmarston reopened this Apr 21, 2011
RSpec member

This is in a branch for now since we're trying to get 2.6 out. Let me know if you want this to be merged into master for the 2.6 final release; otherwise I'll wait to merge until after that's out the door.

RSpec member

I commented on a method name. Once that's resolved (which it might be already :) ) go ahead and merge it. I won't do the final release until this weekend, in all likelihood, and I'd like this to be in it.

@myronmarston myronmarston added a commit that closed this issue Apr 21, 2011
@myronmarston myronmarston Improve the filter announcement messaging.
- Don't include the default filters.
- Remove the noisy hex number from procs.

Closes #350.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.