Alias example group #1236
Closed
Alias example group #1236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
December 22, 2013 19:49
|
Hey @michihuber -- the build is erroring because of some recent travis/bundler/rubygems changes that broke some things. Can you rebase against master? That should pull in .travis.yml changes that will fix the the install errors. |
| module Core | ||
| # DSL defines methods to group examples, most notably `describe`, | ||
| # and exposes them as class methods of {RSpec}. | ||
| # They can also be exposed globally (on main and Module) through |
There was a problem hiding this comment.
I think this line should be:
# They can be exposed globally (on `main` and instances of `Module`) through
|
@michihuber -- I'd love to get this in 3.0.0.beta2, which we'll be releasing soon. Are you able to get to get back to this in the next couple days? If not, that's fine; I'll plan to take it across the finish line so we can merge it. I just wanted to check first to make sure we don't step on each other's toes. |
|
I'm going to take a stab at getting this across the finish line. Thanks for getting this started, @michihuber! |
Merged
|
Closing in favor of #1255. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
allows adding custom aliases for example_group through the configuration
this is very much work in progress but I'll be offline for a bit, so maybe somebody can take a first look in the meantime
/cc @JonRowe @myronmarston