A few improvements to the mocks/expectations part of the build. #1256

Merged
merged 1 commit into from Jan 23, 2014

Conversation

Projects
None yet
1 participant
Owner

myronmarston commented Jan 23, 2014

  • Our bundle install was installing core's bundle, even for mocks
    or expectations, because travis has exported the BUNDLE_GEMFILE
    env var. We need to unset it so that the correct bundle is installed.
  • Clone the repos at a lower depth for faster cloning.
  • Use bin/rspec just like our normal builds do. Before this wouldn't
    work because of the BUNDLE_GEMFILE issue.
  • No need to delete the dir after the build.

/cc @samphippen

A few improvements to the mocks/expectations part of the build.
- Our `bundle install` was installing core's bundle, even for mocks
  or expectations, because travis has exported the BUNDLE_GEMFILE
  env var. We need to unset it so that the correct bundle is installed.
- Clone the repos at a lower depth for faster cloning.
- Use `bin/rspec` just like our normal builds do. Before this wouldn't
  work because of the BUNDLE_GEMFILE issue.
- No need to delete the dir after the build.
Owner

myronmarston commented Jan 23, 2014

Merging this without a review since it fixes the build which has been broken since a recent rspec-expectations merge.

myronmarston added a commit that referenced this pull request Jan 23, 2014

Merge pull request #1256 from rspec/fix-travis-build
A few improvements to the mocks/expectations part of the build.

@myronmarston myronmarston merged commit 66cc886 into master Jan 23, 2014

1 check passed

default The Travis CI build passed
Details

@myronmarston myronmarston deleted the fix-travis-build branch Jan 23, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment