Skip to content

Fix broken 2 99 build #1273

Closed
wants to merge 205 commits into from

9 participants

@myronmarston
RSpec member

This is an alternate fix to #1270. It fixes the build and prevents other mock scope warnings.

I think I like it a bit better than the fix in #1270 but I'm curious on your thoughts, @xaviershay.

JonRowe and others added some commits Jun 2, 2013
@JonRowe JonRowe we need to be able to overide call_site for it to be useful 395db96
@myronmarston myronmarston Fix brittle tests.
`#debug?` depends on whether or not the debugger is loaded. The tests for
it were brittle and could start to fail if you were running the specs with
the debugger loaded.
21a5d35
@alindeman alindeman Demonstrates problem where a module can affect how `LetDefinition`s a…
…re put in the ancestor chain
dd24bb9
@myronmarston myronmarston Rewrite SharedContext to use a simple record/playback mechanism. 4ee2f2b
@myronmarston myronmarston Move definition of implicit subject.
This is in prep for changing when the LetDefinitions module is included.
The use of `subject` from the `included` hook was causing problems when
I was trying to do that.
583759a
@myronmarston myronmarston Delay inclusion of `LetDefinitions` module.
It needs to be included last so that its definitions can take precedence
in case of a name collision.
3dd88a5
@myronmarston myronmarston Get the current list of shared context methods from the modules.
This is the current list of what it supports:

describe
context
hooks
before
append_before
prepend_before
after
prepend_after
append_after
around
run_hook
around_each_hooks_for
let
let!
subject
subject!
its
c635c20
@alindeman alindeman Small refactor to add intention revealing message 3e9fc96
@myronmarston myronmarston Changelog entry. 54991f9
@alindeman alindeman Fixes 1.8.7: apparently you cannot do multiple splats there 0247d2c
@alindeman alindeman Skips one-by-one spec runs for JRuby d2bb21f
@JonRowe JonRowe deprecation message for 1.8.6 and 1.9.1 3dea920
@JonRowe JonRowe 1.8.6 fix for reporter notifications 58deb8b
@JonRowe JonRowe update message to make more sense 74d638b
@JonRowe JonRowe Merge pull request #946 from rspec/deprecate_186_191
Deprecate 1.8.6 1.9.1 in 2.99
3b6b83c
@dchelimsky dchelimsky yield example to it, hooks, let, and subject da4817d
@dchelimsky dchelimsky update cukes to use block arg instead of example method to access exa…
…mple
e251dec
@JonRowe JonRowe Run tests using the client mode JVM (or as close as we can get to it) 92e7652
@JonRowe JonRowe trim ws for consistency 2f945af
@JonRowe JonRowe lock to 2-99 c8aebee
@JonRowe JonRowe work around different lambda inspect output on 2-99 with JRuby due to…
… mocks
be3cc50
@JonRowe JonRowe Define `fit` for example groups as a shortcut to define examples with…
… `:focus` => true
3922d57
@JonRowe JonRowe Merge pull request #959 from rspec/fit_focus_alias_299
Define `fit` for example groups as a shortcut to define examples with `focus` => true based off 2-99
aa1f7d5
@myronmarston myronmarston This 3.0.0 change isn't in 2.99.
[ci skip]
becdc86
@myronmarston myronmarston The changelog is for user-facing changes.
Internal refactorings don't need a changelog entry and add noise.

[ci skip]
9be9d17
@myronmarston myronmarston This change is in master but not 2.14.
[ci skip]
5dce785
@alindeman alindeman Nukes deprecation warning 69d4a96
@myronmarston myronmarston Update changelog to reflect 2.14.0 release.
[ci skip]
d364851
@myronmarston myronmarston Bump version to reflect that this branch is 2.99.0.pre. 26dba3f
@myronmarston myronmarston Add changelog entry for #666, 917b3a9
@alindeman alindeman Run features without rubinius code compilation
* This addresses sporadic failures
d2ce86b
@alindeman alindeman Disables certain scenarios on Rubinius
* I cannot get Rubinius to raise a warning for some reason, even outside
  specs
84efd68
@alindeman alindeman The backtrace appears to be shifted by 1 in Rubinius 5f561a9
@alindeman alindeman rbx build is green; let us try to keep it that way c4eb1fa
@alindeman alindeman Finds the backtrace line in a more robust way 54910d5
@alindeman alindeman Revert "rbx build is green; let us try to keep it that way"
This reverts commit c4eb1fa.
c3c909b
@myronmarston myronmarston Merge pull request #967 from rspec/quick_fix_for_deprecation_formatte…
…r_on_jruby

Properly base #966 off 2-14-maintenance
Conflicts:
	Changelog.md
c3f78ce
@myronmarston myronmarston Add 2.14.1 release notes.
[ci skip]
7eba6d2
@myronmarston myronmarston Update changelog with 2.14.2 release notes.
[ci skip]
1b18a47
@JonRowe JonRowe Merge pull request #970 from rspec/restore_simpler_deprecation_format…
…ter_fix

Restore simpler deprecation formatter fix
358c46d
@JonRowe JonRowe deprecate autotest support 2a32c1f
@JonRowe JonRowe reword deprecation message 9ed8c1e
@myronmarston myronmarston Merge pull request #978 from rspec/deprecate_autotest_support
Deprecate autotest support in 2.99
d9eb203
@JonRowe JonRowe changelog for deprecated autotest support 2ee5fdb
@JonRowe JonRowe Fixup Rakefile deprecations
If RSpec is already loaded (it's common to do:
```
require 'rspec' # or 'rspec/core'
require 'rspec/core/rake_task'
```
in a `Rakefile`), we can safely use the built in deprecation support
however otherwise it's become to complicated to load the deprecation
file alone so we drop back to a simplier warn.
3ce7c05
@myronmarston myronmarston Add helper methods to assist with spec'ing deprecations.
The most consistently tricky part to get right is the call site,
so that's what this helper method helps with.
969768c
@myronmarston myronmarston Deprecate RSpec's debugger support. 429291c
@myronmarston myronmarston Merge pull request #985 from rspec/fixup_rake_deprecate_299
Fixup Rakefile deprecations for 299
72ae382
@myronmarston myronmarston Add release notes for 2.14.3 release. c3c9c04
@myronmarston myronmarston Merge pull request #986 from rspec/deprecate_debugger
Deprecate debugger
c0cc8ef
@JonRowe JonRowe deprecate rake task rcov options aa89f68
@JonRowe JonRowe deprecate rcov readers too eee9288
@myronmarston myronmarston Fix the call site to be the stack frame before one of rspec's. 8ce0193
@myronmarston myronmarston Use ivars rather than the deprecated methods.
Otherwise, users get deprecation warnings due to RSpec's
usage of the deprecated methods.
cace322
@myronmarston myronmarston Merge pull request #974 from rspec/deprecate_rcov_integration
Deprecate rake task rcov options
013a04c
@JonRowe
RSpec member

I like this :) :+1:

Looks good to me.

RSpec member

:+1: Nice

myronmarston and others added some commits Jul 14, 2013
@myronmarston myronmarston Remove old deprecation API. c07c4cf
@JonRowe JonRowe Merge pull request #990 from rspec/remove_old_deprecatio_api_2_99
Remove old deprecation API.
bc40c59
@JonRowe JonRowe expose exe file location
Conflicts:
	lib/rspec/core.rb
86d205c
@JonRowe JonRowe Merge pull request #991 from rspec/expose_exe_299
Expose exe file location on 2-99
1ff7a01
@JonRowe JonRowe refactor configuration so that requires happen before spec files are …
…loaded to ensure we can programatically configure pattern
0b36924
@JonRowe JonRowe Merge pull request #996 from rspec/force_require_before_specfiles_loa…
…ded_299

Force require (and libs) before spec files loaded. 2-99
abbbecb
@myronmarston myronmarston Autoload RSpec::Mocks and RSpec::Expectations.
We already autoload RSpec::Matchers to support folks using
`RSpec::Matchers.define` before the normal time that rspec-core
loads rspec-expectation (e.g. right before eval'ing the first
example group block). This extends it to RSpec::Mocks and
RSpec::Expectations for parity and to improve things for folks
who we accidentally broke via this rspec gem change:

rspec/rspec@f10bedd

That was put in place to address rspec/rspec-mocks#359, which has more info.
Conflicts:
	spec/rspec/core_spec.rb
cfae1e4
@alindeman alindeman Adds `RSpec.current_example`
* Library authors that want to support RSpec 2 and 3
  can use `RSpec.current_example` to find the current example in a hook
  method. In RSpec versions before 2.99, `self.example` can be used (but
  `self.example` is deprecated in RSpec >= 2.99 and removed in RSpec 3).
50efee4
@alindeman alindeman The example shows how to "memoize" the result of RSpec.respond_to?(:c…
…urrent_example)
72237b7
@alindeman alindeman Uses thread-local variables
* While RSpec isn't necessarily thread safe right now, it might be in
  the future.
abb235b
@alindeman alindeman Merge pull request #1011 from alindeman/current_example
RSpec.current_example (2.99)
05d9c84
@alindeman alindeman Corrects typo in lambda vs. proc syntax ec30674
@myronmarston myronmarston Merge pull request #1001 from rspec/autoload_other_rspec_libs_299
Autoload RSpec::Mocks and RSpec::Expectations (299)
55dc18c
@JonRowe JonRowe Warn about non integer profile arguments
fixes #998
f01fc9e
@JonRowe JonRowe refactor to cast to Integer and rescue ArgumentError instead of using…
… regexp
901ec75
@myronmarston myronmarston Update changelog with 2.14.4 release notes.
[ci skip]
7398423
@JonRowe JonRowe Merge pull request #1016 from rspec/safely_clear_shared_example_group…
…s_214

Safely clear shared example groups, rebased off 2-14, speced and change logged.
Conflicts:
	Changelog.md
620c9b8
@JonRowe JonRowe update to truthy/falsey to remove deprecation warnings 43272b6
@JonRowe JonRowe Merge pull request #1017 from rspec/change_to_truthy_falsey
Change to truthy falsey to remove deprecation warnings in 2-99
b464b01
@JonRowe JonRowe Merge pull request #1015 from rspec/safely_clear_shared_example_groups
Safely clear shared example groups, rebased, speced and changelogged.
Conflicts:
	Changelog.md
	spec/rspec/core/shared_example_group_spec.rb
43deda5
@JonRowe JonRowe update more shared example group methods to use registry class b155854
@JonRowe JonRowe Merge --pattern warning into 2-99 110a6f2
@JonRowe JonRowe Merge PR#1023 into 2-99-mainteance a930008
@JonRowe JonRowe Merge pull request #1026 from rspec/run_consecutive_after_all_hooks_w…
…hen_rescued

All after hooks should be run even if the first one fails
166c000
@JonRowe JonRowe remove option to profile which has never worked 1d4c58d
@JonRowe JonRowe spec to check we ignore the profile option 926ddd6
@myronmarston myronmarston Update changelog with 2.14.5 release notes. e2485ad
@myronmarston myronmarston Deprecate `treat_symbols_as...` option being set to false. 8895a71
@JonRowe JonRowe Merge pull request #1043 from rspec/deprecate_treat_symbols_option_false
Deprecate treat symbols option false
9bced6c
@myronmarston myronmarston Ported CallerFilter from rspec-mocks. 4a1e522
@myronmarston myronmarston Add caller benchmark script from rspec-mocks. 376dd00
@myronmarston myronmarston Address warning.
warning: assigned but unused variable - group
0a41363
@soulcutter soulcutter Limit the spamminess of default deprecation messages
As discussed in rspec/rspec-mocks#386
77a8dec
@soulcutter soulcutter Add spec for File deprecation_stream output 27c2417
@soulcutter soulcutter Changelog entry 9c7d8af
@soulcutter soulcutter Simplify Hash initialization bf222f7
@soulcutter soulcutter Extract classes for File and IO behaviors in DeprecationFormatter
Conflicts:
	lib/rspec/core/formatters/deprecation_formatter.rb
	spec/rspec/core/formatters/deprecation_formatter_spec.rb
a2e715d
@soulcutter soulcutter Defer printing deprecation warnings until summary
Conflicts:
	spec/rspec/core/formatters/deprecation_formatter_spec.rb
73422fd
@soulcutter soulcutter Remove factory method for DeprecationFormatter
Conflicts:
	lib/rspec/core/formatters/deprecation_formatter.rb
69aa3fa
@soulcutter soulcutter Move away from Struct-based formatter implementations 6012000
@soulcutter soulcutter Use formatter pluralize helper 78f99f0
@soulcutter soulcutter Refactor deprecation formatter
This cleans up a number of code style and clarity
issues pointed out in the code review comments from
#1029
2840da1
@myronmarston myronmarston Make source_location conditional static.
We know at code load time whether or not anything
has to be done here, so evaluate the conditional once.
7759370
@dchelimsky

I presume this is to support Ruby-1.8.7. We recently did something similar to support flat_map in Ruby >= 1.8.7: c8a3804#L4R4

I imagine more of these will come up on the road to rspec-3, and I'd like to see these be more identifiable so they'll be easier to recognize and remove at the point that we stop supporting 1.8.7.

What do you think about querying the RUBY_VERSION instead e.g. if RUBY_VERSION == "1.8.7"

Another, more architected, approach would be to organize code for diff Ruby versions in diff files. So we could do something like:

require "rspec/core/shared_example_group"
# ^^ this has all the common functionality ^^
if RUBY_VERSION == "1.8.7"
  require "rspec/ruby_version_support/1.8.7/core/shared_example_group"
else
  require "rspec/ruby_version_support/gte-1.9/core/shared_example_group"
end

It's extra work but it does a great job of describing the need for these sorts of switches and makes it easier to find and remove them later. WDYT?

RSpec member

Generally, I prefer querying based on a particular feature rather than based on the ruby version. There are many 1.9+ features that may be available on 1.8.7 if the user is using activesupport or the backports gem. If the feature is available but they're on 1.8.7, I'd like to use the feature.

That said, you're absolutely right that it's good to make these legacy hacks easily identifiable for when we drop support for the old versions. In other places, I've tended to do something like this:

if SomeCoreClass.method_defined?(:some_method) # for Ruby 1.8.7
  # do the hack
else
  # do the normal thing
end

Basically, use a comment to express that a particular conditional branch is needed for a certain ruby version. This is just as easily identifiable as using RUBY_VERSION in the conditional. That said, I forgot to add the version comment here, so I should update this if we're going to make this the "normal" way we do these sorts of conditional work-arounds.

As for putting the version-specific stuff into a separate file: I'm of two minds on this. It's extra work as you mention. Also, 1.9 is well-known to have poor require performance, and splitting into additional files to require will likely slow down rspec's boot time. On the other hand, I have used this technique in the past on projects where I've used simplecov and kept up a certain threshold of test coverage (usually 100%). For code that would never execute on 1.9 (because it's only needed for 1.8), I've moved the code into a separate file that I instruct simplecov to ignore. If/when we ever decided to make a coverage threshold part of the build, I'd probably be in favor of this as a technique for being able to ignore certain code from being considered.

For now, I think I prefer to not move it into a separate file; the additional load time is kinda a big deal to me.

RSpec member

All makes sense. Thanks.

RSpec member

I added the comment in a few places in 20095ab. I may have missed some but it's a start.

JonRowe and others added some commits Sep 23, 2013
@JonRowe JonRowe ammend changelog
[skip ci]
2375a0b
@JonRowe JonRowe Merge pull request #1081 from rspec/deprecation_warning_let_subject_b…
…efore_all

Add a deprecation warning to 2.99 for accessing let/subject from `after(:all)`
a807624
@iamvery iamvery Use explicit conversion methods for stringified numbers
* As @greggroth pointed out in rspec/rspec-core#1086, the formatter
  does not work as expected when the mathn lib is loaded. This lib adds
  the Rational type which is formatted as "n/n" when stringified rather
  than the float form. By explicitly converting the arithmetic to the
  types we wish to stringify, this display is corrected.
* This contains all commits of PR #1087, squashed
  together for easy back-porting to 2-14-maintenance
  and 2-99-maintenance.
0f99d62
@JonRowe JonRowe Merge pull request #1106 from lgierth/dont-extend-exception
Don't extend exception

Conflicts:
	Changelog.md
	lib/rspec/core/pending.rb
e5b18b7
@JonRowe JonRowe Correct changelog
[ci skip]
ccc3a73
@palfvin palfvin Deprecate 'its' support in favor of rspec-its gem a6df4eb
@JonRowe JonRowe Merge pull request #1104 from palfvin/2-99-its
Deprecate 'its' in favor of rspec-its gem as part of #1083
0928c69
@myronmarston myronmarston Prefer backticks for wrapping code elements in comments.
This is consistent with our comments elsewhere.
5ebfc6d
@myronmarston myronmarston Fix spec to match the deprecation change in the last commit. cbafda9
@myronmarston myronmarston Update changelog based on 2.14.6 release.
[ci skip]
649d087
@soulcutter soulcutter Limit deprecation output for non-generated messages
Conflicts:
	spec/rspec/core/formatters/deprecation_formatter_spec.rb
07506ef
@soulcutter soulcutter Eliminate DeprecationMessage mixin module
Conflicts:
	lib/rspec/core/formatters/deprecation_formatter.rb
b62d78b
@soulcutter soulcutter Add period to end of message bb68c1a
@soulcutter soulcutter Remove DeprecationWarning base class 6b45314
@myronmarston myronmarston Merge pull request #1125 from rspec/deprecation-formatter-2-99-cherry…
…picks

Deprecation formatter 2 99 cherrypicks
bca50bd
@JonRowe JonRowe Merge pull request #1124 from rspec/allow_suppression_of_local_repos
Allow suppression of local repos
89c5da6
@myronmarston myronmarston Fixe a regression in 2.14.6 w/ Fivemat formatter.
In https://github.com/tpope/fivemat/blob/v1.2.1/lib/fivemat/rspec.rb#L43-L49,
Fivemat has two ways to check for pending example fixed:
 - example.execution_result[:exception].pending_fixed?
   (but we removed this in #1106 because it broke when dealing with frozen exceptions)
 - RSpec::Core::PendingExampleFixedError === exception
   (but this const was renamed in b5d10cc).

The `RSpec::Core::PendingExampleFixedError` line in Fivemat was
never hit in recent releases because `example.execution_result[:exception]`
responded to `pending_fixed?` -- until 2.14.6.
35850da
@myronmarston myronmarston Add 2.14.7 release notes. 13fa119
@myronmarston myronmarston Deprecate RSpec::Core::PendingExampleFixedError.
This is the analog of #1129 but for 2.99.
adfb5c0
@myronmarston myronmarston Merge pull request #1131 from rspec/deprecate-pending-example-fixed-c…
…onst

Deprecate RSpec::Core::PendingExampleFixedError.
64ba913
@JonRowe JonRowe defer to configuration and default to stdout/stderr e498174
@JonRowe JonRowe dont capture printer if we havent configured yet (fallback) 108f21c
@JonRowe JonRowe send file when file 8c04fcc
@JonRowe JonRowe bow to peer pressure 3fcaa6d
@myronmarston myronmarston Merge pull request #1130 from rspec/deprecation_formatter_fix_299
Use configuration rather than streams directly in deprecation formatter and fall back to std pipes
c63dc74
@myronmarston myronmarston Add `expose_current_running_example_as` config option.
Fixes #963.
17eb4fe
@myronmarston myronmarston Ensure the current example can be exposed via multiple helper methods. 73f079f
@myronmarston myronmarston Isolate this spec from "leaking" changes to the helper module. ff7cc7d
@myronmarston myronmarston When using `expose_current_running…` no deprecation should be printed. d00a626
@myronmarston myronmarston Improve example/running_example deprecation warning. 7d6d2ca
@myronmarston myronmarston Add changelog entry. eb5bd2b
@myronmarston myronmarston Merge pull request #1135 from rspec/expose-current-running-example-2-99
Expose current running example 2 99
0c9c2ab
@myronmarston myronmarston Silence deprecations about `its` since we need to test it here. e9d069d
@myronmarston myronmarston Improve wording of deprecation.
"Use the rspec-its gem instead" reads better than
"Use rspec-its gem instead".
fd01e39
@myronmarston myronmarston Merge pull request #1138 from rspec/its-warnings
Its warnings
1db3910
@xaviershay xaviershay Prevent CallerFilter specs from trawling my entire hard-drive.
Also enables them to be run individually.
2c54f2d
@myronmarston myronmarston Merge pull request #1139 from rspec/caller-filter-fix
Prevent CallerFilter specs from trawling my entire hard-drive.
585f904
@myronmarston myronmarston Revert "Merge pull request #1130 from rspec/deprecation_formatter_fix…
…_299"

This reverts commit c63dc74, reversing
changes made to 64ba913.

We're reverting this because this didn't actually solve the problem
of issueing deprecation warnings from option_parser.rb.
fdcd136
@myronmarston myronmarston Default `output_stream` to $stdout.
This is what the docs say we do. It's also necessary
so that if `configuration.reporter` is accessed before
the CommandLine class has set the output_stream, it
uses $stdout as its output rather than a `StringIO.new`.

Before, issuing a deprecation from `option_parser.rb`
was causing no spec output at all since that happened
before the output_stream was set.
68c959f
@myronmarston myronmarston Fix a couple specs so that they explicitly redirect unwanted output.
These specs depended on the reporter defaulting
to a `StringIO.new`. Now that it is defaulting to
`$stdout`, we were getting unwanted output from these
two specs.
33f600e
@myronmarston myronmarston Use `output_stream` as the standardized method name.
Everything else in RSpec uses `output_stream`.
106eda2
@myronmarston myronmarston Warn if output_stream is changed after it has already been used by th…
…e reporter.
d436453
@myronmarston myronmarston Deprecate `out` and `output` aliases of `output_stream`.
There's no reason for us to have the complexity of
3 names for the same thing.
078f493
@myronmarston myronmarston Address ruby warning. f7038dc
@myronmarston myronmarston Add changelog entry. 1aa63a7
@myronmarston myronmarston Ruby 1.8 lacks public_send. 78f7cf9
@myronmarston myronmarston Merge pull request #1141 from rspec/fix-1127
Fix 1127 in 2-99-maintenance
7fd920d
@myronmarston myronmarston Deprecate old ordering APIs. 466b674
@myronmarston myronmarston Deprecate `--order default` in favor of `--order defined`. 73e660c
@myronmarston myronmarston Add changelog entry. 5dfb16e
@myronmarston myronmarston Merge pull request #1146 from rspec/ordering-api-deprecations
Ordering api deprecations
55cd1be
@soulcutter soulcutter Add newlines after too many deprecations warnings cd1c661
@soulcutter soulcutter Group deprecations together separated by newlines 01e291b
@xaviershay xaviershay Consistent formatting of changelog. acca274
@myronmarston myronmarston Merge pull request #1155 from rspec/2-99-changelog
Consistent formatting of changelog.
f8a428b
@myronmarston myronmarston Don't warn about shared example group args when it has a default arg.
This was creating a confusing warning.

Fixes #1148.
4fe5bdf
@myronmarston myronmarston Merge pull request #1157 from rspec/fix-inaccurate-shared-example-arg…
…-warning

Don't warn about shared example group args when it has a default arg.
ea3a117
@myronmarston myronmarston Sync the deprecation formatter file to avoid odd duplicate lines.
When upgrading a project at work, I observed *lots* of duplicate
lines winding up in the deprecation file, even though the
`deprecation_stream.puts` line was only hit a small number of times.
Setting `sync = true` (while debugging the issue) was observed to
fix the problem.  No idea why :(.
248b4f0
@myronmarston myronmarston Don't print duplicate deprecation messages.
When a spec suite uses a helper method that is called
from a global `before` hook and calls a deprecated method,
we only need one deprecation message in our output,
not one per spec.

Note that this only limits *identical* deprecation messages.
The same deprecation from multiple call sites will still
each get printed.

Fixes #1151.
97be6e5
@myronmarston myronmarston Add `require 'set'`.
Since this file depends on it.
9e876e6
@myronmarston myronmarston Merge pull request #1159 from rspec/fix-duplicate-deprecations-2-99
Fix duplicate deprecations 2 99
0cfe064
@myronmarston myronmarston Remove unnecessary .rb from require. 686b7c3
@myronmarston myronmarston Add config option to raise errors on deprecations. ec11ee7
@myronmarston myronmarston Add notice about the new option so users are made aware of it. 6697c95
@myronmarston myronmarston Add changelog entry for new config option. a16104a
@myronmarston myronmarston This is more of an enhancement than a bug fix. cc243a4
@myronmarston myronmarston Rename deprecation printer classes.
For the new `raise_errors` option, we were using
the FilePrinter but not actually giving it a File
object. We use it because it immediately prints
deprecations, whereas the IOPrinter delays the printing
of errors until the end, so I think these names are
better.
c96962a
@myronmarston myronmarston Merge pull request #1162 from rspec/turn-deprecations-into-errors-2-99
Turn deprecations into errors (2.99)
0cbab87
@myronmarston myronmarston Fixup changelog.
[ci skip]
e1e7a10
@myronmarston myronmarston Update changelog for v2.99.0.beta1 [ci skip] 494f302
@myronmarston myronmarston Release 2.99.0.beta1 06ce5b6
@myronmarston myronmarston Fix failure in end-of-run summary for the error stream.
We were getting an "undefined method `path'" error.

While I'm at it, I prevented the RAISE_ERROR_CONFIG_NOTICE
from being printed when that config option is being used.

Fixes #1170.
91f83a0
@soulcutter soulcutter Merge pull request #1172 from rspec/fix-1170-for-2.99
Fix failure in end-of-run summary for the error stream (for 2.99)
31d87d8
@JonRowe JonRowe deprecate old reporter method 5cd5235
@JonRowe JonRowe more verbose deprecation 464fd3f
@myronmarston myronmarston Merge pull request #1175 from rspec/deprecate_reporter_abort
Deprecate old reporter method
2f372eb
@JonRowe JonRowe dont redefine caller filter if it's already defined, fixes rspec/rspe… 4deadc5
@myronmarston myronmarston Merge pull request #1177 from rspec/dont_redefine_caller_filter
Dont redefine caller filter if it's already defined
1b14866
@myronmarston myronmarston Add `is_expected` for expect-based one-liner syntax. f65149e
@myronmarston myronmarston Merge pull request #1182 from rspec/is_expected_2.99
Add `is_expected` for expect-based one-liner syntax.
25c326a
@myronmarston myronmarston Deprecate inexact mock_with options.
RSpec 3 will not do the fuzzy matching that was done before.
c598182
@myronmarston myronmarston Merge pull request #1189 from rspec/mock-adapter-deprecations
Deprecate inexact mock_with options.
4990cc7
@myronmarston myronmarston Rubinius uses slightly different phrasing for this error.
Missing or uninitialized constant: RSpec::Core::SomeUndefinedConst

...rather than:

uninitialized constant RSpec::Core::SomeUndefinedConst
7378736
@myronmarston myronmarston Merge pull request #1190 from rspec/fix-test-on-rbx
Rubinius uses slightly different phrasing for this error.
2c89752
@JonRowe JonRowe Fix issue where ordering isn't forced properly.
Fixes #1181
134265b
@myronmarston myronmarston Fix typo. cf8adfe
@JonRowe JonRowe Change log entry for ordering fix
[skip ci]
cedab5c
@JonRowe JonRowe Merge pull request #1194 from rspec/fix_issue_with_ordering_preference
Fix issue where ordering isn't forced properly
267598d
@myronmarston myronmarston Add test fixture for 2.1. 81b9075
@myronmarston myronmarston Build against 2.1.0-rc1. 18dc82d
@myronmarston myronmarston Deal with JRuby 1.7.8 output still being problematic. 3f0cc11
@JonRowe JonRowe Merge pull request #1230 from rspec/build-2-99-against-2.1
Build 2 99 against 2.1
d2962a5
@myronmarston myronmarston 2.1.0 is out. eed459f
@myronmarston myronmarston Redefine rspec-mocks method to make our sandboxing work properly. 1a24527
@myronmarston myronmarston deleted the fix-broken-2-99-build branch Jan 28, 2014
@myronmarston
RSpec member

Woops targeted wrong branch...will try again.

@myronmarston myronmarston restored the fix-broken-2-99-build branch Jan 28, 2014
@JonRowe JonRowe deleted the fix-broken-2-99-build branch Jan 28, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.