Redefine rspec-mocks method to make our sandboxing work properly. #1274

Merged
merged 1 commit into from Jan 28, 2014

Conversation

Projects
None yet
3 participants
@myronmarston
Owner

myronmarston commented Jan 28, 2014

This is an alternate fix to #1270. It fixes the build and prevents other mock scope warnings.

I think I like it a bit better than the fix in #1270 but I'm curious on your thoughts, @xaviershay.

@JonRowe

This comment has been minimized.

Show comment Hide comment
@JonRowe

JonRowe Jan 28, 2014

Owner

I like it...

Owner

JonRowe commented Jan 28, 2014

I like it...

@xaviershay

This comment has been minimized.

Show comment Hide comment
@xaviershay

xaviershay Jan 28, 2014

Owner

First reaction was I'd prefer to fix the specs that were broken, but second reaction is that there are plenty of others that aren't "broken" but are spewing deprecations. So in that case this is the better fix.

LGTM.

Owner

xaviershay commented Jan 28, 2014

First reaction was I'd prefer to fix the specs that were broken, but second reaction is that there are plenty of others that aren't "broken" but are spewing deprecations. So in that case this is the better fix.

LGTM.

JonRowe added a commit that referenced this pull request Jan 28, 2014

Merge pull request #1274 from rspec/fix-broken-2-99-build
Redefine rspec-mocks method to make our sandboxing work properly.

@JonRowe JonRowe merged commit 511cb7f into 2-99-maintenance Jan 28, 2014

1 check passed

default The Travis CI build passed
Details

@JonRowe JonRowe deleted the fix-broken-2-99-build branch Jan 28, 2014

@myronmarston

This comment has been minimized.

Show comment Hide comment
@myronmarston

myronmarston Jan 28, 2014

Owner

First reaction was I'd prefer to fix the specs that were broken,

FWIW, that was my initially reaction until I thought about it and realized the specs aren't really broken: it's just that the simplistic "are we outside an example" detection in rspec-mocks 2.99 doesn't understand the way we define and run examples from within examples in rspec-core, so it issues warnings when we are actually inside an example.

Owner

myronmarston commented Jan 28, 2014

First reaction was I'd prefer to fix the specs that were broken,

FWIW, that was my initially reaction until I thought about it and realized the specs aren't really broken: it's just that the simplistic "are we outside an example" detection in rspec-mocks 2.99 doesn't understand the way we define and run examples from within examples in rspec-core, so it issues warnings when we are actually inside an example.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment