Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upMove warnings from .rspec to spec_helper, Fixes #1571 #1572
+4
−1
Conversation
myronmarston
reviewed
Jun 3, 2014
| @@ -25,6 +25,10 @@ | ||
| config.filter_run :focus | ||
| config.run_all_when_everything_filtered = true | ||
| # This setting enables warnings. It's recommended, but in some cases may | ||
| # be too noisy due to issues in dependencies. | ||
| # config.warnings = true |
This comment has been minimized.
This comment has been minimized.
myronmarston
Jun 3, 2014
Member
The # here is unnecessary -- the entire section is commented out by being surrounded with =begin and =end. So this is effectively commenting it out twice.
This comment has been minimized.
This comment has been minimized.
added a commit
that referenced
this pull request
Jun 3, 2014
myronmarston
merged commit 4da5bc8
into
rspec:master
Jun 3, 2014
1 check passed
continuous-integration/travis-ci
The Travis CI build passed
Details
This comment has been minimized.
This comment has been minimized.
|
Thanks, @GeekOnCoffee! |
added a commit
that referenced
this pull request
Jun 3, 2014
added a commit
that referenced
this pull request
Jun 7, 2014
myronmarston
referenced this pull request
Mar 9, 2016
Closed
Warnings-flag should default to true. #2201
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
GeekOnCoffee commentedJun 3, 2014
No description provided.