Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move warnings from .rspec to spec_helper, Fixes #1571 #1572

Merged
merged 1 commit into from Jun 3, 2014

Conversation

@GeekOnCoffee
Copy link
Contributor

@GeekOnCoffee GeekOnCoffee commented Jun 3, 2014

No description provided.

@@ -25,6 +25,10 @@
config.filter_run :focus
config.run_all_when_everything_filtered = true
# This setting enables warnings. It's recommended, but in some cases may
# be too noisy due to issues in dependencies.
# config.warnings = true

This comment has been minimized.

@myronmarston

myronmarston Jun 3, 2014
Member

The # here is unnecessary -- the entire section is commented out by being surrounded with =begin and =end. So this is effectively commenting it out twice.

This comment has been minimized.

@GeekOnCoffee

GeekOnCoffee Jun 3, 2014
Author Contributor

Ooops. Fixed.

myronmarston added a commit that referenced this pull request Jun 3, 2014
Move warnings from .rspec to spec_helper, Fixes #1571
@myronmarston myronmarston merged commit 4da5bc8 into rspec:master Jun 3, 2014
1 check passed
1 check passed
@alindeman
continuous-integration/travis-ci The Travis CI build passed
Details
@myronmarston
Copy link
Member

@myronmarston myronmarston commented Jun 3, 2014

Thanks, @GeekOnCoffee!

myronmarston added a commit that referenced this pull request Jun 3, 2014
myronmarston added a commit that referenced this pull request Jun 7, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants