Focus fix #268

Closed
wants to merge 2 commits into
from

Projects

None yet

2 participants

@myronmarston
Member

See d3456f3#comments for background info

@dchelimsky

How about also aliasing to :focus, with the same args? That way you can combine focus "example" do or focused "example" do with config.filter_run :focus => true or config.filter_run :focused => true and it should all work.

Member

I thought about that but I think it sounds kinda funny:

describe MyClass do
  focus "does something awesome" do
  end
end

focused, as an adjective, reads better to me. But I'm fine adding both :)

Member

I'm thinking of POLS here - if you write config.filter_run :focus => true you'd expect focus "blah" do (I think). Given that it's so trivial to add, I think we should do it. Then you can choose to always use focused :)

Member

Done:

ebc34f1

@dchelimsky
Member

Add #focus as an alias for #focused.

@timcharper timcharper pushed a commit to timcharper/rspec-core that referenced this pull request Aug 19, 2011
@dchelimsky dchelimsky Add #focus as an alias for #focused.
- see rspec@d3456f3#comments
  for more info,
- Closes #268.
fc9be3b
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment