Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Fix rspec-core cuke build on JRuby #418

Closed
wants to merge 5 commits into from

3 participants

@kaiwren

See Issue #344

@halostatue

I can confirm that these changes cause the cucumber tests to pass cleanly under JRuby 1.6.3.

@dchelimsky
Owner

Hey @kaiwren - closing this as we solved the problem a different way. As always, thanks for effort.

@dchelimsky dchelimsky closed this
@dchelimsky
Owner

BTW: 1592c94

@kaiwren

@dchelimsky Noted, and thanks for the update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
This page is out of date. Refresh to see the latest.
View
14 features/formatters/text_formatter.feature
@@ -33,8 +33,13 @@ Feature: text formatter
got: 12
(compared using ==)
- # ./integer_spec.rb:3
-
+ """
+ And the backtrace-normalized output should contain:
+ """
+ # ./integer_spec.rb:3
+ """
+ And the backtrace-normalized output should contain:
+ """
2) String has a failing example
Failure/Error: "foo".reverse.should eq("ofo")
@@ -42,5 +47,8 @@ Feature: text formatter
got: "oof"
(compared using ==)
- # ./string_spec.rb:3
+ """
+ And the backtrace-normalized output should contain:
+ """
+ # ./string_spec.rb:3
"""
View
20 features/mock_framework_integration/use_rr.feature
@@ -6,6 +6,10 @@ Feature: mock with rr
Given a file named "example_spec.rb" with:
"""
RSpec.configure do |config|
+ if RUBY_PLATFORM =~ /java/
+ require 'jruby'
+ JRuby.objectspace=true
+ end
config.mock_framework = :rr
end
@@ -24,6 +28,10 @@ Feature: mock with rr
Given a file named "example_spec.rb" with:
"""
RSpec.configure do |config|
+ if RUBY_PLATFORM =~ /java/
+ require 'jruby'
+ JRuby.objectspace=true
+ end
config.mock_framework = :rr
end
@@ -41,6 +49,10 @@ Feature: mock with rr
Given a file named "example_spec.rb" with:
"""
RSpec.configure do |config|
+ if RUBY_PLATFORM =~ /java/
+ require 'jruby'
+ JRuby.objectspace=true
+ end
config.mock_framework = :rr
end
@@ -61,6 +73,10 @@ Feature: mock with rr
Given a file named "example_spec.rb" with:
"""
RSpec.configure do |config|
+ if RUBY_PLATFORM =~ /java/
+ require 'jruby'
+ JRuby.objectspace=true
+ end
config.mock_framework = :rr
end
@@ -83,6 +99,10 @@ Feature: mock with rr
Given a file named "example_spec.rb" with:
"""
RSpec.configure do |config|
+ if RUBY_PLATFORM =~ /java/
+ require 'jruby'
+ JRuby.objectspace=true
+ end
config.mock_framework = :rr
end
View
2  features/support/env.rb
@@ -1,5 +1,5 @@
require 'aruba/cucumber'
Before do
- @aruba_timeout_seconds = 5
+ RUBY_PLATFORM =~ /java/ ? @aruba_timeout_seconds = 60 : @aruba_timeout_seconds = 5
end
View
1  spec/rspec/core/formatters/base_formatter_spec.rb
@@ -46,7 +46,6 @@
end
it "doesn't hang when file exists" do
- pending("This issue still exists on JRuby, but should be resolved shortly: https://github.com/rspec/rspec-core/issues/295", :if => RUBY_PLATFORM == 'java')
exception = mock(:Exception, :backtrace => [ "#{__FILE__}:#{__LINE__}"])
example = mock(:Example, :file_path => __FILE__)
Something went wrong with that request. Please try again.