two additional tests for FilterManager #519

Merged
merged 2 commits into from Dec 2, 2011

Projects

None yet

2 participants

@AlexKVal

If rename :replace into :some_other in the FilterManager#update, and then run tests,
only couple of them would fail and they all are indirect.

configuration.rb inclusion_filter= and exclusion_filter= also needs tests.
I'll write them later, when I'll be digging through the configuration.rb.

@dchelimsky
RSpec member

I'm actually in the middle of refactoring this and these specs won't apply any longer. You can add specs for the configuration, as the changes I'm making won't affect how it is called (though it will affect how it calls out to the FilterManager, but I'll deal w/ that).

Thx!

@dchelimsky dchelimsky closed this Dec 1, 2011
@AlexKVal

ok

@dchelimsky dchelimsky reopened this Dec 2, 2011
@dchelimsky dchelimsky merged commit b2a9716 into rspec:master Dec 2, 2011
@dchelimsky
RSpec member

Changed my mind - will use some of your pull, though some will be replaced.

@dchelimsky
RSpec member

FYI: 399436c

@AlexKVal

Much better. IMHO.

@AlexKVal

configuration.rb inclusion_filter= and exclusion_filter= also needs tests.
I'll write them later, when I'll be digging through the configuration.rb.

538

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment