--order --seed and #force. Removed duplication. #537

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
3 participants
Contributor

AlexKVal commented Dec 9, 2011

No description provided.

@dchelimsky dchelimsky commented on the diff Dec 18, 2011

lib/rspec/core/configuration.rb
@@ -705,7 +682,7 @@ def command
end
def value_for(key, default=nil)
- @preferred_options.has_key?(key) ? @preferred_options[key] : default
+ @preferred_options[key] ? @preferred_options[key] : default
@dchelimsky

dchelimsky Dec 18, 2011

Owner

This line needs to stay as/is because if @preferred_otpions[key] is assigned false we'll get the default instead of false. Must be missing a spec for that.

@dchelimsky dchelimsky commented on the diff Dec 18, 2011

lib/rspec/core/configuration.rb
@@ -799,6 +776,18 @@ def file_at(path)
File.new(path, 'w')
end
+ def order_n_seed_from_seed(value)
@dchelimsky

dchelimsky Dec 18, 2011

Owner

How about order_and_seed_from_seed? Using _n_ in the middle made me think of a number rather than a conjunction :)

Contributor

AlexKVal commented Dec 18, 2011

remade and added missed test for case when forced value is 'false' in 542

Contributor

justinko commented May 27, 2012

Most of these changes have been included. Thanks for the pull @AlexKVal

justinko closed this May 27, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment