Fix Cucumber deprecation warnings #559

Merged
merged 1 commit into from Jan 22, 2012

Conversation

Projects
None yet
2 participants
@exviva
Contributor

exviva commented Jan 21, 2012

This removes the following warning:

WARNING: Using 'Given/When/Then' in step definitions
is deprecated, use 'step' to call other steps instead
Fix Cucumber deprecation warnings
This removes the following warning:

    WARNING: Using 'Given/When/Then' in step definitions
    is deprecated, use 'step' to call other steps instead
@justinko

This comment has been minimized.

Show comment Hide comment
@justinko

justinko Jan 22, 2012

Contributor

Here are some questions you have to answer before fixing the deprecations:

1.) If I update the deprecated method, will it cause errors in other users local code base if they pull? What version of Cucumber could they possibly be using?
2.) What version was this new method introduced? What version is this software tied to?

I'll give you a hint: check when Cucumber added this new step method, and force RSpec devs to use at least that version.

Do that and I'll merge :)

Contributor

justinko commented Jan 22, 2012

Here are some questions you have to answer before fixing the deprecations:

1.) If I update the deprecated method, will it cause errors in other users local code base if they pull? What version of Cucumber could they possibly be using?
2.) What version was this new method introduced? What version is this software tied to?

I'll give you a hint: check when Cucumber added this new step method, and force RSpec devs to use at least that version.

Do that and I'll merge :)

@justinko

This comment has been minimized.

Show comment Hide comment
@justinko

justinko Jan 22, 2012

Contributor

Whoops! Cucumber 1.1.0 has step. Thanks for the pull.

Contributor

justinko commented Jan 22, 2012

Whoops! Cucumber 1.1.0 has step. Thanks for the pull.

justinko added a commit that referenced this pull request Jan 22, 2012

Merge pull request #559 from exviva/fix_cucumber_warnings
Fix Cucumber deprecation warnings

@justinko justinko merged commit b94ec20 into rspec:master Jan 22, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment