Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Fix Cucumber deprecation warnings #559

Merged
merged 1 commit into from

2 participants

@exviva

This removes the following warning:

WARNING: Using 'Given/When/Then' in step definitions
is deprecated, use 'step' to call other steps instead
@exviva exviva Fix Cucumber deprecation warnings
This removes the following warning:

    WARNING: Using 'Given/When/Then' in step definitions
    is deprecated, use 'step' to call other steps instead
8651de2
@justinko

Here are some questions you have to answer before fixing the deprecations:

1.) If I update the deprecated method, will it cause errors in other users local code base if they pull? What version of Cucumber could they possibly be using?
2.) What version was this new method introduced? What version is this software tied to?

I'll give you a hint: check when Cucumber added this new step method, and force RSpec devs to use at least that version.

Do that and I'll merge :)

@justinko

Whoops! Cucumber 1.1.0 has step. Thanks for the pull.

@justinko justinko merged commit b94ec20 into rspec:master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Jan 21, 2012
  1. @exviva

    Fix Cucumber deprecation warnings

    exviva authored
    This removes the following warning:
    
        WARNING: Using 'Given/When/Then' in step definitions
        is deprecated, use 'step' to call other steps instead
This page is out of date. Refresh to see the latest.
Showing with 2 additions and 2 deletions.
  1. +2 −2 features/step_definitions/additional_cli_steps.rb
View
4 features/step_definitions/additional_cli_steps.rb
@@ -11,8 +11,8 @@
end
Then /^the example(?:s)? should(?: all)? pass$/ do
- Then %q{the output should contain "0 failures"}
- Then %q{the exit status should be 0}
+ step %q{the output should contain "0 failures"}
+ step %q{the exit status should be 0}
end
Then /^the file "([^"]*)" should contain:$/ do |file, partial_content|
Something went wrong with that request. Please try again.