Do not modify example ancestry when dumping errors #588

Merged
merged 1 commit into from Mar 24, 2012

Conversation

Projects
None yet
2 participants
@grosser
Contributor

grosser commented Mar 24, 2012

This causes bugs (Notably that after blocks / transaction rollback is not executed properly)
when errors are dumped while examples are still running
as is done by rspec-instafail and therefore fuubar formatter.

@dchelimsky

This comment has been minimized.

Show comment Hide comment
@dchelimsky

dchelimsky Mar 24, 2012

Member

I'll merge this if you add a spec that fails without this change.

Member

dchelimsky commented Mar 24, 2012

I'll merge this if you add a spec that fails without this change.

Do not modify example ancestry when dumping errors
This causes bugs (Notably that after blocks / transaction rollback is not executed properly)
when errors are dumped while examples are still running
as is done by [rspec-instafail](https://github.com/grosser/rspec-instafail) and therefore fuubar formatter.
@grosser

This comment has been minimized.

Show comment Hide comment
@grosser

grosser Mar 24, 2012

Contributor

Done!

Contributor

grosser commented Mar 24, 2012

Done!

dchelimsky added a commit that referenced this pull request Mar 24, 2012

Merge pull request #588 from grosser/preserve_ancestry_on_failure
Do not modify example ancestry when dumping errors

@dchelimsky dchelimsky merged commit 3ff65ad into rspec:master Mar 24, 2012

dchelimsky added a commit that referenced this pull request Mar 24, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment