Clear let/subject memoization when referenced in before(:all). #811
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
myronmarston
added a commit
that referenced
this pull request
Mar 2, 2013
Clear let/subject memoization when referenced in before(:all).
| def self.warn_about_unsound_let_usage(let_hash) | ||
| called_lets = let_hash.keys.map { |l| "`#{l}`" }.join(' and ') | ||
|
|
||
| ::RSpec.warn_deprecation "WARNING: let declaration(s) #{called_lets} referenced " + |
There was a problem hiding this comment.
I'd like to see this reference the line on which the before(:all) hook is declared. Also, not sure if this is already the case, but once per group (rather than once per example) would be nice.
There was a problem hiding this comment.
Thanks for the feedback. I wanted to get a backtrace line in this message but couldn't think of a simple way to do that. Thinking about it some more, I've come up with a different approach that'll make that easy. I'll try to put up a PR later today with that fix.
myronmarston
added a commit
that referenced
this pull request
Mar 9, 2013
yujinakayama
pushed a commit
to yujinakayama/rspec-monorepo
that referenced
this pull request
Oct 6, 2021
Clear let/subject memoization when referenced in before(:all). --- This commit was imported from rspec/rspec-core@f071280.
yujinakayama
pushed a commit
to yujinakayama/rspec-monorepo
that referenced
this pull request
Oct 6, 2021
…re#821, rspec/rspec-core#813, rspec/rspec-core#811, and rspec/rspec-core#802. [ci skip] --- This commit was imported from rspec/rspec-core@82869df.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #802.