Synchronize `rspec spec` and `rake spec` output #838

Merged
merged 1 commit into from Apr 6, 2013

Conversation

Projects
None yet
2 participants
Contributor

sorentwo commented Mar 20, 2013

By removing the rake spec short circuiting the output between
invocation methods matches more closely.

Fixes rspec/rspec-core#812

Synchronize `rspec spec` and `rake spec` output
By removing the `rake spec` short circuiting the output between
invocation methods matches more closely.

Fixes rspec/rspec-core#812
Owner

JonRowe commented Apr 6, 2013

This seems a reasonable approach to synchronising the two outputs; we should let the main RSpec runner handle the scenario of no files, and let it notify users about any supplied pattern. I ran this myself from master on 1.9.2 and it passes so I'm assuming the failure is a Travis heisenbug.

JonRowe added a commit that referenced this pull request Apr 6, 2013

Merge pull request #838 from sorentwo/sync-rake-spec-output
Synchronize `rspec spec` and `rake spec` output

@JonRowe JonRowe merged commit ab1fd53 into rspec:master Apr 6, 2013

1 check failed

default The Travis build failed
Details
Owner

JonRowe commented Apr 6, 2013

Thanks @sorentwo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment