Stop skipping parts of the build on non-MRI rubies. #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Historically we did this because of travis build speeds. However, recent build changes (including travis’s new container infrastructure and bundler caching) have greatly improved the speed of builds and I’m hopeful we can do the full build on all rubies now. The main slowness on non-MRI rubies is the cucumber features, anyway, since they frequently shell out and start a new ruby interpreter which is slow on non-MRI rubies. We still skip the rspec-rails build as we don’t build rspec-rails against non-MRI rubies, though.
myronmarston
force-pushed
the
dont_limit_full_build_to_mri
branch
from
6a68011
to
18d9bea
Compare
It appears that `bundle install` on JRuby in 2.0 mode runs very, very slow. Timing it will help us see if that is actually going on.
It appears to be much, much slower. For example, for rspec-support, the JRuby builds for 1.8 and 1.9 modes were 3:26 and 3:51, but 9:44 for 2.0 mode. There is similar slowness for the other repos.
myronmarston
force-pushed
the
dont_limit_full_build_to_mri
branch
from
2941c17
to
ee889a3
Compare
|
Hmm, I can't seem to get it to skip other spec suites on JRuby 2.0 mode, where it takes much longer for some reason :(. This isn't terribly important so I may just close it but I'll leave it for at least overnight. |
|
Closing. Since JRuby in 2.0 mode is performing poorly with these changes and I haven't figured out a good work around. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Historically we did this because of travis build speeds.
However, recent build changes (including travis’s new
container infrastructure and bundler caching) have
greatly improved the speed of builds and I’m hopeful
we can do the full build on all rubies now. The main
slowness on non-MRI rubies is the cucumber features,
anyway, since they frequently shell out and start
a new ruby interpreter which is slow on non-MRI
rubies.