Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Comparing changes

Choose two branches to see what's changed or to start a new pull request. If you need to, you can also compare across forks.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also compare across forks.
base fork: rspec/rspec-expectations
...
head fork: rspec/rspec-expectations
Checking mergeability… Don't worry, you can still create the pull request.
Commits on May 30, 2013
@JonRowe JonRowe describe behaviour bf15a4d
@JonRowe JonRowe fail with warning when calling private messages 518f6a9
@JonRowe JonRowe handle 1.8.7 syntax 71d1262
@JonRowe JonRowe raising an error on private method calls d51ddf7
@JonRowe JonRowe refactor 187 support ea78020
@JonRowe JonRowe make the feature more concise 148cc99
@JonRowe JonRowe performance tweak f519301
@JonRowe JonRowe refactor spec layout 23c96a6
@JonRowe JonRowe throw a proper error rather than runtime error dc32c7b
@JonRowe JonRowe for lulz ff9ec78
@JonRowe JonRowe Merge pull request #207 from JonRowe/expect_private_methods_to_be_pri…
…vate

Make be_predicate fail upon calling a private method
0409804
@JonRowe JonRowe RBX seems flakey again so... ahem... #yolo
We should look for a fix for this on core as well :/
c71f533
Commits on Jun 01, 2013
@JonRowe JonRowe Update comment to say 1.8.7 e43167a
Commits on Jun 04, 2013
@alindeman alindeman Prefers displaying expected values using `#inspect`.
* `#description` is only used for matchers.

[Fixes #260]

Signed-off-by: Andy Lindeman <alindeman@gmail.com>
Signed-off-by: Sam Phippen <samphippen@googlemail.com>
9f1aff2
Commits on Jun 05, 2013
@alindeman alindeman Removes explicit return d9dd494
@alindeman alindeman Changelog for #260 d248fd9
@alindeman alindeman Merge branch 'issue-260-matcher-description' ed83978
@ktns ktns Make expect(a).to be_within(x).percent_of(y) work with negative y d249498
@samphippen samphippen Merge pull request #266 from ktns/master
be_within(x).percent_of(y) with negative y
6b1a8a4
@samphippen samphippen Add a changelog entry for #266.
[ci skip]

Signed-off-by: Sam Phippen <samphippen@googlemail.com>
f7f6871
Commits on Jun 06, 2013
@JonRowe JonRowe setup coveralls dedc218
@JonRowe JonRowe badge readme fcc7835
@JonRowe JonRowe configure simplecov through coveralls 4efb95d
@JonRowe JonRowe tweaked setup 9166e90
@JonRowe JonRowe Merge pull request #265 from JonRowe/setup_coveralls
Setting up coveralls...
d36e526
Commits on Jun 08, 2013
@phiggins phiggins Add docs for failure message as proc object. ca86c3a
@JonRowe JonRowe merge coveralls c1de4a8
@JonRowe JonRowe Merge pull request #267 from JonRowe/tweak_coveralls
Tweaking Coveralls Setup
a6ae121
@JonRowe JonRowe make myrons improvements 54ef232
Commits on Jun 09, 2013
@myronmarston myronmarston Tweak coveralls.
- Remove coveralls rescue.
- Use `wear!` instead of `wear_merged!`.
2fb6403
@hugobarauna hugobarauna Fix indentation 9b195db
@alindeman alindeman Merge pull request #269 from hugobarauna/patch-1
Fix indentation
3de4f63
Commits on Jun 10, 2013
@JonRowe JonRowe Merge pull request #257 from phiggins/add_docs_for_proc_failure_message
Add docs for failure message as proc object.
a6bf971
Commits on Jun 13, 2013
@JonRowe JonRowe remove array extension e7ce0d6
@JonRowe JonRowe remove public method corrector bb75e3d
@JonRowe JonRowe remove method owner workaround 33c4266
@JonRowe JonRowe remove instance_eval_with_args 7e4ac22
@JonRowe JonRowe document dropping 1.8.6 support a01f092
Commits on Jun 14, 2013
@JonRowe JonRowe simplecov cannot be required on 1.8.7 99d8efa
@JonRowe JonRowe Merge pull request #271 from rspec/remove_186_support
Remove 186 support
9c19bdf
@JonRowe JonRowe Merge pull request #268 from rspec/coveralls_tweaks
Tweak coveralls.
c6fa20d
Commits on Jun 28, 2013
@JonRowe JonRowe reference running example as self 6b48dee
@JonRowe JonRowe access running example via yielded value 7c80a56
@JonRowe JonRowe Merge pull request #275 from rspec/fix_accessing_running_example_exam…
…ples

Access running example without `example`
060070f
@JonRowe JonRowe Run tests using the client mode JVM (or as close as we can get to it) d59c439
@JonRowe JonRowe Merge pull request #274 from rspec/faster_jruby_builds
Run tests using the client mode JVM (or as close as we can get to it)
d94947c
Commits on Jul 01, 2013
@Nerian Nerian fix typo ffd3085
@alindeman alindeman Merge pull request #281 from Nerian/typo
fix typo
5e234db
@samphippen samphippen Make the be_predicate matcher work when composed with change.
Signed-off-by: Sam Phippen <samphippen@googlemail.com>
39737d7
@samphippen samphippen Remove an extraneous whitespace in be.rb
Signed-off-by: Sam Phippen <samphippen@googlemail.com>
af41256
@samphippen samphippen Fix some whitespace in change_spec.rb
Signed-off-by: Sam Phippen <samphippen@googlemail.com>
6e5df05
@samphippen samphippen Add a passing change/be_predicate spec.
Signed-off-by: Sam Phippen <samphippen@googlemail.com>
71a73d8
@samphippen samphippen Use description instead of the matcher in failure_message_for_expecte…
…d_after.

Signed-off-by: Sam Phippen <samphippen@googlemail.com>
4b7254d
@samphippen samphippen Merge pull request #277 from samphippen/fix-276
Make it possible for be_predicate matcher to fail on chained expect.
d11f1a9
@samphippen samphippen Add a changelog entry for #277
[ci skip]

Signed-off-by: Sam Phippen <samphippen@googlemail.com>
8a02a67
Commits on Jul 05, 2013
@samphippen samphippen Remove the deprecated `be_close` matcher.
Signed-off-by: Sam Phippen <samphippen@googlemail.com>
a00be5b
@myronmarston myronmarston Merge pull request #282 from samphippen/remove_be_close
Remove the deprecated `be_close` matcher.
2df8e0a
Commits on Jul 07, 2013
@myronmarston myronmarston Update changelog to reflect 2.14.0 release.
[ci skip]
4b9df44
@myronmarston myronmarston Master is 3.0.0.pre now. feeb27d
@samphippen samphippen Rename be_true and be_false to be_truthy and be_falsey.
Signed-off-by: Sam Phippen <samphippen@googlemail.com>
860ca42
@alindeman alindeman Works around Rubinius bug ee45a69
@alindeman alindeman Uses string messages for errors edd3863
@alindeman alindeman rbx build is green; let us try to keep it that way aa473cd
Commits on Jul 08, 2013
@alindeman alindeman Revert "rbx build is green; let us try to keep it that way"
This reverts commit aa473cd.
f68049d
Commits on Jul 14, 2013
@razielgn razielgn Prolong aruba timeout to 60 even on Rubinius. 6fce0c2
@razielgn razielgn Disable Rubinius' JIT when running aruba tests. bce6d15
Commits on Jul 15, 2013
@JonRowe JonRowe Merge pull request #287 from razielgn/rbx-changes
 Improve Rubinius support in aruba tests.
98ec7f5
@cupakromer cupakromer Fully embrace _exec over _eval 771ca66
@alindeman alindeman Merge pull request #290 from cupakromer/move-to-exec
Fully embrace _exec over _eval
8a94d18
Commits on Jul 19, 2013
@myronmarston myronmarston Return `nil` from the block used by the yield matchers.
This indicates they don't have a meaningful return value.
Before, they returned an array.
931c318
@myronmarston myronmarston Merge pull request #292 from rspec/yield_matcher_should_not_return_value
Return `nil` from the block used by the yield matchers.
b43952f
Commits on Jul 21, 2013
@hugobarauna hugobarauna Remove have(n).items matchers
Those mastchers will be maintained by Hugo Barauna in a external
gem.
8f39d44
@samphippen samphippen Merge branch 'change-be-true-false-to-truthy-falsey' of https://githu…
…b.com/samphippen/rspec-expectations into change-be-true-false-to-truthy-falsey
478633a
@samphippen samphippen Alias be_falsy to be_falsey.
Signed-off-by: Sam Phippen <samphippen@googlemail.com>
4e4ef45
Commits on Jul 22, 2013
@samphippen samphippen Merge pull request #284 from samphippen/change-be-true-false-to-truth…
…y-falsey

Rename be_true and be_false to be_truthy and be_falsey.
42d0bb8
Commits on Jul 23, 2013
@myronmarston myronmarston Change failure message for truthy and falsey matchers. 1de7871
@JonRowe JonRowe Merge pull request #297 from rspec/be_truthy_refinements_for_master
Change failure message for truthy and falsey matchers.
b303274
Commits on Jul 28, 2013
@JonRowe JonRowe rspec-expectations is always loaded from source via `gemspec` a17d97c
Commits on Aug 01, 2013
@JonRowe JonRowe ensure we can diff encoded hashes with ascii compatible hashes 1d1ffd3
@JonRowe JonRowe fix expectation on 187
Conflicts:
	spec/rspec/expectations/differ_spec.rb
62ca6d8
@JonRowe JonRowe break up pp line for readability 47fe4cd
@yujinakayama yujinakayama Support do..end style block with raise_error matcher
Currently raise_error matcher accepts only {..} style blocks,
because {..} blocks have higher precedence over do..end blocks.
This is a common pitfall.

expect { do_something }.to raise_error do |error|
  expect(error.some_value).to eq(1)
end

In this case, the do..end block is taken by the #to method
and the #raise_error gets no block.

This patch makes raise_error matcher to use the block passed
from #to if it did not take any block directly.
b0df827
Commits on Aug 02, 2013
@JonRowe JonRowe comment explaining PP 56d9fe9
@JonRowe JonRowe tweak encoding spec c2bcc84
@JonRowe JonRowe Merge pull request #298 from rspec/encoding_fix_for_193
Fix an encoding issue on 1.9.3 when diffing hashes
8611acf
Commits on Aug 07, 2013
@andyh andyh Fix example description for match_array 7b4baa8
@andyh andyh Amend documentation to prefer match_array over =~
Update operators feature to refer to match_array instead of =~ operator
and added additional examples to READMEs to surface the existence of
match_array
ffc9b35
@andyh andyh Update the wording for recommending the use of match_array
Fix another typo in the preceding sentence
43f9d6f
@myronmarston myronmarston Merge pull request #302 from andyh/document-match-array
Amend documentation to prefer match_array over =~
cd237c7
@myronmarston myronmarston Merge pull request #301 from andyh/fix-match-array-description
Fix example description for match_array
58f2d36
Commits on Aug 08, 2013
@samphippen samphippen Merge pull request #295 from yujinakayama/raise_error-with-do-end-block
Support do..end style block with raise_error matcher
dd5ee3a
@samphippen samphippen Add a changelog entry for #295.
Signed-off-by: Sam Phippen <samphippen@googlemail.com>
d712787
Commits on Aug 09, 2013
@myronmarston myronmarston Update changelog with 2.14.1 release notes.
[ci skip]
096a162
@myronmarston myronmarston Update copyright and author.
[ci skip]
c28bb58
Commits on Aug 15, 2013
@myronmarston myronmarston Fix `be_<predicate>` to not support comparative chaining like `be` does. 64e04b9
@myronmarston myronmarston Fix change matcher to work properly with classes.
`SomeClass === SomeClass` returns false, unfortunately :(.
2221cf4
@myronmarston myronmarston Update changelog with 2.14.2 release notes. 9f1f6ed
Commits on Aug 17, 2013
@samphippen samphippen Use the --strict flag on cucumber in script/test_all
Signed-off-by: Sam Phippen <samphippen@googlemail.com>
a6820c0
@alindeman alindeman Merge pull request #306 from samphippen/cucumber-strict
Use the --strict flag on cucumber in script/test_all
ef49f11
@myronmarston myronmarston Merge pull request #293 from hugobarauna/remove-have-n-items-matchers
Remove have(n).items matchers
4ccacb8
Commits on Aug 18, 2013
@samphippen samphippen Remove expect {}.not_to raise_error(SomeSpecificClass)
Signed-off-by: Sam Phippen <samphippen@googlemail.com>
8d3f485
Commits on Aug 23, 2013
@myronmarston myronmarston Add caller_filter from rspec-core. 108f44e
@myronmarston myronmarston Fix load path search.
It worked fine before with a local bundler path, but not
a :git path -- the :git path includes the SHA in the
directory.
a55844a
@myronmarston myronmarston Merge pull request #310 from rspec/add_caller_filter
Add caller_filter from rspec-core.
da3c517
@myronmarston myronmarston Improve travis build.
* No need to bundle install twice.
* Skip one-by-one specs on JRuby.
* Run cucumber using our standalone bundle
  (rather than bundle exec).
* Bundler issue #2383 has been resolved,
  no need to work around it anymore.
4170eb2
@samphippen samphippen Clean up raise_error(SomeSpecificClass) specs/cukes. 6fb3978
@samphippen samphippen Improve the error message on raise_error(someclass).
Signed-off-by: Sam Phippen <samphippen@googlemail.com>
afd8631
@samphippen samphippen Remove ensured return and refactor a little in raise_error 6dadac6
@samphippen samphippen Be precise with negative raise_error removal specs.
Signed-off-by: Sam Phippen <samphippen@googlemail.com>
3d29f7f
@samphippen samphippen Clean up impelementation of `raise_error` a little more.
Signed-off-by: Sam Phippen <samphippen@googlemail.com>
3ae60e9
@samphippen samphippen Add a changelog entry for #294. 58ade10
@samphippen samphippen Merge pull request #294 from samphippen/remove-negative-raise-specifi…
…c-class

Remove expect {}.not_to raise_error(SomeSpecificClass)
c351332
@samphippen samphippen Clarify the changelog entry for #294. 2160e84
Commits on Aug 25, 2013
@blt04 blt04 Ensure OperatorMatcher works with overriden method
This forces OperatorMatcher to always use Object#method to return a
Method object, even if the instance overrides the method method.
7908411
Commits on Aug 26, 2013
@myronmarston myronmarston Update caller filter.
- Include additional libs.
- Don't put it at `rspec/caller_filter`.
- Ignore the "same content as rspec-core" spec for now.

The way I had this was brittle and is causing problems in rspec-core.
In rspec-core I'm trying to update the regex and add some specs but
the fact that the file is at the same path in all 3 libs (which seemed
like a simple way to ensure only one of them loads) is causing
the _wrong_ version to be loaded in rspec-core's specs, so that it's not
picking up the changes I've made.  Putting the file at the same
path in all 3 libs was a terrible idea in retrospect :(.
02c04c6
@myronmarston myronmarston Revert how we run cucumber.
It's causing a SystemStackError on 1.9.2.
I'm not sure why and don't have time to debug it now.
8687fb4
@myronmarston myronmarston Merge pull request #312 from rspec/improve_travis_build
Improve travis build.
aa4981d
@myronmarston myronmarston Fix require. 4d0dc31
@myronmarston myronmarston Update caller filter once more... 4982fcd
@myronmarston myronmarston Correct inaccurate docstring. be0c183
@myronmarston myronmarston Correct spec. 6d3543e
@myronmarston myronmarston Remove deprecated config. 404ae35
@JonRowe JonRowe Merge pull request #313 from blt04/operator-matcher-with-overriden-me…
…thod

Ensure OperatorMatcher works with overriden method
34ffee6
@JonRowe JonRowe Changelog for #313
[ci skip]
ee170c4
@JonRowe JonRowe port method handling code from mocks so we can use original definitio…
…n of method
4584aec
Commits on Aug 27, 2013
@myronmarston myronmarston Remove empty parens.
The "with no args" bit makes it clear that no
args should be passed. Using empty parens is
not very idiomatic.
9dd674c
@JonRowe JonRowe handle finding method handles for basic object 7385f7c
@JonRowe JonRowe restore fallback to method
note still won't work for `BasicObject`, that doesn't include `Kernel`
or an object that is based on `BasicObject`, includes `Kernel` but
redefines `method`.
0073842
@JonRowe JonRowe on ruby 2.0.0 cut straight to `Kernel.method` cbbdd3a
@JonRowe JonRowe prevent `BasicObject` specs from running on 1.8 a10c2a5
Commits on Aug 28, 2013
@JonRowe JonRowe Merge pull request #315 from rspec/port_mocks_method_handle
Refactor finding method handles
1b89b44
Commits on Sep 03, 2013
@JonRowe JonRowe Merge pull request #320 from rspec/fix_diff_of_keys_in_hash
Fix diffing of hashes with keys that aren't strings.
62036b6
Commits on Sep 05, 2013
@dchelimsky dchelimsky set full_backtrace false for backtrace filtering examples
Eliminates dependency on rspec-core's default configuration settings.
8a553b4
Commits on Sep 09, 2013
@JonRowe JonRowe fix operator matcher when operator is implemented via method_missing a75c8d3
@JonRowe JonRowe Merge pull request #323 from rspec/fix_operator_matcher_regression
Fix operator matcher when operator implemented via method_missing
461fdfd
Commits on Sep 13, 2013
@samphippen samphippen Add code to warn about the should syntax.
Signed-off-by: Sam Phippen <samphippen@googlemail.com>
dc8406b
Commits on Sep 14, 2013
@reyesyang reyesyang Remove redundant brackets 8c553c2
@JonRowe JonRowe Merge pull request #327 from reyesyang/patch-1
Remove redundant brackets
4c30276
Commits on Sep 20, 2013
@claudiob claudiob Add rspec-collection_matchers to the "Also see" links section.
Since rspec-collection_matchers was extracted from rspec-expectations and extends it, I think it makes sense to list
it in the "Also see" links at the bottom of the README
4622ddb
Commits on Sep 21, 2013
@JonRowe JonRowe Merge pull request #328 from claudiob/patch-1
Add rspec-collection_matchers to the "Also see" links section.
02c8989
@samphippen samphippen Add more specs and fix should syntax warning. 0b6af66
@samphippen samphippen Add a changelog entry for #326. 285a5aa
Commits on Sep 22, 2013
@myronmarston myronmarston Tweaks for deprecation of `:should` being enabled by default.
- Improve changelog (it's deprecated not disabled).
- Fix indentation.
- Prefer `.` to `::` for message sends.
- Ensure `configure_default_syntax` is called at the
  right time to prevent false-positive tests.
- Group the specs that rely on the default being
  configured so we can put that in a `before` hook.
- No need to configure the default in an `after` hook.
- Don't add helper methods to every object.
fe9ebc2
@myronmarston myronmarston Merge branch 'pr/326' 3ee77a8
Commits on Sep 23, 2013
@myronmarston myronmarston Update changelog with 2.14.3 release notes.
[ci skip]
983ce37
Commits on Sep 27, 2013
@myronmarston myronmarston Improve `in_sub_process` helper.
- Rescue all exceptions -- we always want to pass them back to the parent.
- Always close the read IO. (Before it only closed it if there was not an exception).
a74dee7
Commits on Oct 02, 2013
@myronmarston myronmarston Improve README a bit. c7e8424
Commits on Oct 03, 2013
@myronmarston myronmarston Prefer curlies to do-end for `expect { }.to raise_error`.
`do` and `end`, as English words, read funny in the middle
of the expectation expression.
8300bf8
@myronmarston myronmarston Refactor matcher_spec.
- Use a helper method to create the matchers, rather than
  `Matcher.new` + `for_expected`. I plan to rewrite the
  implementation of `Matcher` in a way that will require it
  to be instantiated differently and I having this helper
  method gives us only one place to update.
- Prefer `let` to `before(:each)` ivars.
- Define the module inline as a local; this avoids the need
  for the awkward `m = mod`.
3d0e865
@myronmarston myronmarston Address a few under specifications of custom matchers.
This will help with my upcoming refactoring.
eaf1c14
@myronmarston myronmarston Use `include` instead of `extend`.
In RSpec 3 the body of `define` will be a
class definition and the body of `match` (etc)
will be a method def, so using `extend` to make
a method available to the `match` block will
not work.
0ed7323
@myronmarston myronmarston Add pending specs for things that should work after matcher refactoring. fa3e980
Commits on Oct 04, 2013
@myronmarston myronmarston Rewrite custom matcher DSL.
Rather than evaling the `define` block in the
context of the matcher instance, eval the `define`
block in the context of the matcher instance's
singleton class.

* Fixes #272.
  `include` in `define` has a different meaning (module inclusion)
  than `include` in the `match` block (using the `include` matcher to
  match).
* Better solution than #194
  for #188. There's now
  a `match` class method and a `match` instance method.
* Completely avoids issues we had to use hacks to solve before:
  #29,
  #38,
  fc4b66d
ec0094c
@myronmarston myronmarston Ensure helper methods can be accessed from the macro blocks. 6617bfc
@myronmarston myronmarston Use singleton classes rather than dup'ing the matcher class. 1d5c7f4
@myronmarston myronmarston Assign the matcher subclass to a human readable const.
This helps provides useful `#inspect` output.
28d715e
@myronmarston myronmarston Compile the user's block directly to a method.
- This makes the "this macro method defines a
  method" abstraction less leaky.
- It allows constructs like an early `return`
  to be used from within the block.
- It puts all user refs into a common module.
f5cd114
@myronmarston myronmarston Allow `chain` blocks to accept blocks. c05616e
@myronmarston myronmarston Use `respond_to_missing?` on 1.9+. 63cdacc
@myronmarston myronmarston Improve docs. e57fc6d
@myronmarston myronmarston Make matcher constant assignment more robust.
JRuby and Rubinius apparently don't handle
non-ascii in const names.
e9490b0
@myronmarston myronmarston `for_expected` doesn't really serve a purpose here. ec61662
@myronmarston myronmarston Add changelog for recent custom matcher changes.
[ci skip]
9e05e56
@myronmarston myronmarston Remove misleading docs.
They claim you can't use `match` matcher within` match` block,
but this now works.
805fe7c
Commits on Oct 05, 2013
@benmoss benmoss Update cukes to new syntax d384ac4
Commits on Oct 06, 2013
@JonRowe JonRowe Merge pull request #334 from benmoss/update_features_expect_syntax
Update cukes to new syntax
adac6f0
@myronmarston myronmarston `Specify` reads better than `it` here. 2853c8e
@myronmarston myronmarston Align comments. cc5b63c
@myronmarston myronmarston Remove reference to old `should` syntax. 990084f
@myronmarston myronmarston Reduce syntactic noisiness. a65f8a6
@myronmarston myronmarston `==` can't be chained off of `expect`. ac2293f
@JonRowe JonRowe update operator matcher feature 5bb13f0
Commits on Oct 07, 2013
@myronmarston myronmarston No need for the ellipses. 44c9d56
@myronmarston myronmarston We're trying to get away from run-time extensions.
Actually, it probably doesn't matter much here,
since we are doing other things there that
are likely to blow away the method cache, but
we might as well avoid one more runtime extension.
1a5e7d5
@myronmarston myronmarston Add explanatory comment. 1fa9651
@myronmarston myronmarston It's "capital", not "capitol". 08eda0c
@myronmarston myronmarston Add deprecation notice to API docs for `match_regex`. 9239370
@myronmarston myronmarston Remove docs showing deprecated using of `raise_error`. 90f45cb
@JonRowe JonRowe make match diffable 747dcbf
@JonRowe JonRowe changelog entry
[skip ci]
415bfe2
@JonRowe JonRowe Merge pull request #333 from rspec/make_match_diffable
expect().to match does not give a diff when failing
4c47e4c
Commits on Oct 09, 2013
@myronmarston myronmarston Merge pull request #332 from rspec/refactor_matcher_dsl
Rewrite custom matcher DSL
42df8d3
@JonRowe JonRowe rewrite matcher cukes for operator/comparison and match_array 4a7b97c
Commits on Oct 10, 2013
@myronmarston myronmarston Merge pull request #336 from rspec/update_operator_matcher_feature
Operator matcher cuke needs to be rewritten/reorganized
a7663be
@myronmarston myronmarston Improve constant assignment to handle numbers better.
Before, a matcher like `has_4_things` would get
assigned a constant like `Has_4Things`.  Now it gets
`Has4Things`.
e8aa905
@myronmarston myronmarston Merge pull request #339 from rspec/fix-matcher-constant
Improve constant assignment to handle numbers better.
3283b76
@JonRowe JonRowe show example of undefined encoding problem, fix with a backup encode d428634
@JonRowe JonRowe fixup a typo 2133f4d
@JonRowe JonRowe pick encoding smarter, and have a fallback to UTF-8 761085d
Commits on Oct 12, 2013
@myronmarston myronmarston Update gemspec.
[ci skip]
dc957fa
Commits on Oct 15, 2013
@myronmarston myronmarston Add benchmarks for the new implementation of the custom matcher DSL.
Results are includde for:

- MRI 2.0.0, MRI 1.9.3, JRuby 1.7.4
- Against 2.14.3, 3.0.0.pre before matcher DSL rewrite, 3.0.0.pre after matcher DSL rewrite

Conclusions:

* Getting an instance of a custom matcher was insanely slow in 2.x,
  and it looks like the `making_declared_methods_public` hack for 1.8.6
  was the primary source of that. Without that, getting an instance of
  a matcher is ~20x faster. To see what changed between 2.14.3 and
  the commit used for this benchmark, go to:
  v2.14.3...4c47e4c#diff-a51020971ade2c87f1d5b93f20d711c7L6
* With our new custom matcher DSL, using a matcher is approximately
  the same perf. However, defining a matcher is about 10x slower
  (since it defines a subclass) while getting an instance of
  an already defined matcher is about 10x faster.

Overall, I think this is a net win, because users almost certainly
use existing matchers more often then they define them.  (The exception
would be if they define custom matchers they don't use, but that
would be very odd).

Closes #338.
3822c60
@myronmarston myronmarston Do away with subclassing and constant assignment.
It makes defining a matcher much faster.
247f884
@myronmarston myronmarston Re-run benchmarks based on the refactoring of the last commit.
Notice that defining a custom matcher is 10+ times faster!
0e9f82f
Commits on Oct 16, 2013
@JonRowe JonRowe Merge pull request #340 from rspec/add_matcher_dsl_benchmark
Add benchmarks for the new implementation of the custom matcher DSL.
28841c3
Commits on Oct 17, 2013
@JonRowe JonRowe add support gem a55b3dc
Commits on Oct 20, 2013
@JonRowe JonRowe switch to support for warnings 1617025
@JonRowe JonRowe remove old file 3993330
Commits on Oct 21, 2013
@JonRowe JonRowe Set versions properly e2c2484
@myronmarston myronmarston Merge pull request #342 from rspec/use_warnings_from_support
Use rspec-support for warnings
6464797
Commits on Oct 24, 2013
@JonRowe JonRowe allow supression of local repos cd17e5e
@JonRowe JonRowe Merge pull request #343 from rspec/allow_supression_of_local_repos
Allow suppression of local repos
d3277fd
Commits on Nov 03, 2013
@myronmarston myronmarston Avoid `useless use of == in avoid context` warning.
…by calling a method on the result.
It's a hack but it'll help us to keep rspec-expectations warning free.
35e1924
@myronmarston myronmarston Lock mime types to version that works on 1.8. dfc59b5
@xaviershay xaviershay Merge pull request #346 from rspec/avoid-uselss-use-in-void-context-w…
…arning

Avoid `useless use of == in avoid context` warning.
448ff97
Commits on Nov 05, 2013
@xaviershay xaviershay Consistent formatting of changelog. 678a57c
@myronmarston myronmarston Merge pull request #350 from rspec/changelog-tidy
Consistent formatting of changelog.
c2c7441
@samphippen samphippen Add a with_message to the raise_error matcher 1b23c65
Commits on Nov 06, 2013
@JonRowe JonRowe Changelog entry
[skip ci]
66fc692
@JonRowe JonRowe Merge pull request #330 from rspec/handle_undefined_encoding_conversions
Handle undefined encoding conversions
c3dc2b2
@JonRowe JonRowe Check generated object strings have matching encoding.
PP is yet again return US-ASCII when it shouldn't. Fixes #324
11935f4
@JonRowe JonRowe Merge pull request #325 from rspec/fix_encoding_comparison_of_objects
Force generated object strings to have matching encoding.
70a6291
@myronmarston myronmarston Update changelog with 2.14.4 release info.
[ci skip]
3e12ec5
Commits on Nov 07, 2013
@samphippen samphippen remove redundant double raise 0a29ca1
@myronmarston myronmarston Improve deprecation warning message.
rspec-mocks issues a similar warning so it's useful
to clarify that this is from rspec-expectations.
34f93b9
@samphippen samphippen Add a changelog entry and a cuke for 66d2e59
@xaviershay xaviershay Merge pull request #353 from rspec/with_message-on-raise-error
Adds `with_message` to the `raise_error` matcher
d7086f5
@myronmarston myronmarston Update changelog with 2.99.0.beta1 release notes.
[ci skip]
e5ef7cb
Commits on Nov 08, 2013
@myronmarston myronmarston Setup gem signing 9a98d6e
@myronmarston myronmarston Update changelog for 3.0.0.beta1 release [ci skip] 3d77acc
@myronmarston myronmarston Release 3.0.0.beta1 311b60b