Diffable include matcher #49

Closed
msassak opened this Issue Dec 10, 2010 · 5 comments

Projects

None yet

2 participants

@msassak
msassak commented Dec 10, 2010

Currently the include matcher doesn't diff strings on failure like other matchers used to compare strings. This behavior was surprising to me. Is there a reason not to change it? I'd be willing to help get this done.

@dchelimsky
Member

I don't remember if there's a reason not to. Can't think of one now. Let's assume it was oversight and feel free to patch it.

@msassak
msassak commented Dec 11, 2010

Changes are at msassak/rspec-expectations@3f21bfb. If that's acceptable then I'll write a cuke or two for it and send you a pull request.

@dchelimsky
Member

Looks good. Cuke away.

@dchelimsky
Member

I'm actually going to grab this to include in the rspec-2.3.0 release. I can add the cukes later.

@msassak
msassak commented Dec 11, 2010

Define include matcher as diffable

Modify the specs so they match output rather than specify it exactly.

@kchien kchien pushed a commit to kchien/rspec-expectations that referenced this issue Mar 7, 2014
@msassak msassak Define include matcher as diffable
Modify the specs so they match output rather than specify it exactly.

- Closes #49.
e4921ca
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment