Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix RuboCop offences #1104
I've kept the commits separate for easier review, with descriptive commit messages where I had to make a decision that needs explanation.
Tried to keep the changes minimal, picking the style matching the code the most (specifically with %-literals and spaces inside brackets).
RuboCop version update is better to be done simultaneously with the other rspec-* repositories since a number of rules are changed/renamed/removed, so I decided not to do that in the scope of this pull request.
benoittgt left a comment
I am not sure various
I would have added the link to the update/pr or specified version when disabling a Cop. For example here:
self.a_method_not_in_the_example == "method defined in the example" # rubocop:disable Style/RedundantSelf RuboCop bug, should disappear on version update.
Like you did here
# rubocop:disable Layout/EmptyLinesAroundArguments This is a RuboCop bug, and it's fixed in 0.65.0
But as the first point, this is not a blocker to accept this PR.
Lot's of work.
@benoittgt Thanks for the review.
My further plan is to:
I'll stick to the practice I used here with the other repositories - reduce the code churn and disable the rules that would require massive codebase change.