Color diff improvements #168

Closed
wants to merge 7 commits into
from

Projects

None yet

3 participants

@alexcoplan

Some improvements to the way diff coloring is done - code is now more succinct and readable. Also have updated the config in matchers to use the same method on RSpec.configuration if RSpec::Core is available.

@travisbot

This pull request passes (merged 08a26ae into d427bac).

@alexcoplan

sorry about the excessive number of commits here!

@travisbot

This pull request passes (merged 4f2c4c4 into d427bac).

@travisbot

This pull request fails (merged dac5852 into d427bac).

@travisbot

This pull request passes (merged c54aeae into d427bac).

@travisbot

This pull request fails (merged 2e4be7e into d427bac).

@alexcoplan

@travisbot what happened there? Exit code 1 with no error message??

@alexcoplan

Will close this pull request due to the number of commits (and travis getting confused?) and make another.

@alexcoplan alexcoplan closed this Aug 25, 2012
@myronmarston
RSpec member

@alexcoplan -- for future reference, you can rebase and force push to the same branch when you have a case like this. No need to open a separate pull request just to fix up your commits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment