Use optimized require #488

Merged
merged 3 commits into from Mar 2, 2014

Conversation

Projects
None yet
2 participants
@myronmarston
Owner

myronmarston commented Mar 2, 2014

No description provided.

module RSpec
- module Matchers
+ module Expectations

This comment has been minimized.

Show comment Hide comment
@JonRowe

JonRowe Mar 2, 2014

Owner

Is this technically a breaking change?

@JonRowe

JonRowe Mar 2, 2014

Owner

Is this technically a breaking change?

This comment has been minimized.

Show comment Hide comment
@myronmarston

myronmarston Mar 2, 2014

Owner

Yep, good point. I'll add it to the changelog and work on a 2.99 deprecation.

@myronmarston

myronmarston Mar 2, 2014

Owner

Yep, good point. I'll add it to the changelog and work on a 2.99 deprecation.

@JonRowe

This comment has been minimized.

Show comment Hide comment
@JonRowe

JonRowe Mar 2, 2014

Owner

LGTM apart from the constant change for configuration...

Owner

JonRowe commented Mar 2, 2014

LGTM apart from the constant change for configuration...

myronmarston added some commits Mar 2, 2014

Move configuration class from matchers to expectations.
- It's general config for rspec-expectations, not
  just for the matchers and fits better there.
- This allows us to cleanup some odd cross-requires
  where rspec/expectations files were requiring
  rspec/matchers files and vice-versa.
- The attribute for this remains on RSpec::Matchers
  because that's where rspec-core looks for it and
  that's been the public API.

myronmarston added a commit that referenced this pull request Mar 2, 2014

@myronmarston myronmarston merged commit a0b7f09 into master Mar 2, 2014

@myronmarston myronmarston deleted the use-optimized-require branch Mar 2, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment