Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Pr 600 followups #609

merged 4 commits into from Jul 23, 2014


None yet
2 participants

myronmarston commented Jul 23, 2014

These are a few followups to #600.

/cc @oveddan

myronmarston added some commits Jul 23, 2014

Use a new config instance for these specs.
- Makes the `it "is false by default"` spec more accurate (as a new
  instance demonstrates the default more accurately then manually
  setting it to `nil`).
- Prevents the changes here from "leaking" into other specs;
  previously, the mutation to the global config could affect
  other specs.
Set the `include_chain_clauses...` config globally.
This is more desirable behavior and will be the
default in RSpec 4.

oveddan commented Jul 23, 2014

@myronmarston This is great - especially how in the specs the option is defaulted to be true, but can be opted out of. The shared_context include_chain_clauses_in_custom_matcher_descriptions for opting out of that option is great too.

myronmarston added a commit that referenced this pull request Jul 23, 2014

@myronmarston myronmarston merged commit 099d882 into master Jul 23, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed

@myronmarston myronmarston deleted the pr-600-fixups branch Jul 23, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment