Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add define_negated_matcher #618

Merged
merged 2 commits into from Aug 7, 2014
Merged

Add define_negated_matcher #618

merged 2 commits into from Aug 7, 2014

Conversation

@myronmarston
Copy link
Member

@myronmarston myronmarston commented Aug 7, 2014

This replaces #547.
Fixes #527.
Fixes #493.

We had undefined them to support aliases of the `be`
matchers, but this makes `==` behave wrongly.
This replaces #547.
Fixes #527.
Fixes #493.
@JonRowe
Copy link
Member

@JonRowe JonRowe commented Aug 7, 2014

LGTM

@@ -241,17 +243,38 @@ module Matchers
# @!macro [attach] alias_matcher
# @!parse
# alias $1 $2
def self.alias_matcher(new_name, old_name, &description_override)
def self.alias_matcher(new_name, old_name, options={}, &description_override)

This comment has been minimized.

@JonRowe

JonRowe Aug 7, 2014
Member

Is the description_override block worth documenting in the feature?

This comment has been minimized.

@myronmarston

myronmarston Aug 7, 2014
Author Member

It's documented in the YARD docs and I think that's sufficient. I view it as an advanced API thing and not a normal use case.

myronmarston added a commit that referenced this pull request Aug 7, 2014
Add `define_negated_matcher`
@myronmarston myronmarston merged commit 1dd6f86 into master Aug 7, 2014
1 check passed
1 check passed
continuous-integration/travis-ci The Travis CI build passed
Details
@myronmarston myronmarston deleted the pr-547-fixed-up branch Aug 7, 2014
@yelled3
Copy link

@yelled3 yelled3 commented Aug 7, 2014

@myronmarston really happy with the way this turned out :-)

Good job!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants