Skip to content
Commits on Feb 17, 2014
  1. @alindeman
Commits on Feb 11, 2014
  1. @JonRowe

    Merge pull request #573 from rspec/update-travis-build-scripts-2014-0…

    …2-12-for-master
    
    Updates from rspec-dev (2014-02-12)
    JonRowe committed Feb 12, 2014
  2. @JonRowe
Commits on Feb 10, 2014
  1. @myronmarston

    Use skip instead of pending.

    The semantics of pending have changed in rspec-core.
    myronmarston committed Feb 10, 2014
  2. @myronmarston

    Merge pull request #568 from rspec/update-travis-build-scripts-2014-0…

    …2-10-for-master
    
    Updates from rspec-dev (2014-02-10)
    myronmarston committed Feb 10, 2014
  3. @myronmarston
Commits on Feb 8, 2014
  1. @JonRowe

    Merge pull request #562 from rspec/update-travis-build-scripts-2014-0…

    …2-08-for-master
    
    Updates from rspec-dev (2014-02-08)
    JonRowe committed Feb 8, 2014
  2. @JonRowe
Commits on Feb 7, 2014
  1. @JonRowe

    Merge pull request #561 from yujinakayama/remove-and_return-without-args

    Remove support for `and_return { value }`
    JonRowe committed Feb 8, 2014
  2. @yujinakayama
  3. @yujinakayama
Commits on Feb 1, 2014
  1. @myronmarston

    Update changelog with 2.14.5 release notes.

    [ci skip]
    myronmarston committed Feb 1, 2014
  2. @JonRowe

    Merge pull request #553 from rspec/add-spec-for-issue-549

    Add regression spec for #549.
    JonRowe committed Feb 1, 2014
  3. @myronmarston

    Add regression spec for #549.

    This is already fixed in 3.0 but it's good to add
    a spec to prevent future regressions.
    myronmarston committed Jan 31, 2014
Commits on Jan 31, 2014
  1. @myronmarston

    Merge pull request #548 from rspec/improve-method-signature

    Improve method signature / argument validation
    myronmarston committed Jan 30, 2014
  2. @JonRowe

    changelog for #550

    [skip ci]
    JonRowe committed Jan 31, 2014
  3. @JonRowe

    Merge pull request #550 from mauricio/better-error-on-verifying-double

    RSpec::Mocks::NamedObjectReference doesn't have a name method, creating specific spec for this case so there are no false positives
    JonRowe committed Jan 30, 2014
  4. @mauricio

    RSpec::Mocks::NamedObjectReference doesn't have a name method, creati…

    …ng specific spec for this case so there are no false positives
    mauricio committed Jan 30, 2014
Commits on Jan 30, 2014
  1. @myronmarston
  2. @myronmarston

    Reword docstrings.

    I'm about to introduce a new `description` method
    and having docstrings say "it is described precisely"
    when not referring to the description is confusing.
    myronmarston committed Jan 29, 2014
  3. @myronmarston

    Refactor: make caller pass a signature object.

    This clears the way to use a slightly different
    signature implementation (e.g. for blocks).
    myronmarston committed Jan 29, 2014
  4. @myronmarston

    Rename method.

    It's a description of the arity so let's call it that.
    myronmarston committed Jan 29, 2014
Commits on Jan 29, 2014
  1. @myronmarston

    Update method names, etc to reflect our check is more than arity.

    Arity is just the number of arguments but we check
    more than that now, so it's good to reflect that.
    myronmarston committed Jan 29, 2014
  2. @myronmarston

    `error` => `error_message`

    It's not a ruby error object, it's just the message,
    so the new name is more accurate.
    myronmarston committed Jan 29, 2014
  3. @myronmarston
  4. @myronmarston

    Don't mutate the provided args array.

    Mutating could lead to surprises for the caller.
    myronmarston committed Jan 29, 2014
  5. @myronmarston

    We can't count on `is_a?` working on every argument.

    BasicObject, for example, does not respond to it.
    It's safer to use `SomeClass === obj` than `obj.is_a?(SomeClass)`.
    myronmarston committed Jan 29, 2014
  6. @myronmarston
  7. @myronmarston

    Refactor: prep for supporting `**kw_args`.

    To support `**kw_args`, `allowed_kw_args` will have
    to act like an infinite set. Rather than making the
    verifier (and any future clients) responsible for
    dealing with this special case, it's simpler to move
    the invalid/missing kw arg calculations into
    `MethodSignature`, where it can handle that special
    case internally.
    myronmarston committed Jan 29, 2014
  8. @myronmarston

    Decrease syntactic noise of argument lists.

    I find this:
    
    foo(nil, :a => 1)
    
    ...to be much less noisy than this:
    
    foo([nil, { :a => 1 }])
    
    The first form more closely matches how people pass args
    and kw args to methods, anyway.
    myronmarston committed Jan 29, 2014
  9. @myronmarston

    Clean up `split_args` a bit.

    - It was odd to have it memoize internally but accept an arg.
    - Simpler just to call it once in `initialize`.
    myronmarston committed Jan 29, 2014
  10. @myronmarston

    Add missing test.

    A last-arg hash should only be treated as kw args if the method has kw arg params.
    myronmarston committed Jan 28, 2014
  11. @myronmarston

    Refactoring: extract MethodSignature class.

    - The signature of a method is a concept in its own
      right and deserves to be represented as its own object.
    - This gives a clear delineaziation of responsibilities
      between extracting method signature info and verifying
      arguments against that info.
    - The new `classify_parameters` approach should perform
      a bit better than what we had before; it iterates over
      `method.parameters` once total where as before it would
      iterate over it 3 times.
    myronmarston committed Jan 28, 2014
  12. @myronmarston

    Standardize on kw_args over keyword_args.

    It's a bit shorter but still obvious what it means.
    myronmarston committed Jan 28, 2014
Commits on Jan 28, 2014
  1. @myronmarston

    Merge pull request #543 from rspec/issue-431

    Support keyword arguments when checking for valid arity.
    myronmarston committed Jan 28, 2014
Something went wrong with that request. Please try again.