Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

We’re showing branches in this repository, but you can also compare across forks.

base fork: rspec/rspec-mocks
...
head fork: rspec/rspec-mocks
This comparison is big! We're only showing the most recent 250 commits
Commits on Aug 12, 2014
Myron Marston myronmarston Updated travis build scripts (from rspec-dev) 79b1fc3
Myron Marston myronmarston Merge pull request #757 from rspec/update-travis-build-scripts-2014-0…
…8-12-for-master

Updates from rspec-dev (2014-08-12)
0ff71db
Commits on Aug 14, 2014
Myron Marston myronmarston Forwardport 3.0.4 release notes.
[ci skip]
09a1b64
Myron Marston myronmarston Fixup changelog a bit.
[ci skip]
1c947af
Commits on Aug 16, 2014
Jon Rowe JonRowe support thrice with at_least and at_most a008bff
Jon Rowe JonRowe support thrice for have_received 2830f89
Jon Rowe JonRowe support for thrice for any_instance d66bb73
Jon Rowe JonRowe changelog for #754
[skip ci]
b67badd
Commits on Aug 17, 2014
Jon Rowe JonRowe fixup specdoc
[skip ci]
6f857a3
Jon Rowe JonRowe Merge pull request #754 from rspec/more_thrice
More thrice
a85a787
Commits on Aug 19, 2014
Jon Rowe JonRowe remove mention of any_number_of_times in docs
[skip ci]
55cbdfc
Jon Rowe JonRowe remove any_instance usage of any_number_of_times
(which causes it to show up in docs)
37d78f9
Jon Rowe JonRowe changelog for #760
[skip ci]
39f9383
Jon Rowe JonRowe Merge pull request #760 from rspec/remove_mention_of_any_number_of_times
Remove mention of any_number_of_times
f8ae542
Aaron Kromer cupakromer Updated travis build scripts (from rspec-dev) 4469ecc
Commits on Aug 20, 2014
Aaron Kromer cupakromer Merge pull request #761 from rspec/update-travis-build-scripts-2014-0…
…8-19-for-master

Updates from rspec-dev (2014-08-19)
a175106
Commits on Aug 22, 2014
Myron Marston myronmarston Updated travis build scripts (from rspec-dev) c4ba32d
Myron Marston myronmarston Merge pull request #765 from rspec/update-travis-build-scripts-2014-0…
…8-22-for-master

Updates from rspec-dev (2014-08-22)
19f023d
Commits on Aug 23, 2014
Igor Kapkov igas Fix indentation in readme 8ba17ed
Jon Rowe JonRowe Merge pull request #766 from igas/patch-1
Fix indentation in readme
c93dd6b
Jon Rowe JonRowe create and_wrap_original 59915d5
Jon Rowe JonRowe cuke for wrapping original implementation a05ebbf
Commits on Aug 24, 2014
Myron Marston myronmarston Updated travis build scripts (from rspec-dev) c6b4829
Myron Marston myronmarston Merge pull request #767 from rspec/update-travis-build-scripts-2014-0…
…8-23-for-master

Updates from rspec-dev (2014-08-23)
1101ab3
Jon Rowe JonRowe Changelog for #762
[skip ci]
c0a1b61
Jon Rowe JonRowe Merge pull request #762 from rspec/and_wrap_original
Implement and_wrap_original
fd9cd38
Commits on Aug 27, 2014
Myron Marston myronmarston Disable the rspec-core DSL in the global scope. fab3227
Myron Marston myronmarston Merge pull request #768 from rspec/disable-global-dsl
Disable the rspec-core DSL in the global scope.
3f81146
Myron Marston myronmarston Fix ruby warning. 2e4bf38
Jon Rowe JonRowe Merge pull request #769 from rspec/fix-load-time-spec-warnings
Fix ruby warning.
a5de965
Commits on Aug 29, 2014
Myron Marston myronmarston Setup rubocop.
Closes #702.
a1b93d0
Myron Marston myronmarston Merge pull request #770 from rspec/setup-rubocop
Setup rubocop.
a32ecea
Commits on Sep 01, 2014
Eugene Kenny eugeneius Fix prepended module detection on Ruby 2.0
Ruby's behaviour when prepending a module to a singleton class differs
between 2.0 and 2.1. I wrote a test case to illustrate the differences:
https://gist.github.com/eugeneius/884873965f90092fc50c

On Ruby 2.1, the singleton class always appears in its own ancestors
chain. Prepended modules come before it, and included modules after it.
This is consistent with how the ancestors chain works for normal classes
and modules.

On Ruby 2.0, the singleton class only appears in its own ancestors chain
if a module has been prepended to it. This means we can't find the
prepended modules by just iterating over its ancestors until some
stopping condition. Right now included modules are being incorrectly
classified as prepended modules on Ruby 2.0 - I've included a spec here
capturing the bug that fails on master.

If the singleton class is not in its own ancestors chain, we know there
aren't any prepended modules, so we don't need to check for them. The
existing code works in all other cases.
364d7a7
Jon Rowe JonRowe Merge pull request #771 from eugeneius/fix_prepended_module_detection
Fix prepended module detection on Ruby 2.0
c3c44e0
Jon Rowe JonRowe changelog for #771
[skip ci]
c783627
Commits on Sep 02, 2014
Jon Rowe JonRowe spec out #745
(This has since been solved by #771).
689c133
Myron Marston myronmarston Refactor `prepended_modules_of_singleton_class`.
The `take_while` implementation was a bit obtuse.

It is simpler to just find the index of the singleton
class and then just return all ancestors before it. This
ensures that only modules which are prepended onto the
specific singleton class we are dealing with (and not the
singleton class of a superclass...) are considered, which was
the root of the problem causing #745.
536b66b
Jon Rowe JonRowe Merge pull request #773 from rspec/issue-771-followup
Issue 771 followup
f4293ba
Commits on Sep 05, 2014
Myron Marston myronmarston 3.1.0 release. 06fbd3d
Myron Marston myronmarston Bump version to 3.2.0.pre. 9e261ad
Commits on Sep 15, 2014
Tony Novak afn fixes #781 3db6ca7
Jon Rowe JonRowe Merge pull request #782 from amitree/master
Stubbing a method on any_instance_of(SomeModule) gives spurious error about prepended modules
63952ff
Jon Rowe JonRowe changelog for #781
[skip ci]
94dda94
Commits on Sep 18, 2014
Myron Marston myronmarston Fix regexp warnings on 1.8.7.
./spec/rspec/mocks/argument_matchers_spec.rb:277: warning: regexp has invalid interval
./spec/rspec/mocks/argument_matchers_spec.rb:277: warning: regexp has `}' without escape
./spec/rspec/mocks/argument_matchers_spec.rb:284: warning: regexp has invalid interval
./spec/rspec/mocks/argument_matchers_spec.rb:284: warning: regexp has `}' without escape
c4c85cc
Myron Marston myronmarston Merge pull request #785 from rspec/fix-regexp-warnings-on-1.8.7
Fix regexp warnings on 1.8.7.
0f2fd7c
Myron Marston myronmarston Skip spec warnings spec on 1.9.2.
We load psych and syck and they trigger warnings.
26f27b3
Myron Marston myronmarston Forwardport 3.1.1 release notes.
[ci skip]
7db36a6
Commits on Sep 21, 2014
Jon Rowe JonRowe raise an error when attempting to use allow(...).to have_received 01cf92e
Commits on Sep 22, 2014
Jon Rowe JonRowe tweak ws
[skip ci]
5b3d6ff
Jon Rowe JonRowe changelog for #788
[skip ci]
085d79a
Jon Rowe JonRowe Merge pull request #788 from rspec/error_for_allow_have_received
raise an error when attempting to use allow(...).to have_received
bc221e4
Commits on Sep 24, 2014
Daniel Doubrovkine (dB.) @dblockdotorg dblock Explicitly call out args passed into any_instance stubs. d3e6a4e
Myron Marston myronmarston Merge pull request #789 from dblock/explicitly-list-args
Explicitly call out args passed into any_instance stubs.
8f0a242
Commits on Sep 26, 2014
Jon Rowe JonRowe Updated travis build scripts (from rspec-dev) f873361
Myron Marston myronmarston Merge pull request #791 from rspec/update-travis-build-scripts-2014-0…
…9-26-for-master

Updates from rspec-dev (2014-09-26)
5868de1
Myron Marston myronmarston Forwardport 3.1.2 release notes. 06a490e
Commits on Sep 28, 2014
Myron Marston myronmarston Reorganize verified double specs.
The single `verifying_double_spec.rb` has gotten unwieldy and hard
to work with because it's so large. It's easier to work with smaller
spec files.

- Extract doubled class definitions into a support file.
- Move the method visibility specs into their own file.
- Move class/object/instance double specs into their own files.
- Move general verifying double construction specs into a separate file.
20a3ae3
Myron Marston myronmarston Make doc strings a bit more accurate. 683f911
Myron Marston myronmarston Rewrite verifying message expectation specs.
- Move them under `verified_doubles` sub directory.
- Use more of an integration style rather than a mock-based
  unit style.
- This is easier to work with; the other specs surprised
  me in that I had to explicitly expect the error generator
  not to receive a message in order to write a spec for the
  "allowed" case (since it was `as_null_object` it would not
  fail automatically). This surprised me when trying to add
  some new specs here.
- This also fixes the spec for the `any_args` case. The old spec
  did not fail when I temporarily removed the special `any_args`
  handling, because the expected method for that example accepts
  1 argument, and without the `any_args` special handling, it would
  naturally be treated as a single argument.
9ed0fe8
Myron Marston myronmarston Merge pull request #792 from rspec/reorganize-verifying-double-specs
Reorganize verifying double specs
7ef292c
Myron Marston myronmarston Improve wording of docstring. 59fbfd5
Commits on Oct 01, 2014
Jon Rowe JonRowe Correct error with have_received counts
* add triangulation example for have_received error
* rescue RSpec::Mocks::MockExpectationError when replaying expectations,
  we need to count them all.
edb39a8
Jon Rowe JonRowe Don't raise an expectation when counting in have_received 4197003
Jon Rowe JonRowe extend rubocop class definition 79d8ad6
Commits on Oct 02, 2014
Jon Rowe JonRowe changelog for #793
[skip ci]
b3f49e8
Jon Rowe JonRowe Merge pull request #793 from rspec/fix_issue_with_have_received_matcher
Wrong error message generated by have_received matcher when method was called 2 or more times than expected
9825dd5
Jon Rowe JonRowe fixup changelog after #793
[skip ci]
fe697fc
Commits on Oct 03, 2014
Piotr Jakubowski piotrj Add receive_messages to README
It took some digging to figure out that this method is available, so I guess it's good idea to have it in README.
5e6d687
Myron Marston myronmarston Merge pull request #798 from piotrj/patch-1
Add receive_messages to README
c31e256
Commits on Oct 04, 2014
Myron Marston myronmarston Treat `any_args` as an arg splat.
This allows it to match an arbitrary number of
arguments at any point in an arg list.

Closes #707.
944750b
Myron Marston myronmarston Convert stateless arg matchers to singletons.
This saves on memory (fewer objects to GC!).
903ebe5
Myron Marston myronmarston Provide a clear failure when invalid args are passed to `with`. 80f6f62
Myron Marston myronmarston Fix `with` verified double verification to work with new `any_args` s…
…emantics.
a6eff99
Myron Marston myronmarston Update `any_args` docs to explain splat semantics. c3c94fa
Commits on Oct 05, 2014
Myron Marston myronmarston Simplify wording based on @xaviershay’s suggestion. 1cbb1c6
Myron Marston myronmarston Merge pull request #786 from rspec/any-args-splat
Treat `any_args` as an arg splat.
4d87a45
Jon Rowe JonRowe explictly deny any_instance_of with have_received dcfb9bb
Jon Rowe JonRowe changelog for #799
[skip ci]
9664eaf
Jon Rowe JonRowe Merge pull request #799 from rspec/explicitly_deny_any_instance_have_…
…received

Improve error message when using any_instance with have_received.
926f94b
Commits on Oct 06, 2014
Myron Marston myronmarston Fix changelog.
Somehow the changlog entries from #786 wound up
under the wrong section.

[ci skip]
3bd71e8
Commits on Oct 09, 2014
Myron Marston myronmarston Fix verified double `with` verification for method stubs. d8a7c28
Myron Marston myronmarston Merge pull request #790 from rspec/verified-doubles-with-bug
Fix `with` bug for verifying doubles.
f94007a
Myron Marston myronmarston Forwardport 3.1.3 release notes.
[ci skip]
883d2a6
Commits on Oct 11, 2014
Sam Phippen samphippen Use is_a_matcher? in arg_has_valid_description
This fixes #685. It means that we only print descriptions in errors for
matcher objects and not for user objects.
c55d11b
Commits on Oct 19, 2014
Sam Phippen samphippen Implement diffing between args for mock expectations. 139473d
Sam Phippen samphippen Add a changelog entry for #751 29ee51d
Commits on Oct 20, 2014
Myron Marston myronmarston Merge pull request #751 from rspec/args-diffing
Use the differ to print diffs when args are mismatched between expectations and calls
3da6cdc
Commits on Oct 21, 2014
Sam Phippen samphippen Trim line length in error generator cbc739a
Commits on Oct 23, 2014
Sam Phippen samphippen Merge pull request #802 from rspec/samphippen/trim-error-generator-lines
Trim line length in error generator
4496242
Commits on Oct 24, 2014
Andy Waite andyw8 Fix minor typo (veryifing -> verifying) c18a943
Myron Marston myronmarston Merge pull request #804 from andyw8/patch-1
Fix minor typo (veryifing -> verifying)
9e9837b
Commits on Oct 27, 2014
Myron Marston myronmarston Split public from private interface of MessageExpectation.
These things were combined all together, which made
it more difficult to tell which was which. Also,
`MessageExpectation` was labeled `@private`, which
prevented these methods from showing up on rubydoc.info.
6ff6beb
Commits on Oct 29, 2014
Myron Marston myronmarston Improve MessageExpectation docs.
- Group the methods.
- Specify return values.
- Remove blank lines that were rendering in
  example output.
5caf5bc
Myron Marston myronmarston Merge pull request #805 from rspec/doc-improvements
Doc improvements
ad64b59
Commits on Oct 30, 2014
Myron Marston myronmarston Updated travis build scripts (from rspec-dev) 77c156e
Commits on Oct 31, 2014
Myron Marston myronmarston Merge pull request #807 from rspec/update-travis-build-scripts-2014-1…
…0-30-for-master

Updates from rspec-dev (2014-10-30)
5254af2
Commits on Nov 12, 2014
Myron Marston myronmarston Updated travis build scripts (from rspec-dev) 6a7e960
Myron Marston myronmarston Merge pull request #813 from rspec/update-travis-build-scripts-2014-1…
…1-12-for-master

Updates from rspec-dev (2014-11-12)
4a0271d
Aaron Kromer cupakromer Updated travis build scripts (from rspec-dev) 58e2300
Jon Rowe JonRowe Merge pull request #815 from rspec/update-travis-build-scripts-2014-1…
…1-12-for-master

Updates from rspec-dev (2014-11-12)
7a3b9c8
Commits on Nov 13, 2014
Myron Marston myronmarston Updated travis build scripts (from rspec-dev) 2c97b39
Commits on Nov 14, 2014
Myron Marston myronmarston Merge pull request #816 from rspec/update-travis-build-scripts-2014-1…
…1-13-for-master

Updates from rspec-dev (2014-11-13)
d1d9b29
Myron Marston myronmarston Updated travis build scripts (from rspec-dev) 4521262
Myron Marston myronmarston Merge pull request #817 from rspec/update-travis-build-scripts-2014-1…
…1-13-for-master

Updates from rspec-dev (2014-11-13)
e504e53
Commits on Nov 15, 2014
Jon Rowe JonRowe Updated travis build scripts (from rspec-dev) 0879f1c
Jon Rowe JonRowe Merge pull request #818 from rspec/update-travis-build-scripts-2014-1…
…1-15-for-master

Updates from rspec-dev (2014-11-15)
d6a89d3
Commits on Nov 21, 2014
Xavier Shay xaviershay Remove spy scenario that is wrong level of detail for relish docs.
Behaviour is already covered by specs.
9f0b16a
Jon Rowe JonRowe Merge pull request #821 from rspec/remove-spy-docs
Remove spy scenario that is wrong level of detail for relish docs.
32739eb
Myron Marston myronmarston Fix verified doubles when their const has already been stubbed.
Fixes #823.
288eea4
Myron Marston myronmarston Remove unnecessary captured block.
Capturing blocks isn’t free, and `yield` (which
we are already using) performs better than
capturing the block and using `block.call`.
8dae3e8
Myron Marston myronmarston Fix memoization to properly memoize nil. ead0b5f
Commits on Nov 24, 2014
Jon Rowe JonRowe Merge pull request #824 from rspec/fix-instance_double-when-class-con…
…st-stubbed

Fix verified doubles when their const has already been stubbed.
481844b
Commits on Nov 25, 2014
Jon Rowe JonRowe Badges are crisper as svg
[skip ci]
cceb0e8
Jon Rowe JonRowe Merge pull request #827 from rspec/badges_as_s
Switch readme badges to svg
efda49c
Myron Marston myronmarston Validate invocation args for verified null object doubles. 04e048f
Jon Rowe JonRowe Merge pull request #829 from rspec/fix-null-object-verified-double-ar…
…g-verification

Validate invocation args for verified null object doubles.
5198c6d
Myron Marston myronmarston Add a `description` to `receive` matcher. 96fa880
Myron Marston myronmarston Add a description for `receive_message_chain` matcher. c5848c5
Myron Marston myronmarston Add a description for `receive_messages` matcher. 5d8f534
Myron Marston myronmarston Add changelog entry. 626ecd5
Myron Marston myronmarston Merge pull request #828 from rspec/add-description-for-receive-matcher
Add description for matchers
b01f24d
Commits on Nov 28, 2014
Cezary Baginski e2 allow verifying doubles to use custom names in exceptions 76b84dd
Cezary Baginski e2 add class documentation about named verifying doubles f951977
Cezary Baginski e2 mention naming verifying doubles in README b5985e7
Commits on Nov 29, 2014
Myron Marston myronmarston Merge pull request #826 from e2/issue_825_named_verifying_doubles
allow naming verifying doubles just like ordinary doubles
45e2309
Myron Marston myronmarston Add changelog entry for #826.
[ci skip]
a454e6f
Commits on Nov 30, 2014
Myron Marston myronmarston Make `RSpec::Mocks::Constant.original(name)` handle invalid names gra…
…cefully.

Since this API returns an object that provides lots of details
about the constant (rather than just the original value), it's
not meant to raise errors when given constant names that can’t
resolve or are invalid -- instead the returned object indicates
that the provided name was invalid.
689878e
Commits on Dec 02, 2014
Jon Rowe JonRowe Merge pull request #833 from rspec/fix-constant-original-for-bad-cons…
…t-names

Make `RSpec::Mocks::Constant.original(name)` handle invalid names gracefully.
8018b83
Commits on Dec 08, 2014
Myron Marston myronmarston Updated travis build scripts (from rspec-dev) addf894
Jon Rowe JonRowe Merge pull request #834 from rspec/update-travis-build-scripts-2014-1…
…2-08-for-master

Updates from rspec-dev (2014-12-08)
a60491d
Myron Marston myronmarston Revert "Updated travis build scripts (from rspec-dev)"
This reverts commit addf894.

[ci skip]
85bda90
Myron Marston myronmarston Updated travis build scripts (from rspec-dev) 3a9efe0
Myron Marston myronmarston Merge pull request #835 from rspec/update-travis-build-scripts-2014-1…
…2-08-for-master

Updates from rspec-dev (2014-12-08)
739d331
Commits on Dec 09, 2014
Myron Marston myronmarston Rework spec.
Before, it mutated the message expectation after it
had already been used. This was just done as a matter
of convenience in the spec, and wasn’t the core point
of it. (Honestly, I didn’t think about mutation-after-use
at the time).

Now, it still verifies that it can be overridden in
all the same ways, but doesn’t use the expectation
before overriding it. This preserves the important
behavior while opening the door for #778.
1ec04ed
Myron Marston myronmarston Merge pull request #836 from rspec/rework-mutation-spec
Rework spec.
f303b97
Commits on Dec 10, 2014
Sam Phippen samphippen Make the collection matchers composable with other matchers.
Fixes #801
786b262
Sam Phippen samphippen Changelog entry for #819 1acff37
Sam Phippen samphippen Merge pull request #819 from rspec/samphippen/compoasable_argument_ma…
…tchers

Improve composability of collection argument matchers
ea4c222
Commits on Dec 18, 2014
Myron Marston myronmarston Updated travis build scripts (from rspec-dev) de9eef7
Myron Marston myronmarston Merge pull request #843 from rspec/update-travis-build-scripts-2014-1…
…2-17-for-master

Updates from rspec-dev (2014-12-17)
edef8c6
Commits on Dec 19, 2014
Myron Marston myronmarston Fix standalone so it doesn’t infect other objects.
This also makes `extend RSpec::Mocks::ExampleMethods`
work properly.

Fixes #845.
ac99800
Jon Rowe JonRowe Merge pull request #846 from rspec/isolate-standalone
Fix standalone so it doesn’t infect other objects.
17c7b2d
Commits on Dec 22, 2014
Melanie Gilman mrgilman Prevent invoked expectations from being modified after they are invoked. 0eb9462
Sam Phippen samphippen Changelog entry for #837 3f1124e
Sam Phippen samphippen Merge pull request #837 from rspec/samphippen/prevent-expectation-mod…
…ification

Prevent invoked expectations from being modified after they are invoked.
f74dfe0
Commits on Dec 23, 2014
Tim Wade imtayadeway Fix typo on README line 380.
* change 'sematically' to 'semantically'
* remove some whitespace from line 55.
f8c1fd8
Myron Marston myronmarston Merge pull request #847 from imtayadeway/fix-readme-typo
Fix typo on README line 380.
85327df
Commits on Dec 28, 2014
Ben Moss benmoss Updated travis build scripts (from rspec-dev) 7f70238
Myron Marston myronmarston Merge pull request #849 from benmoss/update-travis-build-scripts-2014…
…-12-27-for-master

Updated travis build scripts (from rspec-dev)
83ee10b
Myron Marston myronmarston YAML::ENGINE has been removed from Ruby 2.2. c152810
Myron Marston myronmarston Address MRI 2.2 warnings (possible reference to past scope).
From ruby/ruby@f5f6218.
It causes 280 warnings in our spec suite :(. The fix is to change the names of
variables and/or `let` definitions so they do not clash.

See https://bugs.ruby-lang.org/issues/10661 for more discussion.
9de9d60
Commits on Dec 29, 2014
Myron Marston myronmarston Merge pull request #850 from rspec/address-2-2-issues
Address 2.2 issues
f176c4b
Myron Marston myronmarston Updated travis build scripts (from rspec-dev) 0c50ee3
tschady tschady fix spelling error ade129e
Commits on Dec 30, 2014
Myron Marston myronmarston Merge pull request #852 from tschady/tws/fix_spelling
fix spelling error
c6254c4
Myron Marston myronmarston Merge pull request #851 from rspec/update-travis-build-scripts-2014-1…
…2-29-for-master

Updates from rspec-dev (2014-12-29)
8f03c38
Myron Marston myronmarston Handle stubbing IO#write and then calling IO#reopen. 5a0a48c
Commits on Jan 01, 2015
Myron Marston myronmarston Updated travis build scripts (from rspec-dev) 15637a7
Myron Marston myronmarston Merge pull request #853 from rspec/fix-stub-stderr-error
Handle stubbing IO#write and then calling IO#reopen.
a8808c2
Myron Marston myronmarston Merge pull request #855 from rspec/update-travis-build-scripts-2014-1…
…2-31-for-master

Updates from rspec-dev (2014-12-31)
69de705
Myron Marston myronmarston Updated travis build scripts (from rspec-dev) 61b7c17
Commits on Jan 02, 2015
Myron Marston myronmarston Merge pull request #856 from rspec/update-travis-build-scripts-2015-0…
…1-01-for-master

Updates from rspec-dev (2015-01-01)
dd46b28
Myron Marston myronmarston Updated travis build scripts (from rspec-dev) 9fe8a21
Jon Rowe JonRowe Merge pull request #857 from rspec/update-travis-build-scripts-2015-0…
…1-01-for-master

Updates from rspec-dev (2015-01-01)
e9b6bf3
Commits on Jan 08, 2015
Myron Marston myronmarston Updated travis build scripts (from rspec-dev) b0b91f3
Myron Marston myronmarston JRuby has different behavior here.
It doesn’t trigger the `NameError` like other rubies.
692f8c7
Myron Marston myronmarston Merge pull request #858 from rspec/update-travis-build-scripts-2015-0…
…1-07-for-master

Updates from rspec-dev (2015-01-07)
5011331
Myron Marston myronmarston Fix inaccurate doc string in cucumber scenario.
This was apparently a copy/paste error.

Thanks to @aruprakshit for notifying me of this problem.
3d29dd2
Commits on Jan 09, 2015
Jon Rowe JonRowe Merge pull request #860 from rspec/fix-cuke-copy-paste-error
Fix inaccurate doc string in cucumber scenario.
83221b3
Myron Marston myronmarston Updated travis build scripts (from rspec-dev) 6cc173b
Commits on Jan 10, 2015
Myron Marston myronmarston Forwardport 2.99.3 release notes.
[ci skip]
c10548c
Commits on Jan 11, 2015
Jon Rowe JonRowe add an api for customising how verifying doubles are checked 6a7d7d8
Jon Rowe JonRowe change api call to pass reference 2e9418b
Jon Rowe JonRowe rename const to target to better reflect nature 48eb2d4
Jon Rowe JonRowe add test coverage for reference target 379ada8
Jon Rowe JonRowe update documentation for new callback 79e2a87
Jon Rowe JonRowe rename DirectModuleReference to AnonymousModuleReference to accuratel…
…y reflect when it is used
40f2862
Myron Marston myronmarston Make comment more accurate. 774fd3f
Myron Marston myronmarston Add missing spec coverage for anonymous module verifying doubles. 88f3f4e
Jon Rowe JonRowe Merge pull request #832 from rspec/extend_verifying_doubles_api
Add an api for customising how verifying doubles are checked
fd0158f
Myron Marston myronmarston Merge pull request #859 from rspec/update-travis-build-scripts-2015-0…
…1-08-for-master

Updates from rspec-dev (2015-01-08)
44dee47
Myron Marston myronmarston Revert "Updates from rspec-dev (2015-01-08)" 91e6a77
Myron Marston myronmarston Merge pull request #861 from rspec/revert-859-update-travis-build-scr…
…ipts-2015-01-08-for-master

Revert "Updates from rspec-dev (2015-01-08)"
9f5babd
Commits on Jan 15, 2015
Myron Marston myronmarston Refactor odd memoization.
It is odd here because within the matcher, we call
`@expectation = expect`, and within `expect` it was
internally memoizing, which means `@expectation`
was being assigned twice. It’s also dubious to
do so because we want to minimize internal memoization
since a matcher can be re-used against a different
target.
1b264f3
Jon Rowe JonRowe docs for object references exposed by #832 callback da3f322
Jon Rowe JonRowe expose object rather than class as target d868ecb
Myron Marston myronmarston Update spec to reflect the target being the object itself. 7478671
Myron Marston myronmarston Improve docs so they render properly with a YARD server.
While we're at it, remove AnonymousModuleReference -- we don’t need it anymore!
6493f2a
Myron Marston myronmarston Clarify error message. 152cc5e
Commits on Jan 16, 2015
Jon Rowe JonRowe Merge pull request #863 from rspec/docs_for_832
Docs for object references exposed by #832 callback
cfaf4ef
Myron Marston myronmarston Provide a clear error when received message args are mutated.
...before a `have_received(...).with(...)` expectation.

Fixes #865.
ed3fb3b
Myron Marston myronmarston Just use `Array#hash`.
As @jferris pointed out, it’s sufficient. Besides
being simpler (and likely faster, though I haven’t
benchmarked it), this does fewer object allocations.
52c69f1
Commits on Jan 17, 2015
Ryan Fitzgerald rf- Make and_wrap_original work with any_instance (fix #867)
There were a couple of different issues preventing `and_wrap_original`
from working when used with `any_instance`.
97ba302
Myron Marston myronmarston Merge pull request #869 from brigade/master
Make and_wrap_original work with any_instance
09ceebb
Myron Marston myronmarston Add changelog for #869.
[ci skip]
65d3b65
Jon Rowe JonRowe Merge pull request #866 from rspec/refactor-odd-memoization
Refactor odd memoization.
fdbad95
Aaron Kromer cupakromer Include details on how to run against `master`.
A very common issue is when a user attempts to run against the `master`
branch. Simply pointing to `master` doesn't work. This adds the steps
necessary to use `master`.

We need all of the repos in order to also satisfy any other gems which
may have a dependency on the `rspec` gem.

[ci skip]
d65446b
Aaron Kromer cupakromer Merge pull request #870 from rspec/help-for-running-master
Include details on how to run against `master`.
04a2d37
Commits on Jan 18, 2015
Jon Rowe JonRowe Merge pull request #868 from rspec/address-issue-865
Provide a clear error when received message args are mutated.
da33d26
Commits on Jan 19, 2015
Jon Rowe JonRowe update docs for rspec/rspec_rails#1238
[skip ci]
25d4345
Jon Rowe JonRowe Merge pull request #864 from rspec/update_docs_for_rr_1238
Amend docs post #832 and rspec/rspec-rails#1238
9191106
Myron Marston myronmarston Reword comment to not use “external” twice.
Thanks to @waterlink for pointing this out.
8a0962a
Myron Marston myronmarston Ignore arg mutations for method calls we are not concerned with. fc9e9a5
Jon Rowe JonRowe Merge pull request #871 from rspec/pr-868-followups
Pr 868 followups
800ea20
Commits on Jan 21, 2015
Myron Marston myronmarston Better formatting for error message. 73ac1f6
Myron Marston myronmarston Deal with verified doubles for classes that redefined `name`.
These sorts of classes worked fine before #824 was
merged, and the switch to using a NamedObjectReference
based on the name broke things for them. This restores
support.
235e43e
Jon Rowe JonRowe Merge pull request #873 from rspec/824-followups
824 followups
56392d9
Commits on Jan 22, 2015
sivagollapalli sivagollapalli FIX# Displaying 'Diff' in new line 3ab98c5
Commits on Jan 27, 2015
Myron Marston myronmarston Improve explanation about verified double argument verification.
Closes #878.
b8a838a
Myron Marston myronmarston Merge pull request #879 from rspec/clarify-verifying-double-arg-verif…
…ication

Improve explanation about verified double argument verification.
d213d26
Commits on Jan 28, 2015
sivagollapalli sivagollapalli Removed extra space to make left align 9edc017
sivagollapalli sivagollapalli Added specs for #875 6fc4603
Myron Marston myronmarston Merge pull request #876 from sivagollapalli/issue_875
FIX# Displaying 'Diff' in new line
07ee32f
Commits on Jan 29, 2015
Myron Marston myronmarston Explicitly tag pending specs for ordered/vague count combinations.
This will now print the reason it is pending on CI and skip
them locally since it adds a lot of noise to our output
and we have yet to attempt to address them.
ab93dda
Myron Marston myronmarston Merge pull request #880 from rspec/cleanup-some-pending-specs
Explicitly tag pending specs for ordered/vague count combinations.
a5b4f5b
Commits on Jan 31, 2015
Yorick Peterse YorickPeterse Removed rubysl from the Gemfile.
This hasn't been required anymore since quite a while. Starting with 2.2.0 (if I
remember correctly) Rubinius takes care of ensuring the rubysl Gems are always
available, with or without Bundler.
ac486cd
Myron Marston myronmarston Merge pull request #882 from YorickPeterse/master
Removed rubysl from the Gemfile.
08186cc
Commits on Feb 03, 2015
Myron Marston myronmarston Update changelog for v3.2.0 [ci skip] 90cb471
Myron Marston myronmarston Release 3.2.0 d7ed065
Myron Marston myronmarston Bump version to 3.3.0.pre 44d81d6
Commits on Feb 04, 2015
Myron Marston myronmarston Updated travis build scripts (from rspec-dev) 1184e78
Commits on Feb 05, 2015
Myron Marston myronmarston When stubbing `MyClass.new` verify against `MyClass#initialize`.
Closes #883.
990b017
Myron Marston myronmarston Merge pull request #885 from rspec/update-travis-build-scripts-2015-0…
…2-03-for-master

Updates from rspec-dev (2015-02-03)
44d2557
Myron Marston myronmarston Pend specs to deal with jruby/jruby#2565. 8056a9e
Jon Rowe JonRowe Merge pull request #886 from rspec/use-initialize-signature-for-new
When stubbing `MyClass.new` verify against `MyClass#initialize`.
0ab18a3
Commits on Feb 09, 2015
Myron Marston myronmarston Updated travis build scripts (from rspec-dev) 7cd14ae
Myron Marston myronmarston Merge pull request #888 from rspec/update-travis-build-scripts-2015-0…
…2-08-for-master

Updates from rspec-dev (2015-02-08)
f03b686
Myron Marston myronmarston Remove unused method. a77686b
Jon Rowe JonRowe Merge pull request #889 from rspec/remove-unused-method
Remove unused method.
250a5de
Commits on Feb 11, 2015
Tim Wade imtayadeway Fix argument formatting for received. 08eb0f2
Tim Wade imtayadeway Unify similar args description methods.
ErrorGenerator#actual_method_call_args_description and
ErrorGenerator#expected_method_call_args_description were almost
identical. This change moves the common code from both into the
ErrorGenerator#method_call_args_description method and yields to a block
which lets the caller decide on what condition to show the formatted args.
7f6e065
Commits on Feb 12, 2015
Jon Rowe JonRowe Merge pull request #891 from imtayadeway/fix-received-matcher-descrip…
…tions

Fix argument formatting for received.
91d3f5a
Jon Rowe JonRowe changelog for #891
[skip ci]
3828148
Commits on Feb 17, 2015
Myron Marston myronmarston Clarify changelog for #891. ddb4c20
Myron Marston myronmarston Cleanup whitespace. b096ec9
Myron Marston myronmarston Update to new rspec-support library wide checks. 3fff060
Myron Marston myronmarston Don’t load stringio unnecessarily. 394d373
Myron Marston myronmarston Deal with the fact we load securerandom on 1.9.2. 0d3e0f8
Myron Marston myronmarston Update based on latest rspec-support requires. fec1b7f
Jon Rowe JonRowe Merge pull request #894 from rspec/allowed-stdlib
Allowed stdlib
63a65c2
Tim Wade imtayadeway Add more specific "does not implement" messages.
The unimplemented error message gives no indication of whether the
object is a class or instance double. This change passes that object to
the error generator so that it can create a more specific message
depending on whether it is an instance or class double. It defaults to
the original "<object> does not implement <method>" for anything else.

#838
4b1b008
Commits on Feb 18, 2015
Jon Rowe JonRowe Merge pull request #896 from imtayadeway/instance-class-double-verifi…
…cation

Add more specific "does not implement" messages.
4777fd0
Jon Rowe JonRowe change for #896
[skip ci]
149293e
Commits on Feb 23, 2015
Myron Marston myronmarston Make doc string more accurate. 8e56f83
Myron Marston myronmarston Stop calling methods on args passed to a stubbed method.
Any method call may mutate an object, so we can't safely call
anything on a passed argument.

This reverts the following PRs and commits:

* #871:
  * 8a0962a ("Reword comment to not use “external” twice.")
  * 52c69f1 ("Just use `Array#hash`.")
* #868:
  * ed3fb3b ("Provide a clear error when received message args are mutated.")
  * fc9e9a5 ("Ignore arg mutations for method calls we are not concerned with.")

This adds notes to the docs about using mutated args
with `have_received(…).with(…)`.

Fixes #892.
8d071d5
Myron Marston myronmarston Fixup formatting of `@example` YARD comments.
- No blank line after `@example`; YARD renders that
  as a blank line of code.
- Standardize on 2 spaces.
62236cd
Jon Rowe JonRowe Merge pull request #900 from rspec/revert-arg-mutation-error
Revert arg mutation error
4c0664c
Commits on Feb 24, 2015
Myron Marston myronmarston Forwardport 3.2.1 release notes. c455fc5
Myron Marston myronmarston Updated travis build scripts (from rspec-dev) d437b03
Commits on Feb 25, 2015
Myron Marston myronmarston Merge pull request #902 from rspec/update-travis-build-scripts-2015-0…
…2-24-for-master

Updates from rspec-dev (2015-02-24)
b610169