Fix marshal extension #29

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
3 participants
Owner

myronmarston commented Nov 7, 2010

This is a minor bug fix for the recently added Marshal extension.

@myronmarston myronmarston Fix our Marshal extension so that it does not interfere with objects …
…that have their own @mock_proxy instance variable.

Since our Marshal extension is loaded globally and affects every Marshal.dump call, we need to be extra careful not to unintentionally affect other things that rely on it.
7498d4a

txus commented on 7498d4a Nov 7, 2010

It really makes more sense to check for a RSpec::Mocks::Proxy object rather than only the instance variable. Thanks!

Owner

dchelimsky commented Nov 7, 2010

Guess this will have to wait for 2.1.1 :)

Owner

myronmarston commented Nov 29, 2010

Hmm...I was hopeful this could get in the next release, but 2.2 just came out. Maybe in the next release?

Owner

dchelimsky commented Nov 29, 2010

It's a bug fix - can do 2.2.1 - let's give it a few days though

Owner

myronmarston commented Dec 11, 2010

Fix our Marshal extension so that it does not interfere with objects that have their own @mock_proxy instance variable.

Since our Marshal extension is loaded globally and affects every Marshal.dump call, we need to be extra careful not to unintentionally affect other things that rely on it.

This issue was closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment