Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove mock and stub in favour of double #341

Merged

Conversation

@penelopezone
Copy link
Member

@penelopezone penelopezone commented Jul 4, 2013

This removes mock and stub as ways of creating doubles, it does not remove stub on other objects. These were deprecated, this removes them for RSpec 3.

@coveralls
Copy link

@coveralls coveralls commented Jul 4, 2013

Coverage Status

Coverage increased (+0%) when pulling 256c962 on samphippen:remove_mock_and_stub_doubles into 6ef6f11 on rspec:master.

@coveralls
Copy link

@coveralls coveralls commented Jul 5, 2013

Coverage Status

Coverage decreased (-0%) when pulling 523f4e8 on samphippen:remove_mock_and_stub_doubles into 1ce7acd on rspec:master.

@coveralls
Copy link

@coveralls coveralls commented Jul 5, 2013

Coverage Status

Coverage increased (+0%) when pulling 523f4e8 on samphippen:remove_mock_and_stub_doubles into 1ce7acd on rspec:master.

@@ -6,6 +6,8 @@ Breaking Changes for 3.0.0:
Phippen)
* Remove 1.8.6 workarounds (Jon Rowe)
* Remove `stub!` and `unstub!`. (Sam Phippen)
* Remove `mock(name, methods)` and `stub(name, methods)`,
leaving `double(name, methods)` for double objects. (Sam Phippen)

This comment has been minimized.

@myronmarston

myronmarston Jul 5, 2013
Member

How about for creating test doubles rather than for double objects? I think the former reads better.

This comment has been minimized.

@penelopezone

penelopezone Jul 5, 2013
Author Member

👍

Sam Phippen
Signed-off-by: Sam Phippen <samphippen@googlemail.com>
@coveralls
Copy link

@coveralls coveralls commented Jul 5, 2013

Coverage Status

Coverage increased (+0%) when pulling 19eb871 on samphippen:remove_mock_and_stub_doubles into 1ce7acd on rspec:master.

@penelopezone
Copy link
Member Author

@penelopezone penelopezone commented Jul 5, 2013

I think I'm happy with this and I've had a some review from @myronmarston. I'm going to merge this.

penelopezone pushed a commit that referenced this pull request Jul 5, 2013
Remove mock and stub in favour of double
@penelopezone penelopezone merged commit 196524b into rspec:master Jul 5, 2013
1 check passed
1 check passed
default The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.