Permalink
Switch branches/tags
Commits on Oct 19, 2017
  1. Update Changelog for 3.7.1 (#1888)

    pwim committed with JonRowe Oct 19, 2017
Commits on Oct 18, 2017
  1. Fix puma loading in Rails 5.1 (#1884)

    samphippen committed Oct 18, 2017
    * Fix puma loading in Rails 5.1
    
    * Prevent system tests loading without capybara
    
    * Allow rescuing exceptions for system test
    
    * Fix rubocop lints
Commits on Oct 17, 2017
  1. Bump version to 3.8.pre

    samphippen committed Oct 17, 2017
  2. Releases 3.7.0

    samphippen committed Oct 17, 2017
Commits on Sep 15, 2017
  1. Merge pull request #1874 from rspec/update-travis-build-scripts-2017-…

    yujinakayama committed Sep 15, 2017
    …09-15-for-master
    
    Updates from rspec-dev (2017-09-15)
Commits on Sep 14, 2017
  1. Fix #1865 by memoizing generated method name. (#1872)

    samphippen committed Sep 14, 2017
    The problem here is that rails calls `#method_name` on the example a
    number of times in order to correctly generate the screenshot and then
    manipulate it. Given that we were randomising the integer that was
    generated on every call, this didn't work.
    
    This patch solves the problem by memoizing the generated method name so
    that the screenshot path is generated once per example and then
    correctly accessed on subsequent method calls.
Commits on Sep 11, 2017
Commits on Sep 9, 2017
  1. Merge pull request #1867 from RustyNail/patch-1

    xaviershay committed Sep 9, 2017
    Fix typo in Gemfile
  2. Fix typo in Gemfile

    RustyNail committed Sep 9, 2017
Commits on Aug 29, 2017
  1. Fix broken Gemfile

    JonRowe committed Aug 29, 2017
Commits on Aug 26, 2017
  1. Merge pull request #1864 from rspec/pin-byebug

    samphippen committed Aug 26, 2017
    Pin byebug to '~> 9.0.6' for ruby 2.0.
  2. Pin byebug to '~> 9.0.6' for ruby 2.0.

    samphippen committed Aug 26, 2017
    Byebug `9.1.0` released pinned to ruby 2.2. We need to support ruby 2.0,
    so here we add a gsub to pin to byebug versions that support 2.0.
  3. Merge pull request #1839 from rlue/master

    samphippen committed Aug 26, 2017
    Discourage controller specs in README
  4. Add changelog entry for #1856

    samphippen committed Aug 26, 2017
  5. Merge pull request #1856 from lazyatom/only-configure-rspec-mocks-if-…

    samphippen committed Aug 26, 2017
    …fully-loaded
    
    Only configure RSpec::Mocks if it is fully loaded
Commits on Aug 12, 2017
  1. Merge pull request #1853 from fakefarm/bump-version

    yujinakayama committed Aug 12, 2017
    Reflect latest version (3.6) in README [ci skip]
Commits on Aug 11, 2017
  1. Merge pull request #1859 from alyssais/patch-1

    xaviershay committed Aug 11, 2017
    Fix typo in rails helper template
Commits on Aug 10, 2017
  1. Merge pull request #1858 from rspec/update-travis-build-scripts-2017-…

    yujinakayama committed Aug 10, 2017
    …08-10-for-master
    
    Updates from rspec-dev (2017-08-10)
Commits on Aug 9, 2017
Commits on Aug 7, 2017
  1. Only configure RSpec::Mocks if it is fully loaded

    lazyatom committed Aug 7, 2017
    It's possible for the `::RSpec::Mocks` constant to exist, but for it not
    to have the `configuration` method present. This can happen if another
    library has required some files from _within_ the `rspec/mocks` library,
    but nothing else has fully loaded it.
    
    For a concrete example, see krisleech/wisper-rspec#21
    
    While allowing external libraries to use parts of this one might not be
    something that's explicitly supported, we can avoid some unexpected
    exceptions by adding a little extra check to our detection of whether or
    not the mocking library is loaded.
Commits on Aug 2, 2017
Commits on Jul 7, 2017
Commits on Jun 30, 2017
  1. Changelog for #1831

    JonRowe committed Jun 30, 2017
  2. Fix noisy log error (#1831)

    sj26 committed with JonRowe Jun 30, 2017
    * Fix noisy log error
    
    We've been seeing this error in our test logs:
    
        Could not log "render_template.action_view" event.
        NoMethodError: undefined method `example_group' for nil:NilClass
        .../rspec-rails-3.6.0/lib/rspec/rails/view_rendering.rb:67:in `current_example_group'
        .../rspec-rails-3.6.0/lib/rspec/rails/view_rendering.rb:71:in `render_template'
        ...
    
    This is while running an rspec rails feature spec using capybara, so
    this is a separate thread running webrick. This was also during a before
    block. In any case, this should probably fail gracefully when there is
    no example.
    
    While updating this code I got an "ExampleGroup doesn't respond to
    render_views?", so built in that case too.
    
    * Throw away the LogSubscriber and just log explicitly
Commits on May 28, 2017
  1. Add changelog for #1811.

    myronmarston committed May 28, 2017
  2. Merge pull request #1811 from britnia/issue_1801_inconsistent_matcher…

    myronmarston committed May 28, 2017
    …_behavior
    
    Allow use of composable matchers inside be_a_new#with
Commits on May 20, 2017
Commits on May 18, 2017
  1. Ensure that failure messages accurately reflect matchers and remove r…

    britnia committed May 17, 2017
    …egex matching from expectations