Permalink
Switch branches/tags
Commits on May 19, 2013
Commits on May 18, 2013
  1. Bumps to 2.13.2

    [ci skip]
    alindeman committed May 18, 2013
  2. Prepares for 2.13.2

    alindeman committed May 18, 2013
  3. Request specs do not live in spec/features

    [Fixes #745]
    alindeman committed May 18, 2013
Commits on May 14, 2013
  1. `subject` is defined as a method rather than with the `subject` decla…

    …rative method
    
    There is currently some odd interactions between rspec-rails and
    rspec-core when it comes to `let` definitions.
    
    If we call `subject` in an `included` hook, the dynamically generated
    `LetDefinitions` module gets inserted into the ancestor chain earlier
    than normal. This placement no longer allows `let` definitions to
    override methods defined on other modules that are brought in via
    `config.include`.
    
    We may raise a warning in future (see discussion in #738)
    
    [Fixes #738]
    
    Conflicts:
    	Changelog.md
    alindeman committed May 13, 2013
  2. demonstrate issue with let

    JonRowe committed with alindeman Apr 11, 2013
Commits on May 12, 2013
  1. Rely on ::Rails::VERSION::STRING instead of an overly complex module

    * I did not know about ::Rails::VERSION::STRING until recently. It seems
      to be defined all the way back to 3.0.0, which is all we need.
    alindeman committed May 9, 2013
Commits on Apr 27, 2013
  1. Bumps to 2.13.1

    alindeman committed Apr 27, 2013
Commits on Apr 17, 2013
Commits on Apr 16, 2013
  1. Documentation updates

    [ci skip]
    alindeman committed Apr 16, 2013
  2. Tests run correctly on Rails 4 again

    * We cannot use the bundle-generated binstub anymore
    alindeman committed Apr 13, 2013
  3. MiniTestLifecycleAdapter runs hooks in the correct order

    * Also adds tests which helped me find ordering issues
    alindeman committed Apr 13, 2013
Commits on Apr 13, 2013
  1. A widget needs an ID for widget_path to work correctly

    * I'm not sure how I missed this earlier. It's the source of the build
      being red.
    alindeman committed Apr 7, 2013
  2. Spacing fix will be in 2.13

    [ci skip]
    alindeman committed Apr 13, 2013
  3. Add a bit of info about Capybara::DSL to README

    I personally found it a bit confusing to figure out how to use the
    Capybara DSL until I read the Capybara docs at the bottom of the
    README.  It wasn't immediately obvious that this doc even /existed/
    when I first read the README as I wasn't interested in customising
    rake tasks.  So I have made another link to the doc in the request
    spec section and explained that by default the DSL is only available
    in spec/features.
    awilfox committed with alindeman Apr 8, 2013
  4. Fix README - HTTP status code is string [ci skip]

    response.code is a string, so .eq(200) fails with:
         Failure/Error: expect(response.code).to eq(200)
           expected: 200
                got: "200"
    awilfox committed with alindeman Apr 8, 2013
  5. Adds feature to attempt to demonstrate #725

    * I can't reproduce it, so we'll close #725 for now
    alindeman committed Apr 7, 2013
  6. Add a changelog entry for #728.

    [ci skip]
    
    Signed-off-by: Sam Phippen <samphippen@googlemail.com>
    samphippen committed with alindeman Apr 6, 2013
  7. Change a few more places to use `expect`

    [ci skip]
    alindeman committed Apr 6, 2013
  8. Adjust wording of comment

    [Closes #718]
    alindeman committed Apr 6, 2013
  9. enable rcov task on ruby 1.8 only

    tamird committed with alindeman Mar 26, 2013