Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
branch: 3-0-maintenance
Commits on Oct 17, 2014
  1. @JonRowe

    Merge pull request #1192 from rspec/limit_rails_versions

    JonRowe authored
    Update gemspec preventing 4.2 on rspec 3.0
Commits on Oct 14, 2014
  1. @JonRowe
Commits on Aug 29, 2014
  1. @cupakromer

    Drop support for Rails `master`.

    cupakromer authored
    Current Rails `master` branch is targeting Rails 4.2+. There are several
    changes necessary for supporting Rails 4.2. These will not be included
    with rspec-rails 3.0.x.
  2. @cupakromer

    Backport pull request #1145 from joshk/patch-1

    cupakromer authored
    This branch does not use the updated build scripts.
Commits on Aug 25, 2014
  1. @JonRowe

    Merge pull request #1158 from seuros/patch-1

    JonRowe authored
    Update feature_generator_spec.rb
Commits on Aug 21, 2014
  1. @cupakromer

    Backport pull request #1142 from joker1007/adapt_named_route_helpers_…

    cupakromer authored
    …split
    
    Fix controller spec fails on edge Rails
  2. @joker1007 @cupakromer

    Fix controller route lookup for Rails 4.2

    joker1007 authored cupakromer committed
    Rails-4.2 splits named_routes.helpers to path_helpers and url_helpers.
    And add route_defined? method to NamedRouteCollection.
Commits on Aug 4, 2014
  1. @cupakromer
  2. @cupakromer

    Note where to add requires so Rails is loaded.

    cupakromer authored
    There are no clear directions where additional library requires should
    be included. This let's users know where to add the requires so that
    Rails is loaded and availble for them.
  3. @cupakromer

    Satisfy Rubocop's guard clause expectations.

    cupakromer authored
    Big thanks (づ。◕‿‿◕。)づ to @mikegee for the suggestion in
    f6c277f#commitcomment-7167216.
    That provided the vast majority of the refactor.
    
    At the end of the day, this changes makes a lot more sense, separating
    concerns in a more logical location.
Commits on Aug 3, 2014
  1. @cupakromer

    Backport pull request #1135 from rspec/no-monkey-patch-cukes

    cupakromer authored
    Use RSpec module to hook into the DSL
  2. @cupakromer

    Indent cuke ruby file definitions consistently.

    cupakromer authored
    Standardize on indenting the Ruby code file definitions to one level
    inside the `Given` block.
  3. @cupakromer

    Use RSpec module to hook into the DSL.

    cupakromer authored
    Recent changes to rspec-core have added `disable_monkey_patching!` to
    the default `spec/spec_helper.rb` file. This caused the cukes to fail
    which were not updated yet to use the non-patching method of using the
    DSL.
Commits on Aug 2, 2014
  1. @cupakromer
Commits on Jul 23, 2014
  1. @JonRowe

    Merge pull request #1128 from rspec/cherry-pick-rubocop-to-3-0-mainte…

    JonRowe authored
    …nance
    
    Cherry pick rubocop to 3-0-maintenance
Commits on Jul 22, 2014
  1. @JonRowe

    Merge pull request #1118 from rspec/add-rubocop

    JonRowe authored
    Use Rubocop
Commits on Jul 21, 2014
  1. @cupakromer

    Release 3.0.2.

    cupakromer authored
  2. @cupakromer

    Backport pull request #1122 from Kriechi/adapt_template

    cupakromer authored
    Standardize controller spec templates.
  3. @cupakromer
  4. @Kriechi @cupakromer

    Standardize controller spec templates.

    Kriechi authored cupakromer committed
    Make single `controller_spec` template conform with scaffolded
    `controller_spec`.
Commits on Jul 8, 2014
  1. @cupakromer
  2. @cupakromer
  3. @cupakromer

    Whitespace only update.

    cupakromer authored
  4. @cupakromer
  5. @cupakromer

    Various formatting updates.

    cupakromer authored
    - Be consistent on how lists are defined by using a dash
    - Add missing backticks around code words
    - Update some descriptions with clearer information
    - Add some missing hyper links
  6. @cupakromer

    Remove explicit anchor tags.

    cupakromer authored
    Github READMEs now automatically add anchor links to the headers.
  7. @cupakromer
  8. @cupakromer

    State spec type metadata and default directories.

    cupakromer authored
    The directories where specs reside now essentially defaults with RSpec
    3. Update make this clear and state what equivalent metadata is required
    to mirror the functionality in other specs.
  9. @cupakromer

    Use top-level namespace for `describe`.

    cupakromer authored
    Add consistent whitespace between `require` and the first
    `RSpec.describe`.
  10. @cupakromer

    Remove app upgrade notes in favor of linked docs.

    cupakromer authored
    The feature notes have all of the details of how to properly upgrade.
    These are hosted online and were already linked in the above section.
    Remove the duplication as it detracts from the remainder of the README.
  11. @cupakromer
Commits on Jul 6, 2014
  1. @cupakromer
  2. @cupakromer
  3. @cupakromer

    Merge pull request #1116 from rspec/backport-smoke-test

    cupakromer authored
    Backport smoke task from pull request #1087
  4. @cupakromer

    Extract rails gem loading into shared Gemfile.

    cupakromer authored
    When the example app is generated it puts a Rails version that is
    defined by currently installed version. This works great in most
    situtations, except `master` or other edge branches. The version listed
    is the current version of Rails, so they diverge.
    
    Move how we load rails into a custom Gemfile, which we eval ourselves.
    We then remove the rails version put into the gemfile and share our
    custom version. Due to when `rake` and other shell processes fork, the
    RAILS_VERSION environment variable is properly passed through.
Something went wrong with that request. Please try again.