Permalink
Commits on Oct 17, 2014
  1. Merge pull request #1192 from rspec/limit_rails_versions

    Update gemspec preventing 4.2 on rspec 3.0
    JonRowe committed Oct 17, 2014
Commits on Oct 14, 2014
Commits on Aug 29, 2014
  1. Drop support for Rails `master`.

    Current Rails `master` branch is targeting Rails 4.2+. There are several
    changes necessary for supporting Rails 4.2. These will not be included
    with rspec-rails 3.0.x.
    cupakromer committed Aug 29, 2014
  2. Backport pull request #1145 from joshk/patch-1

    This branch does not use the updated build scripts.
    cupakromer committed Aug 29, 2014
Commits on Aug 25, 2014
  1. Merge pull request #1158 from seuros/patch-1

    Update feature_generator_spec.rb
    JonRowe committed Aug 25, 2014
Commits on Aug 21, 2014
  1. Backport pull request #1142 from joker1007/adapt_named_route_helpers_…

    …split
    
    Fix controller spec fails on edge Rails
    cupakromer committed Aug 21, 2014
  2. Fix controller route lookup for Rails 4.2

    Rails-4.2 splits named_routes.helpers to path_helpers and url_helpers.
    And add route_defined? method to NamedRouteCollection.
    joker1007 committed with cupakromer Aug 11, 2014
Commits on Aug 4, 2014
  1. Note where to add requires so Rails is loaded.

    There are no clear directions where additional library requires should
    be included. This let's users know where to add the requires so that
    Rails is loaded and availble for them.
    cupakromer committed Aug 4, 2014
  2. Satisfy Rubocop's guard clause expectations.

    Big thanks (づ。◕‿‿◕。)づ to @mikegee for the suggestion in
    f6c277f#commitcomment-7167216.
    That provided the vast majority of the refactor.
    
    At the end of the day, this changes makes a lot more sense, separating
    concerns in a more logical location.
    cupakromer committed Aug 3, 2014
Commits on Aug 3, 2014
  1. Backport pull request #1135 from rspec/no-monkey-patch-cukes

    Use RSpec module to hook into the DSL
    cupakromer committed Aug 3, 2014
  2. Indent cuke ruby file definitions consistently.

    Standardize on indenting the Ruby code file definitions to one level
    inside the `Given` block.
    cupakromer committed Aug 3, 2014
  3. Use RSpec module to hook into the DSL.

    Recent changes to rspec-core have added `disable_monkey_patching!` to
    the default `spec/spec_helper.rb` file. This caused the cukes to fail
    which were not updated yet to use the non-patching method of using the
    DSL.
    cupakromer committed Aug 3, 2014
Commits on Aug 2, 2014
Commits on Jul 23, 2014
  1. Merge pull request #1128 from rspec/cherry-pick-rubocop-to-3-0-mainte…

    …nance
    
    Cherry pick rubocop to 3-0-maintenance
    JonRowe committed Jul 23, 2014
Commits on Jul 22, 2014
  1. Merge pull request #1118 from rspec/add-rubocop

    Use Rubocop
    JonRowe committed Jul 22, 2014
Commits on Jul 21, 2014
  1. Release 3.0.2.

    cupakromer committed Jul 21, 2014
  2. Backport pull request #1122 from Kriechi/adapt_template

    Standardize controller spec templates.
    cupakromer committed Jul 21, 2014
  3. Standardize controller spec templates.

    Make single `controller_spec` template conform with scaffolded
    `controller_spec`.
    Thomas Kriechbaumer committed with cupakromer Jul 11, 2014
Commits on Jul 8, 2014
  1. Merge pull request #1119 from rspec/backport-pull-request-1117

    Backport pull request #1117
    cupakromer committed Jul 8, 2014
  2. Whitespace only update.

    cupakromer committed Jul 7, 2014
  3. Various formatting updates.

    - Be consistent on how lists are defined by using a dash
    - Add missing backticks around code words
    - Update some descriptions with clearer information
    - Add some missing hyper links
    cupakromer committed Jul 7, 2014
  4. Remove explicit anchor tags.

    Github READMEs now automatically add anchor links to the headers.
    cupakromer committed Jul 7, 2014
  5. State spec type metadata and default directories.

    The directories where specs reside now essentially defaults with RSpec
    3. Update make this clear and state what equivalent metadata is required
    to mirror the functionality in other specs.
    cupakromer committed Jul 7, 2014
  6. Use top-level namespace for `describe`.

    Add consistent whitespace between `require` and the first
    `RSpec.describe`.
    cupakromer committed Jul 6, 2014
  7. Remove app upgrade notes in favor of linked docs.

    The feature notes have all of the details of how to properly upgrade.
    These are hosted online and were already linked in the above section.
    Remove the duplication as it detracts from the remainder of the README.
    cupakromer committed Jul 6, 2014
Commits on Jul 6, 2014
  1. Merge pull request #1116 from rspec/backport-smoke-test

    Backport smoke task from pull request #1087
    cupakromer committed Jul 6, 2014
  2. Extract rails gem loading into shared Gemfile.

    When the example app is generated it puts a Rails version that is
    defined by currently installed version. This works great in most
    situtations, except `master` or other edge branches. The version listed
    is the current version of Rails, so they diverge.
    
    Move how we load rails into a custom Gemfile, which we eval ourselves.
    We then remove the rails version put into the gemfile and share our
    custom version. Due to when `rake` and other shell processes fork, the
    RAILS_VERSION environment variable is properly passed through.
    cupakromer committed Jun 24, 2014