Permalink
Switch branches/tags
Commits on Jun 6, 2015
  1. Release 3.2.3.

    myronmarston committed Jun 6, 2015
Commits on Jun 5, 2015
  1. Merge pull request #1389 from rspec/backport-1388

    cupakromer committed Jun 5, 2015
    Back port pull request #1388 from rspec/fix-regression-mailer-preview-path
  2. Update changelog with `preview_path=` fix

    cupakromer committed Jun 4, 2015
    [ci skip]
  3. Fix regression issue with `preview_path=`

    cupakromer committed Jun 4, 2015
    The `preview_path` feature of `ActionMailer` was added in Rails 4.1.
    Versions before that release are not able to handle that configuration.
    The regression issue occurred in part to the spec suite overlooking
    changes to the environment and how that affects the shelling out.
    
    Additionally, the previous changes noted that the configuration for a
    particular module always responds to a setting; even when it should not.
    However, while this logic was noted for `show_previews`, a few lines
    further down, that same logic was overlooked for `preview_path`.
    
    It appears the only available methods for detecting `ActionMailer`, and
    it's features, is tasting the top-level `config` in addition to checking
    the Rails version string.
  4. Expose broken `ActionMailer` preview setup.

    cupakromer committed Jun 3, 2015
    This fixes the spec suite to expose issues with `ActionMailer` being
    configured incorrectly when previews are not available.
    
    This addresses several issues:
    
    - The incorrect configuration options are only exposed once
      `ActionMailer::Base` is loaded; this forces the class to load in the
      mailer initializer and at the end of our script
    - This adds specs specifically for the "development" environment which
      were missing before; it appeared that by not setting the environment
      it would default to "development" per the script, however, when the
      command shells out the `RAILS_ENV` is already set to "test" from rspec
      running.
    
      To be certain we cover the other possible edge cases we specifically
      add more tests for `ActionMailer` not being available, and for a
      custom configuration being set after `rspec-rails` is loaded.
    - Despite us asking Rails to turn off eager loading in our custom
      script, several files were still getting eager loaded; this
      explicitly clears the eager load paths to stop this
    - This fixes how the mailer script is shelled out in Ruby 1.8.7; now the
      environment variables are properly formatted and standard error is
      piped to standard out
    
    Exposes the regression issue in #1386
Commits on Jun 3, 2015
  1. Add full changelog link.

    myronmarston committed Jun 3, 2015
    [ci skip]
  2. Release 3.2.2.

    myronmarston committed Jun 3, 2015
Commits on May 26, 2015
  1. Merge pull request #1380 from rspec/backport-bug-fixes

    cupakromer committed May 26, 2015
    Backport bug fixes
  2. Update changelog with remaining backports.

    cupakromer committed May 26, 2015
  3. Fix load order 🐛

    cupakromer committed Apr 17, 2015
    This fixes an "undefined method `fixture_path`" error caused in
    `RSpec::Core::Configuration`. The issue occurs when a spec is created
    before rspec-rails is loaded. The cause is rspec-core attempts to
    include the `RSpec::Rails::FixtureSupport` module into the existing spec
    as soon as we tell the configuration about it, but have not told the
    configuration about the new related options.
    
    This moves the including of the module until after we have told the
    configuration about the dependent options.
    
    This includes a spec which is named in a manner to attempt to ensure it
    is the first spec loaded by rspec-core; which loads spec files
    alphabetically. To ensure we test the issue the run script is updated to
    also run this spec file standalone.
    
    When discussing #1355 it was agreed that we need to
    consider removing this global inclusion of the fixture support. Instead
    favoring including it in the `RailsExampleGroup`. A deprecation comment
    has been included to remind us later.
  4. Fix action mailer preview path setup.

    cupakromer committed Feb 23, 2015
    This removes the unnecessary warning about a preview path set to a
    location other than `/spec/mailers/preview`.
    
    This does not force `ActionMailer` to load when the Railtie runs by
    removing the `defined?` check. This is necessary because the
    `ActionMailer` class only loads it's settings once, after it is first
    loaded. If we load the class in our Railtie any custom settings declared
    in a config block in an initializer will be ignored.
    
    An improved spec suite for the different permutations of availability of
    action mailer previews is included as well.
  5. If a view example's description contains no path elements, then do no…

    tinynumbers authored and cupakromer committed Jan 23, 2015
    …t attempt to load a helper based on the example description.
Commits on Feb 24, 2015
  1. Release 3.2.1.

    myronmarston committed Feb 24, 2015
Commits on Feb 23, 2015
  1. Disable the test-unit gem autorunner.

    cupakromer committed Feb 21, 2015
    For some reason the test-unit gem loads it's autorunner by default.
    Though the test-unit included with Ruby does not. The original code for
    loading test-unit pre-dates widespread usage of the test-unit gem.
    
    We took care of disabling the autorunner for Ruby 2.2+ since the
    test-unit gem is now required for Rails 3.2. For older Ruby versions we
    attempt to only load the `test/unit/assertions` module. When using the
    `test-unit` gem however, Rails will auto require it for us, which loads
    the main test-unit code, thus enabling the autorunner.
Commits on Feb 21, 2015
  1. Merge pull request #1319 from rspec/backport-bug-fixes

    cupakromer committed Feb 21, 2015
    Backport pull requests #1303, #1305, #1310, #1318
  2. Update Changelog with #1318.

    cupakromer committed Feb 21, 2015
    [ci skip]
  3. Relax `rails` dependency constraint to support the `4.2.x` releases.

    lucasmazza authored and cupakromer committed Feb 21, 2015
    The previous constraint would only go as up as `4.2.0`, thus making `rspec-rails`
    incompatible with any of the patch releases of the rails 4.2.x series.
  4. changelog for #1310

    JonRowe authored and cupakromer committed Feb 14, 2015
    [skip ci]
  5. defines BeRoutableMatcher#description

    tonyta authored and cupakromer committed Feb 13, 2015
    overrides RSpec::Matchers::BuiltIn::BaseMatcher#description to
    return the description "be routable" instead of "be routable matcher"
  6. Add missing `require` to RSpec generator root

    cupakromer committed Feb 10, 2015
    Fix #1301.
    
    This fixes an issue where Rail's autoload does not find it in some
    environments.
Commits on Feb 3, 2015
  1. Revert "Bump version to 3.3.0.pre"

    myronmarston committed Feb 3, 2015
    This reverts commit ed975be.
  2. Release 3.2.0

    myronmarston committed Feb 3, 2015
Commits on Feb 2, 2015
  1. Merge pull request #1295 from rspec/fix-issue-1294

    cupakromer committed Feb 2, 2015
    Remove unnecessary code 💀
  2. Remove unnecessary code 💀

    cupakromer committed Feb 2, 2015
    The matchers no longer attempt to use `AssertionFailedError` instead
    they use `ActiveSupport::TestCase::Assertion`.
    
    Fix #1294