Permalink
Switch branches/tags
Commits on Aug 11, 2017
  1. Release v3.6.1

    yujinakayama committed Aug 11, 2017
Commits on Jul 25, 2017
  1. Changelog for #1831

    JonRowe authored and yujinakayama committed Jun 30, 2017
  2. Fix noisy log error (#1831)

    sj26 authored and yujinakayama committed Jun 30, 2017
    * Fix noisy log error
    
    We've been seeing this error in our test logs:
    
        Could not log "render_template.action_view" event.
        NoMethodError: undefined method `example_group' for nil:NilClass
        .../rspec-rails-3.6.0/lib/rspec/rails/view_rendering.rb:67:in `current_example_group'
        .../rspec-rails-3.6.0/lib/rspec/rails/view_rendering.rb:71:in `render_template'
        ...
    
    This is while running an rspec rails feature spec using capybara, so
    this is a separate thread running webrick. This was also during a before
    block. In any case, this should probably fail gracefully when there is
    no example.
    
    While updating this code I got an "ExampleGroup doesn't respond to
    render_views?", so built in that case too.
    
    * Throw away the LogSubscriber and just log explicitly
Commits on May 10, 2017
  1. Changelog for #1814

    JonRowe committed May 10, 2017
Commits on May 5, 2017
Commits on May 4, 2017
  1. Releases 3.6.0

    samphippen committed May 4, 2017
Commits on Apr 28, 2017
Commits on Apr 22, 2017
  1. Merge pull request #1807 from rspec/add-5.1.0.rc2-to-travis

    samphippen committed Apr 22, 2017
    Replace 5.1.0.rc1 with 5.1.0.rc2 in travis matrix
Commits on Apr 19, 2017
  1. Merge pull request #1803 from rspec/myron/make-new-record-matchers-co…

    myronmarston committed Apr 19, 2017
    …nsistent
    
    Consistently use `record.new_record?`.
  2. Consistently use `record.new_record?`.

    myronmarston committed Apr 18, 2017
    `be_a_new(model_class)` and `be_new_record` were
    inconsistent in that one of them checked `!persisted?`
    and one checked `new_record?`. The docs also said that
    both checked `!persisted?` even only one did.
    
    This changes both to use `new_record?` and to be documented
    as such.
    
    Fixes #1801.
Commits on Apr 11, 2017
  1. Merge pull request #1710 from rspec/fix-http-method-arg-error-on-olde…

    yujinakayama committed Apr 11, 2017
    …r-rails
    
    Use keyword args for HTTP methods in controller specs only on Rails 5
Commits on Apr 10, 2017
  1. Use keyword args for HTTP methods in controller specs only on Rails 5

    yujinakayama committed Sep 30, 2016
    Since Rails 5 does not support Ruby 1.8,
    we no longer need to check RUBY_VERSION.
    
    This closes #1669.
Commits on Apr 9, 2017
  1. Merge pull request #1790 from rspec/rails-5.1-compat

    samphippen committed Apr 9, 2017
    Rails 5.1 compatibility
Commits on Apr 2, 2017
  1. Review tweaks

    samphippen committed Apr 2, 2017
Commits on Mar 28, 2017
  1. Changelog for #1795

    JonRowe committed Mar 28, 2017
  2. Load spec_helper before Rails (#1795)

    kjg authored and JonRowe committed Mar 28, 2017
    so that things in spec_helper, especially coverage tools,
    have a chance to load before the Rails code loads
Commits on Mar 26, 2017
  1. Merge pull request #1799 from rspec/myron/tweaks

    samphippen committed Mar 26, 2017
    Audit tweaks
  2. No need to re-include RSpec::Rails::Matchers.

    myronmarston committed Mar 26, 2017
    It is included in all groups automatically.
Commits on Mar 25, 2017
  1. Fix scaffold generator

    samphippen committed Mar 25, 2017
  2. Get cukes passing on 5.1

    samphippen committed Mar 25, 2017
  3. Ensure on Rails 5 and above we don't use `render :text`.

    samphippen committed Mar 25, 2017
    `render :text` has been deprecated for a while now, and is removed in
    rails 5.1. It has been replaced by either `render :plain` or `render
    :html` (depending on which `Content-Encoding` header you want). This
    patch uses our existing cucumber tags `@rails_pre_5` and `@rails_post_5`
    to switch which we use depending on the Rails verison. We can't simply
    replace all the references here because Rails 3 does not have this
    option.
Commits on Mar 24, 2017
  1. Merge pull request #1797 from yui-knk/rails51rc1

    samphippen committed Mar 24, 2017
    Bump up Rails version to 5.1.0.rc1
  2. Omit an id attribute from "scaffold/templates"

    yui-knk committed Mar 24, 2017
    From Rails 5.1, a form view which is generated by scaffold command
    uses `form_with`.
    `form_with` does not append id attribute for form tags or input tags.
    So our templates should not use id selectors.
    
    rails/rails@d3b798b
Commits on Feb 24, 2017
  1. Use `app:template` instead of `rails:template` in Rails 5.1

    samphippen committed Feb 24, 2017
    Rails 5.1 removes `rails:template` in favour of `app:template` to
    generate templates. This change sets our rakefile up to usee the
    `app:template` command if the rails version is greater than or equal to
    5.1
Commits on Jan 31, 2017
  1. dont run acceptance step on 1.8.7 due to segfaults (#1769)

    JonRowe committed Jan 31, 2017
    1.8.7 is now segfaulting reliably for cucumber, and our smoke tests so we skip
Commits on Jan 30, 2017