Permalink
Switch branches/tags
Commits on Mar 26, 2018
Commits on Feb 16, 2018
  1. Changelog for #1955

    JonRowe committed Feb 16, 2018
    [skip ci]
  2. Merge pull request #1955 from shanecav84/patch-1

    JonRowe committed Feb 16, 2018
    Substitute quotes with underscores for method name
Commits on Nov 20, 2017
  1. Update version to 3.7.2

    JonRowe committed Nov 20, 2017
  2. Changelog for #1903 and #1907

    JonRowe committed Nov 16, 2017
  3. Fix system test screenshots for aggregate failures

    mattbrictson authored and JonRowe committed Nov 6, 2017
    If RSpec's `:aggregate_failures` is enabled, a system spec with a failed
    expectation would not automatically trigger a screenshot as expected.
    
    This is because aggregated failures are not exposed via the typical
    `RSpec.current_example.exception`. To correctly detect failures when
    aggregation is enabled, we have to do more work.
    
    This commit works around this problem by using some behind-the-scenes
    knowledge of how rspec-expectations does the aggregation. Now we reach
    into the thread-local storage (`RSpec::Support.failure_notifier`) and
    discover whether there are in fact failures "queued up". If so, we will
    consider the example to have failed and take a screenshot.
    
    This is the same workaround as used by capybara-screenshot:
    mattheworiordan/capybara-screenshot#213
  4. Fix "uninitialized constant Gem" and other Travis errors (#1914)

    mattbrictson authored and JonRowe committed Nov 15, 2017
    * Fix RuboCop violation
    
    * Update test harness for Bundler 1.16 compatibility
    
    This commit fixes Travis failures due to the recent introduction of
    Bundler 1.16.0. Both are related to the new style of binstubs that are
    generated by 1.16.0.
    
    First, add `bundler` to the list of binstubs that we explicitly generate
    when creating the test Rails app. The `bin/bundle` binstub that ships as
    part of `rails new` is in the pre-1.16 format, and conflicts with the
    1.16 format binstubs that are generated for rake and rspec. Fix this by
    replacing the default `bin/bundle` with a fresh one generated by
    `bundle binstubs bundler --force`.
    
    Second, the `Bundle.with_clean_env` wrapper seems to remove some
    important information from the environment that causes binstubs to fail
    with errors like `uninitialized constant Gem (NameError)`. Fix this by
    using `Bundle.with_original_env` instead (which is what the Bundler
    documentation recommends). Because Travis also sets its own
    `BUNDLER_GEMFILE` variable, I had to also reset that one manually.
    
    * Choose cuke tags based on correct RAILS_VERSION
    
    * Travis needs doc gems in order to run bin/yard
    
    * Add --no-rc flag for more reliable local testing
    
    The rspec-rails acceptance tests use `rails new` to generate a sample
    app for running tests. If a developer running the rspec-rails test suite
    has a `.railsrc` file, this will affect the app that is generated,
    causing specs to fail.
    
    This commit fixes this by passing the `--no-rc` flag so that `rails new`
    ignores the developer's local `.railsrc`.
  5. Improve doc about Job specs & Rails versions matrix (#1886)

    cbliard authored and JonRowe committed Nov 15, 2017
    * Improve doc about Job specs & rails versions matrix
    
    * Add System specs information in doc
    
    * doc: add links from directory structure feature to other features
    
    * doc: simpler links to other features
  6. Fix failing sanity check spec under latest bundler (#1912)

    mattbrictson authored and JonRowe committed Nov 14, 2017
    Relax the regexp for matching the expected "uninitialized constant"
    error to fix this spec failure when running on Bundler 1.16.0 and Ruby
    2.4.2:
    
    expected "NameError: uninitialized constant RSpec::Support"
    to match /uninitialized constant RSpec::Support \(NameError\)/
  7. Refactor system test integration (delay loading). (#1903)

    JonRowe committed Nov 9, 2017
    Delay loading system tests as late as possible in order to allow
    people who arent using them to not have to turn off puma or other
    such things. It also enables other webservers to be configured other
    than puma which is needed in Rails as of
    rails/rails@50f6976
  8. Follow updated ruby versions in the matrix (#1906)

    kachick authored and JonRowe committed Nov 9, 2017
    * Follow updated ruby versions in the matrix
    
    * Keep 2.2.n matrix as before
  9. Check for puma and capybara when defining system tests (#1893)

    JonRowe committed Oct 25, 2017
    * Check for puma and capybara when defining system tests
    
    Rather than skipping the definition altogether define a fake module that
    warns about the dependencies.
    
    * If we can't load system_test_case for some reason we cant run system tests
    
    As per @mockdeep's conversation in #1889 other dependencies might not
    allow us to even load system_test_case so we fallback to our original
    strategy for now.
  10. Update Changelog for 3.7.1 (#1888)

    pwim authored and JonRowe committed Oct 19, 2017
Commits on Oct 18, 2017
  1. Release version 3.7.1

    samphippen committed Oct 18, 2017
  2. Fix puma loading in Rails 5.1 (#1884)

    samphippen committed Oct 18, 2017
    * Fix puma loading in Rails 5.1
    
    * Prevent system tests loading without capybara
    
    * Allow rescuing exceptions for system test
    
    * Fix rubocop lints
Commits on Oct 17, 2017
  1. Releases 3.7.0

    samphippen committed Oct 17, 2017
Commits on Sep 15, 2017
  1. Merge pull request #1874 from rspec/update-travis-build-scripts-2017-…

    yujinakayama committed Sep 15, 2017
    …09-15-for-master
    
    Updates from rspec-dev (2017-09-15)
Commits on Sep 14, 2017
  1. Fix #1865 by memoizing generated method name. (#1872)

    samphippen committed Sep 14, 2017
    The problem here is that rails calls `#method_name` on the example a
    number of times in order to correctly generate the screenshot and then
    manipulate it. Given that we were randomising the integer that was
    generated on every call, this didn't work.
    
    This patch solves the problem by memoizing the generated method name so
    that the screenshot path is generated once per example and then
    correctly accessed on subsequent method calls.
Commits on Sep 11, 2017
Commits on Sep 9, 2017
  1. Merge pull request #1867 from RustyNail/patch-1

    xaviershay committed Sep 9, 2017
    Fix typo in Gemfile
  2. Fix typo in Gemfile

    RustyNail committed Sep 9, 2017
Commits on Aug 29, 2017
  1. Fix broken Gemfile

    JonRowe committed Aug 29, 2017
Commits on Aug 26, 2017
  1. Merge pull request #1864 from rspec/pin-byebug

    samphippen committed Aug 26, 2017
    Pin byebug to '~> 9.0.6' for ruby 2.0.
  2. Pin byebug to '~> 9.0.6' for ruby 2.0.

    samphippen committed Aug 26, 2017
    Byebug `9.1.0` released pinned to ruby 2.2. We need to support ruby 2.0,
    so here we add a gsub to pin to byebug versions that support 2.0.
  3. Merge pull request #1839 from rlue/master

    samphippen committed Aug 26, 2017
    Discourage controller specs in README