Permalink
Switch branches/tags
Commits on Jun 30, 2017
  1. Changelog for #1831

    JonRowe committed on GitHub Jun 30, 2017
  2. Fix noisy log error (#1831)

    * Fix noisy log error
    
    We've been seeing this error in our test logs:
    
        Could not log "render_template.action_view" event.
        NoMethodError: undefined method `example_group' for nil:NilClass
        .../rspec-rails-3.6.0/lib/rspec/rails/view_rendering.rb:67:in `current_example_group'
        .../rspec-rails-3.6.0/lib/rspec/rails/view_rendering.rb:71:in `render_template'
        ...
    
    This is while running an rspec rails feature spec using capybara, so
    this is a separate thread running webrick. This was also during a before
    block. In any case, this should probably fail gracefully when there is
    no example.
    
    While updating this code I got an "ExampleGroup doesn't respond to
    render_views?", so built in that case too.
    
    * Throw away the LogSubscriber and just log explicitly
    sj26 committed with JonRowe Jun 30, 2017
Commits on May 28, 2017
  1. Add changelog for #1811.

    myronmarston committed May 28, 2017
  2. Merge pull request #1811 from britnia/issue_1801_inconsistent_matcher…

    …_behavior
    
    Allow use of composable matchers inside be_a_new#with
    myronmarston committed on GitHub May 28, 2017
Commits on May 20, 2017
Commits on May 18, 2017
  1. Ensure that failure messages accurately reflect matchers and remove r…

    …egex matching from expectations
    britnia committed with britnia May 17, 2017
Commits on May 13, 2017
  1. Correct return value of `path_for` in documentation (#1815)

    Guess people forget this when working on #1402
    #1402
    hlcfan committed with JonRowe May 13, 2017
Commits on May 10, 2017
  1. Changelog for #1814

    JonRowe committed on GitHub May 10, 2017
Commits on May 5, 2017
  1. Bump version to 3.7.0.pre

    samphippen committed May 5, 2017
Commits on May 4, 2017
  1. Releases 3.6.0

    samphippen committed May 4, 2017
Commits on Apr 28, 2017
Commits on Apr 22, 2017
  1. Merge pull request #1807 from rspec/add-5.1.0.rc2-to-travis

    Replace 5.1.0.rc1 with 5.1.0.rc2 in travis matrix
    samphippen committed on GitHub Apr 22, 2017
Commits on Apr 19, 2017
  1. Merge pull request #1803 from rspec/myron/make-new-record-matchers-co…

    …nsistent
    
    Consistently use `record.new_record?`.
    myronmarston committed on GitHub Apr 19, 2017
  2. Consistently use `record.new_record?`.

    `be_a_new(model_class)` and `be_new_record` were
    inconsistent in that one of them checked `!persisted?`
    and one checked `new_record?`. The docs also said that
    both checked `!persisted?` even only one did.
    
    This changes both to use `new_record?` and to be documented
    as such.
    
    Fixes #1801.
    myronmarston committed Apr 18, 2017
Commits on Apr 11, 2017
  1. Merge pull request #1710 from rspec/fix-http-method-arg-error-on-olde…

    …r-rails
    
    Use keyword args for HTTP methods in controller specs only on Rails 5
    yujinakayama committed on GitHub Apr 11, 2017
Commits on Apr 10, 2017
  1. Use keyword args for HTTP methods in controller specs only on Rails 5

    Since Rails 5 does not support Ruby 1.8,
    we no longer need to check RUBY_VERSION.
    
    This closes #1669.
    yujinakayama committed Sep 30, 2016
Commits on Apr 9, 2017
  1. Merge pull request #1790 from rspec/rails-5.1-compat

    Rails 5.1 compatibility
    samphippen committed on GitHub Apr 9, 2017
Commits on Apr 2, 2017
  1. Review tweaks

    samphippen committed Apr 2, 2017
Commits on Mar 28, 2017
  1. Changelog for #1795

    JonRowe committed on GitHub Mar 28, 2017
  2. Load spec_helper before Rails (#1795)

    so that things in spec_helper, especially coverage tools,
    have a chance to load before the Rails code loads
    kjg committed with JonRowe Mar 28, 2017
Commits on Mar 26, 2017
  1. Merge pull request #1799 from rspec/myron/tweaks

    Audit tweaks
    samphippen committed on GitHub Mar 26, 2017
  2. No need to re-include RSpec::Rails::Matchers.

    It is included in all groups automatically.
    myronmarston committed Mar 26, 2017
Commits on Mar 25, 2017
  1. Fix scaffold generator

    samphippen committed Mar 25, 2017
  2. Get cukes passing on 5.1

    samphippen committed Mar 25, 2017
  3. Ensure on Rails 5 and above we don't use `render :text`.

    `render :text` has been deprecated for a while now, and is removed in
    rails 5.1. It has been replaced by either `render :plain` or `render
    :html` (depending on which `Content-Encoding` header you want). This
    patch uses our existing cucumber tags `@rails_pre_5` and `@rails_post_5`
    to switch which we use depending on the Rails verison. We can't simply
    replace all the references here because Rails 3 does not have this
    option.
    samphippen committed Mar 25, 2017
Commits on Mar 24, 2017
  1. Merge pull request #1797 from yui-knk/rails51rc1

    Bump up Rails version to 5.1.0.rc1
    samphippen committed on GitHub Mar 24, 2017