Skip to content
This repository
  • 640 commits
  • 160 files changed
  • 34 contributors
This comparison is big! We're only showing the most recent 250 commits
Aug 28, 2011
David Chelimsky Merge pull request #431 from marcweil/master
Parse query parameters and pass them to assert_recognizes
David Chelimsky let Rack::Utils parse the query string in route_to matcher 736e496
David Chelimsky changes ceeed7a
Aug 29, 2011
Marc G Gauthier Use Github Flavored Markdown d023586
David Chelimsky Merge pull request #432 from marcgg/colored-readme
Use Github Flavored Markdown for the README
David Chelimsky Revert "Use Github Flavored Markdown"
Nice idea, but it breaks display in other environments.

This reverts commit d023586.
Aug 31, 2011
David Chelimsky ci: run against production release of rails 3.1.0 2008531
Sep 01, 2011
Andy Lindeman Fix mistake in check to see if ActiveRecord is defined 38c0faa
Justin Ko Merge pull request #434 from alindeman/ar_relation_match_array
Fix mistake in check to see if ActiveRecord is defined
Sep 05, 2011
David Chelimsky Define primary_key method on class generated by mock_model("WithAStri…

- Closes #435.
Sep 06, 2011
David Chelimsky use rake 0.9.2 346b0a2
David Chelimsky dev: no need to update what we just loaded 9a92b75
Sep 23, 2011
Andrei Maxim Use the correct Travis status icon URL 5dce44c
Justin Ko Merge pull request #444 from xhr/master
Use the correct Travis CI status image URL
Justin Ko Fixed incorrect documentation for stub_model. Thanks Evgeniy Dolzhenko. 1b8c886
Oct 02, 2011
David Chelimsky ci: add journey to gemfile for rails master 68cb4ea
David Chelimsky dev: add association IDs for rails 3.2 d85e787
Oct 04, 2011
David Chelimsky ci: add rails 3.1.1 and ruby 1.9.3 to travis config 45aca2a
Oct 06, 2011
David Chelimsky ci: bump rails 3.1.1 to rc3 5649a36
Oct 09, 2011
David Chelimsky ci: run against rails 3.1.1 final 4a1cb78
David Chelimsky bump to 2.7.0.rc1 aea643f
David Chelimsky bump relish version to ~> 0.5.0 46cb9f8
Oct 16, 2011
David Chelimsky config yard 2f8ea66
David Chelimsky cleanup and add some rdoc 6ab0bb6
David Chelimsky update changelog for 2.7.0 release 9ed59a5
David Chelimsky bump version to 2.7.0 90746f9
David Chelimsky fix formatting problems in the changelog 59a41f6
Oct 20, 2011
Attila Györffy Fix typo in the upgrade instructions. 4a0a855
Attila Györffy Use .to_param instead of .id in controller spec templates.
Action Pack uses to_param for constructing an URL to objects. The default implementation returns this record’s id as a String. This way even if to_param is overridden in an ActiveRecord object, the controller spec templates are going to still work.
Oct 25, 2011
Justin Ko Allow generator specs to work with --default_path 1416314
Justin Ko Set default order to :random b6022dc
Justin Ko Fix order-dependent spec 0b9b153
Justin Ko Don't match on rake loaded files 364fbb0
Oct 29, 2011
David Chelimsky align config extensions with changes to rspec-core planned for 2.8 48d4cd3
Oct 30, 2011
David Chelimsky Merge pull request #458 from pda/master
Remove config.mock_with :rspec, avoid config-after-examples error.
Oct 31, 2011
Paul Annesley Removed unnecessary "config.mock_with :rspec" from spec_helper.rb
This statement configures RSpec to do what it would do anyway, and
triggers errors regarding RSpec.configure being called after examples
have been defined.

See: rspec/rspec-rails#371
See: rspec/rspec-core#455
David Chelimsky dev: ruby-debug19 versions 3ba3a49
David Chelimsky fix bug where namespaced generators were falling down 1b1c181
Nov 06, 2011
David Chelimsky changelog 2fa4bc7
David Chelimsky bump to 2.8.0.rc1 b8b7dd9
Nov 08, 2011
Jared Grippe restored the ability to use method missing matchers like be_blank or …
…be_true in before blocks for routing example groups
David Chelimsky update License and/or authors in gemspec b50073f
David Chelimsky update email addy and homepage in gemspec 08ceb6f
Nov 20, 2011
David Chelimsky rdoc 130c94f
David Chelimsky dev: much simpler management of multiple gemfiles 5687b8d
David Chelimsky ci: the last commit broke our travis config - going for all 3.1.1 for
now but need to revisit.
David Chelimsky ci: check an env variable before .rails-version 342313f
David Chelimsky ci: move file refs 012cee7
David Chelimsky ci: 3.1.3 568030e
David Chelimsky ci: point rails master build at arel on github b80af68
David Chelimsky ci: rails 3.0.11 874f047
David Chelimsky change describes (deprecated) to described_class c0cfb51
Nov 21, 2011
David Chelimsky refactor a couple of matchers to use rspec-expectation's new BaseMatcher f963a5b
David Chelimsky doc: remove comment about Capyabara matchers not being available in v…
…iew specs

- #302
David Chelimsky dev: reference 3.1.3 instead of 3.1.1 af3ff6e
David Chelimsky convert remaining matchers to classes (faster) and document them ffd6c07
David Chelimsky cleaner scoping
- def classes/modules in RSpec::Rails::Matchers instead of
- less opening classes/more includuing modules
Nov 22, 2011
David Chelimsky constrain ammeter dependency to :test group
It was causing some trouble running generators when it was in the
development group as well.
David Chelimsky dev: don't clobber the Gemfile.lock file
That gets handled by running "thor version:use x.x.x" and it is
inconvenient to have to install the bundle every time we're trying to
clean up generated files.
David Chelimsky require 'rspec/rails/matchers' to (temp) resolve circular dep between…
… rspec-rails' specs and ammeter
David Chelimsky more rdoc 620b7f3
David Chelimsky small rdoc tweak e26fb34
David Chelimsky rdoc: correct indentation helps (markdown) 78c7548
David Chelimsky git ignore DS_Store 2fbef9d
Nov 24, 2011
David Chelimsky BaseMatcher now implements match_unless_raises b24cc69
Nov 25, 2011
David Chelimsky dev: hack the Gemfile to print instructions for ruby-debug-base19 and…
… linecache19 on ruby-1.9.3
David Chelimsky ci: don't warn about ruby-debug-base19 and linecache19 in ci 9b72cf9
David Chelimsky dev: move dev-env gems to Gemfile-custom.sample 3b7452b
Dec 01, 2011
Jason M. Kusar Check to see if the module we're actually working with is loaded (in …
…case only pieces of ActiveRecord are loaded).
Jason M. Kusar Check to see if the module we're actually working with is loaded (in …
…case only pieces of ActiveRecord are loaded).
David Chelimsky Merge pull request #467 from jkusar/master
Check to see that the necessary sub-modules are actually loaded before extending
Dec 02, 2011
David Chelimsky add DEV-README 49d7ae7
David Chelimsky add license to gemspec (and consequently the gem) c954554
Dec 03, 2011
David Chelimsky Merge pull request #460 from deadlyicon/patch-1
define @routes on demand instead of in before hook (ensures they are present for before hooks that might run earlier)
David Chelimsky Merge pull request #454 from liquid/master
Use to_param in scaffold spec templates
Dec 04, 2011
David Chelimsky use github-flavored-markdown in the readme 1bec8ff
David Chelimsky include changelog and license in generated rdoc c5c576b
David Chelimsky Revert "restored the ability to use method missing matchers like be_b…
…lank or be_true in before blocks for routing example groups"

This reverts commit c1c2f60.

Unfortunately, there is code outside rspec's control that refers
directly to the instance variable, so this change ends up breaking more
than it fixes.

- Reopens #460.
David Chelimsky rdoc 9bf3e32
Dec 07, 2011
Igor Afonov Stub attribute accessor after respond_to? call on mocked model. Fixes #… 9a23ba1
David Chelimsky Changelog for #437 88137f2
David Chelimsky rdoc for bypass_rescue 4c7fd73
Igor Afonov Take 2 on stubbing attribute accessor after respond_to? call on mocke…
…d model. Fixes #437.
David Chelimsky Implement method_missing on mock model's proxy object rather than
stubbing upon respond_to?

- #437
Thiago James Pinto Restricted controllers tested with more readability 7b377c1
David Chelimsky Changelog for #464 ad5e580
David Chelimsky Consolidate rdoc for example groups to README 80febb5
Dec 08, 2011
David Chelimsky more rdoc cleanup c1f0eab
David Chelimsky rdoc 0e6b185
Dec 19, 2011
David Chelimsky Move instance methods from InstanceMethods modules to stop deprecation
warnings from ActiveSupport-3.2
David Chelimsky ci: add rails-3.2.0.rc1 8b0eb72
David Chelimsky prep for 2.8.0.rc2 13b699f
Dec 20, 2011
David Chelimsky Remove handler and template engine from file names in generated view

- This eliminates deprecation warnings from rails 3.2, and still works
  with earlier 3.x versions.
David Chelimsky changelog for previous commit 1ac8709
Evgeniy Dolzhenko Ensure namespaced helpers are included automatically
-- Closes #446.
David Chelimsky Merge pull request #415 from alanshields/document-anonymous-controlle…

Document what actions are made available in an anonymous controller
David Chelimsky Changelog and remove .intern (send doesn't care) c4df12e
John Wulff add description method to RSpec::Rails::Matchers::RoutingMatchers::Ro…
David Chelimsky beef up README section on Request Specs 6a87a0b
Dec 21, 2011
Nathan Broadbent request.path_parameters 'controller' and 'action' keys should be symb…
…ols, since they are symbols in the real Rails environment.
David Chelimsky ci: add rails 3-2-stable and fix support for rails master
- Rails master version is now 4.0.0.beta.
- temp point ammeter at dchelimsky/ammeter to handle rails 4.
David Chelimsky ci: rails 4 requires 1.9.3 320ea0f
Dec 22, 2011
John Wulff Add spec RSpec::Rails::Matchers::RoutingMatchers::RouteToMatcher desc…
Jan 04, 2012
David Chelimsky bump rails version to 3.2.0.rc2 ff79b8e
David Chelimsky bump to 2.8.0 0fd5bf4
David Chelimsky Explicitly stub valid? in stub_model.
This fixes a bug in stub_model that appeared with the rails-3.2.0.rc2
release, which means that people who use stub_model will have to upgrade
to the next rspec-rails release (2.8.1) when they upgrade to rails-3.2.
David Chelimsky Changelog for previous commit and bump to 2.8.1 8ed140d
Jan 08, 2012
jwow313 Capybara uses :text, not :content as the option to have_selector. Any…
…thing passed via :content is ignored entirely, leading to lots of incorrectly passing tests. The docs should reflect this, as this is pretty confusing. See this Capybara issue for more details: jnicklas/capybara#525
Justin Ko Merge pull request #479 from jwow313/master
Readme update for Capybara syntax
Jan 11, 2012
Nathan Broadbent Added cucumber test to ensure that controller.request.path_parameters…
… contains symbols for keys
Jan 12, 2012
Will Farrington Update for rspec-expectations compatibility. 98be115
Jan 18, 2012
David Chelimsky Merge pull request #482 from wfarr/master
Updates for compatibility with rspec-expectations
David Chelimsky use ammeter from git (has fix for deprecation warnings on InstanceMet…
David Chelimsky mock_model(XXX).as_null_object.unknown_method returns self
- Fixes #488.
David Chelimsky Merge pull request #473 from jwulff/add_description_to_route_to_matcher
Add description method to route_to matcher
David Chelimsky Changelog for #473.
Also aligned the example with others in the spec.
David Chelimsky dev: add -w when running rake spec 2ffa9fb
David Chelimsky Funny thing, but turning on warnings produces a bunch of warnings. Mo…
…stly gone now.
Jan 21, 2012
Justin Reid Fix method name type 'click_buton' 03a2f6f
David Chelimsky Merge pull request #490 from reidreid46/master
Fix typo in readme: 'click_buton' to 'click_button'
Jan 24, 2012
David Chelimsky ci: run against rails 3.2.0 acfe944
Thiago James Pinto this commented line should not be inside a loop 4ca7614
David Chelimsky Use .inspect on hashes in descriptions for Ruby 1.8.7.
- #473.
David Chelimsky Merge pull request #493 from yakko/no_more_repeating_webrat
this commented line should not be inside a loop
David Chelimsky ci: point Gemfile at git for journey gem for rails 3-2-stable 53644fc
Jan 26, 2012
David Chelimsky ci: rails 3.2.1 50a27f2
Feb 01, 2012
David Chelimsky remove rendering engine and mime type from calls to describe and rend…
…er in docs and cukes
Feb 12, 2012
David Chelimsky Generated view specs use different IDs for each attribute.
- Fixes #504.
Justin Ko Use #next 1e2ac19
Feb 14, 2012
David Chelimsky ci: experiment with new travis feature to allow failures when running…
… against dev branches of rails
Feb 20, 2012
Matthew Lineen Update 6207edc
Justin Ko Merge pull request #506 from mlineen/patch-1
Feb 27, 2012
David Chelimsky ci: add rails-3.2.2.rc1 c873d34
David Chelimsky Make specs about messages more tolerant of inconsistent ordering char…
…acteristics of different rubies.
David Chelimsky ci: extend aruba timeout to 30 secs acef5dc
Mar 01, 2012
David Chelimsky ci: run against released rails-3.2.2 4f747d7
Mar 07, 2012
David Chelimsky ci: bump to latest rails patch releases d05b9a8
Andrey Voronkov Make rspec to copy schema structure if schema format is :sql. 6d726b5
Justin Ko Merge pull request #517 from Antiarchitect/patch-1
Make rspec to copy schema structure if schema format is :sql.
Justin Ko changelog ddccef1
Justin Ko Use name instead of handle 46a1a60
Mar 11, 2012
David Chelimsky dev: upgrade Cucumber, Aruba and ZenTest 4bc0843
David Chelimsky bump to 2.9.0.rc1 a52573e
Mar 12, 2012
David Chelimsky align gemspec with other rspec libs 5f9b860
David Chelimsky bump to 2.9.0.rc2 4850973
Mar 16, 2012
David Chelimsky require 'rspec/expectations' to ensure that 'should' is defined 5e1b8a2
Mar 17, 2012
David Chelimsky bump to 2.9.0 9f976cb
David Chelimsky Merge branch '2-9-maintenance'
* 2-9-maintenance:
  bump to 2.9.0
David Chelimsky dev: add a script to download ruby-debug-base19-0.11.26.gem and linec…
…ache19-0.5.13.gem to a local cache

[ci skip]
Justin Ko Use Cucumber's 'step' method to remove deprecation warnings. ed5787d
Justin Ko Use --skip-test-unit e833a27
David Chelimsky changlog formatting tweaks 6b7adaf
Mar 30, 2012
Martin Svalin Let local render_views override global setting
If render_views is enabled globally in the spec_helper, it clobbers attempts to disable it locally for specific examples due to the false || true logic.

Instead, only use the global setting if no local render_views was provided.
Justin Ko Merge pull request #522 from martinsvalin/render_views
Let local render_views override global setting
Justin Ko Use Hash#fetch 72b6d52
Justin Ko Changelog for #522 002f1da
Mar 31, 2012
Grant Hutchins Add Rails 3.2.3 to Travis CI matrix 74deef3
Apr 01, 2012
Justin Ko Merge pull request #524 from nertzy/rails_3.2.3_in_travis
Add Rails 3.2.3 to Travis CI matrix
Justin Ko Dev: fix build by allowing mass assignment for an attribute b11800f
Apr 03, 2012
David Chelimsky remove obsolete guard against building gems in ruby 1.9.3 dbcdcf7
Apr 08, 2012
David Chelimsky use prepend_before for rails' test adapter
- Fixes #391.
- Needs to be released with or after addition of prepend_before to
Apr 13, 2012
Justin Ko typo [ci skip] 3562f8f
Jonathan del Strother Fix rendering deprecations in view specs
render(:template=>'new.erb') is now deprecated and should be render(:template=>'new', :handlers=>['erb']).  This patch takes the default template name supplied in the spec and breaks it up into its separate components before calling render().
Apr 18, 2012
Justin Ko Fix render_views for anonymous controllers on 1.8.7. Closes #525 10bba44
Apr 19, 2012
David Chelimsky route_to matcher captures ActionController::RoutingError as well as
Assertion failures.

- Fixes #530.
Apr 21, 2012
David Chelimsky dev: update Gemfile f03065c
David Chelimsky Eliminate use of deprecated process_view_paths.
- Fixes #519.
David Chelimsky doc more changes in Changelog [ci skip] 3c09c4b
Apr 22, 2012
David Chelimsky align config files across rspec projects d691d05
David Chelimsky dev: align Gemfiles across rspec projects e1fd5b6
David Chelimsky Merge pull request #463 from ndbroadbent/fix_path_parameters
Change request.path_parameters keys to symbols to match real Rails environment
David Chelimsky Changelog for #463 [ci skip] 89da19c
David Chelimsky Merge pull request #529 from jdelStrother/render_args
Fix rendering deprecations in view specs
David Chelimsky Changelog for #529 [ci skip] 040f6a9
David Chelimsky ci: without --without development 7ce7d07
David Chelimsky fix cuke broken by #461 3ad5d8a
Apr 26, 2012
David Chelimsky minor Changelog tweak [ci skip] 4623ad1
Apr 28, 2012
Matt Parker Fix typo in README (Articles -> Article) 70dfecd
Myron Marston Merge pull request #532 from moonmaster9000/patch-1
Fix typo in README (Articles -> Article)
Apr 30, 2012
David Chelimsky update yard to 0.8 aea719d
May 03, 2012
Mike Breen Update with the latest version of rspec_rails. 2dc13e8
Mike Breen Change it to 2.0 based on comments by @dchelimsky. 2e2bb32
David Chelimsky Merge pull request #533 from hardbap/patch-1
Update with the latest version of rspec_rails.
David Chelimsky update changelog for 2.10 release c48da4c
David Chelimsky bump to 2.10.0 93e4eec
May 05, 2012
David Chelimsky Only prepend_before the Rails setup methods
- Fixes #534
- Unfortunately depends on names of methods that are internal to Rails
  and subject to change. Fingers crossed.
David Chelimsky ci: add active_record_deprecated_finders to Gemfile so we can run aga…
…inst Rails' master
David Chelimsky dev: bump ammeter to 0.2.5 b6e3ae3
David Chelimsky bump to 2.10.1 63a9efd
May 09, 2012
David Chelimsky dev: refactor a spec 0677052
May 10, 2012
Dan Rasband Added configuration to allow for custom application engine. 83e24bc
May 16, 2012
Dan Rasband Make code version specific for rails 3.1 and up
This commit adds Rails version checking to the RSpec application
configuration to handle Rails 3.0.x. The Rails::Engine class, while
available in Rails 3.0, does not have the capability to draw routes as
it does in 3.1 and above.
May 21, 2012
David Chelimsky refactor matchers to conform to internal changes in rspec-expectations 1cd9a3c
May 22, 2012
Andrew White Update obsolete link to fixture documentation 6781841
David Chelimsky Merge pull request #547 from pixeltrix/patch-1
Update obsolete link to fixture documentation [ci skip]
May 25, 2012
Bryan Helmkamp Add Code Climate badge e458003
David Chelimsky Merge pull request #548 from brynary/codeclimate-badge
Add Code Climate badge
gotta change the cukes too!
- Fixes build broken by #547
May 31, 2012
jack dempsey built-in scaffold generator already runs the hook for helper fd965a2
David Chelimsky Merge pull request #551 from jackdempsey/remove_hook_for_helper
built-in scaffold generator already runs the hook for helper
David Chelimsky Changlog for #551 [ci skip] cfca79e
David Chelimsky add travis banner to README [ci skip] ec87acc
David Chelimsky Take two on the travis banner (grabbed the wrong one the first time)
[ci skip]
Jun 01, 2012
Bryan Ricker Update Factory Girl examples to replace deprecated syntax 13bf2a4
Justin Ko Merge pull request #552 from bricker88/patch-1
Update Factory Girl examples to replace deprecated syntax
Justin Ko Update doc for stub_model 68787f7
Jun 02, 2012
Justin Ko Use one-liner for configuration. e09f6e5
Justin Ko Dev: Fix helper_spec.feature from failing after the first run
Because we manually include `ApplicationHelper` into the `_view`
object, we can't have conflicting method names between the helpers.

This is not really something to worry about with user projects: I
believe most projects use `helper :all` and/or do not utilize
inheritance (include helper in a helper, with conflicting names in

Fixes #554
Justin Ko Dev: Forgot to "revert" including ApplicationHelper into the singleto…
…n class - `extend` is just fine.
Erik Michaels-Ober Use American-English spelling of color as default
This brings the generated `.rspec` file in line with the version used
in the project:
Erik Michaels-Ober Default to run specs in random order to catch order dependencies
* Some features still need to run in default order
Andy Lindeman Merge branch 'sferik-update_template' 12fd9da
Andy Lindeman Changelog for #501
* Closes #501
David Chelimsky renames `render_template` to `have_rendered`.
Also aliases to `render_template` for backward compatibility
Jun 03, 2012
Andy Lindeman Explicitly specify the scope of Rails
* If another gem defines `Rspec::Rails` before us, `Rails` might qualify
  to `Rspec::Rails` (at least in 1.9)
* Fixes #555
Jun 04, 2012
Dan Rasband Tweak alternate app integration
This commit removes most if-statements from the example groups,
consolidating to a global method called `at_least_rails_3_1`. It
also adds filters to the rspec tests and changes engine_support.rb
to application.rb.
Jun 05, 2012
Vladimir Strakhov Fix typo in b86190c
David Chelimsky Merge pull request #558 from rimidl/master
Fix typo in
Jun 06, 2012
David Chelimsky changelog tweaks [ci skip] f869484
Jun 08, 2012
Jim Deville add features to show how namespaced routes can be matched e795ec0
Justin Ko Merge pull request #559 from jredville/master
add features to show how namespaced routes can be matched
Jun 09, 2012
Justin Ko Revert change to features/routing_specs/ - the documentation…
… for #route_to is sufficient
Jun 21, 2012
Ben Morris Removed the extra spaces between methods. They have been mocking me f…
…or months.
David Chelimsky Merge pull request #566 from bnmrrs/patch-1
OPTIMIZATIONS! Removed extra spaces between methods
Jun 22, 2012
Dan Rasband Raise error for Rails 3.0
Adds an override of Rails.configuration.application=(*) setter to
raise an error when Rails.configuration.application is set in Rails
3.0. Also moves at_least_rails_3_1? method to the RSpec::Rails module
as a public module method.
Jun 23, 2012
Justin Ko Merge pull request #539 from danrasband/custom-application-configuration
Added configuration to allow for custom application engine.
Justin Ko Move "at least rails 3.1" method to rspec/rails file. f067d8f
Justin Ko This should be a writer method spec. 454364b
Justin Ko Move the "drawing of the routes" for the EngineExample to engine_exam…
Justin Ko Don't need a file for this. 1f58ed9
Justin Ko Don't need this example - it spec's an accessor. b4b2608
Justin Ko changelog 489bebc
Justin Ko No need for explicit return statement. 2fc6473
Justin Ko Nothing "custom" about this. 1a9d160
Justin Ko Move the "application swapping" to an `around` filter in the spec_hel…
Justin Ko After thinking about it, there is nothing "engine specific" about any…
… of this new code. Therefore, no need to have engine specific specs.
Justin Ko Better changelog message. ebd891f
Jun 26, 2012
David Chelimsky convert matchers to subclass BaseMatcher class 91870ed
Jul 07, 2012
David Chelimsky revert all changes for #539
- not ready for release so backing out
- changes are stored in engine-support branch
David Chelimsky bump to 2.11.0 fb2f6f1
Oct 06, 2012
David Chelimsky include Capybara::DSL and Capybara::RSpecMatchers in spec/features 0c2b2d9
David Chelimsky include RailsExampleGroup in spec/features (necessary when there is n…
…o AR)
Oct 14, 2012
David Chelimsky add 288cd4d
David Chelimsky prep for 2.11.1 64aaaeb
David Chelimsky need to add to .yardopts b235fcf
David Chelimsky one more rename 0f38c85
David Chelimsky better capy integration docs 9af089c
David Chelimsky prep for 2.11.2 7d23257
David Chelimsky gotta add files to gemspec too 34624a9
David Chelimsky prep 2.11.3 bfa2e95