Skip to content
This repository
  • 144 commits
  • 78 files changed
  • 22 comments
  • 28 contributors
May 09, 2012
David Chelimsky dchelimsky dev: refactor a spec 0677052
May 10, 2012
Dan Rasband danrasband Added configuration to allow for custom application engine. 83e24bc
May 16, 2012
Dan Rasband danrasband Make code version specific for rails 3.1 and up
This commit adds Rails version checking to the RSpec application
configuration to handle Rails 3.0.x. The Rails::Engine class, while
available in Rails 3.0, does not have the capability to draw routes as
it does in 3.1 and above.
acd46c2
May 21, 2012
David Chelimsky dchelimsky refactor matchers to conform to internal changes in rspec-expectations 1cd9a3c
May 22, 2012
Andrew White pixeltrix Update obsolete link to fixture documentation 6781841
David Chelimsky dchelimsky Merge pull request #547 from pixeltrix/patch-1
Update obsolete link to fixture documentation [ci skip]
f599cdb
May 25, 2012
Bryan Helmkamp brynary Add Code Climate badge e458003
David Chelimsky dchelimsky Merge pull request #548 from brynary/codeclimate-badge
Add Code Climate badge
46e133b
David Chelimsky gotta change the cukes too!
- Fixes build broken by #547
4a30681
May 31, 2012
jack dempsey jackdempsey built-in scaffold generator already runs the hook for helper fd965a2
David Chelimsky dchelimsky Merge pull request #551 from jackdempsey/remove_hook_for_helper
built-in scaffold generator already runs the hook for helper
887f9a4
David Chelimsky dchelimsky Changlog for #551 [ci skip] cfca79e
David Chelimsky dchelimsky add travis banner to README [ci skip] ec87acc
David Chelimsky dchelimsky Take two on the travis banner (grabbed the wrong one the first time)
[ci skip]
6b03bf8
Jun 01, 2012
Bryan Ricker bricker Update Factory Girl examples to replace deprecated syntax 13bf2a4
Justin Ko justinko Merge pull request #552 from bricker88/patch-1
Update Factory Girl examples to replace deprecated syntax
f899083
Justin Ko justinko Update doc for stub_model 68787f7
Jun 02, 2012
Justin Ko justinko Use one-liner for configuration. e09f6e5
Justin Ko justinko Dev: Fix helper_spec.feature from failing after the first run
Because we manually include `ApplicationHelper` into the `_view`
object, we can't have conflicting method names between the helpers.

This is not really something to worry about with user projects: I
believe most projects use `helper :all` and/or do not utilize
inheritance (include helper in a helper, with conflicting names in
`ApplicationHelper`).

Fixes #554
2a68452
Justin Ko justinko Dev: Forgot to "revert" including ApplicationHelper into the singleto…
…n class - `extend` is just fine.
654367d
Erik Michaels-Ober sferik Use American-English spelling of color as default
This brings the generated `.rspec` file in line with the version used
in the project: https://github.com/rspec/rspec-rails/blob/master/.rspec
8d7cb3a
Erik Michaels-Ober sferik Default to run specs in random order to catch order dependencies
* Some features still need to run in default order
ed03bda
Andy Lindeman alindeman Merge branch 'sferik-update_template' 12fd9da
Andy Lindeman alindeman Changelog for #501
* Closes #501
0ad477a
David Chelimsky dchelimsky renames `render_template` to `have_rendered`.
Also aliases to `render_template` for backward compatibility
6695a58
Jun 03, 2012
Andy Lindeman alindeman Explicitly specify the scope of Rails
* If another gem defines `Rspec::Rails` before us, `Rails` might qualify
  to `Rspec::Rails` (at least in 1.9)
* Fixes #555
31c5ab6
Jun 04, 2012
Dan Rasband danrasband Tweak alternate app integration
This commit removes most if-statements from the example groups,
consolidating to a global method called `at_least_rails_3_1`. It
also adds filters to the rspec tests and changes engine_support.rb
to application.rb.
1c451f8
Jun 05, 2012
Vladimir Strakhov rimidl Fix typo in Changelog.md b86190c
David Chelimsky dchelimsky Merge pull request #558 from rimidl/master
Fix typo in Changelog.md
a4d47cb
Jun 06, 2012
David Chelimsky dchelimsky changelog tweaks [ci skip] f869484
Jun 08, 2012
Jim Deville jredville add features to show how namespaced routes can be matched e795ec0
Justin Ko justinko Merge pull request #559 from jredville/master
add features to show how namespaced routes can be matched
7579c6e
Jun 09, 2012
Justin Ko justinko Revert change to features/routing_specs/README.md - the documentation…
… for #route_to is sufficient
9abdc0a
Jun 21, 2012
Ben Morris bnmrrs Removed the extra spaces between methods. They have been mocking me f…
…or months.
ab6a23d
David Chelimsky dchelimsky Merge pull request #566 from bnmrrs/patch-1
OPTIMIZATIONS! Removed extra spaces between methods
1e8148c
Jun 22, 2012
Dan Rasband danrasband Raise error for Rails 3.0
Adds an override of Rails.configuration.application=(*) setter to
raise an error when Rails.configuration.application is set in Rails
3.0. Also moves at_least_rails_3_1? method to the RSpec::Rails module
as a public module method.
b694543
Jun 23, 2012
Justin Ko justinko Merge pull request #539 from danrasband/custom-application-configuration
Added configuration to allow for custom application engine.
248ce66
Justin Ko justinko Move "at least rails 3.1" method to rspec/rails file. f067d8f
Justin Ko justinko This should be a writer method spec. 454364b
Justin Ko justinko Move the "drawing of the routes" for the EngineExample to engine_exam…
…ple.rb
34cbadc
Justin Ko justinko Don't need a file for this. 1f58ed9
Justin Ko justinko Don't need this example - it spec's an accessor. b4b2608
Justin Ko justinko changelog 489bebc
Justin Ko justinko No need for explicit return statement. 2fc6473
Justin Ko justinko Nothing "custom" about this. 1a9d160
Justin Ko justinko Move the "application swapping" to an `around` filter in the spec_hel…
…per.
cf11980
Justin Ko justinko After thinking about it, there is nothing "engine specific" about any…
… of this new code. Therefore, no need to have engine specific specs.
dbbec24
Justin Ko justinko Better changelog message. ebd891f
Jun 26, 2012
David Chelimsky dchelimsky convert matchers to subclass BaseMatcher class 91870ed
Jul 07, 2012
David Chelimsky dchelimsky revert all changes for #539
- not ready for release so backing out
- changes are stored in engine-support branch
603cf3d
David Chelimsky dchelimsky bump to 2.11.0 fb2f6f1
David Chelimsky dchelimsky improve automation for publishing to relishapp.com 3a4d16b
Jul 08, 2012
Edward Rudd urkle add feature example of alternative usage of errors_on d798e70
Jul 21, 2012
Andy Lindeman alindeman Merge pull request #570 from urkle/errors_on
add feature example of alternative usage of errors_on
b7a6db0
Jul 26, 2012
David Chelimsky dchelimsky dev: fix inclusion of custom Gemfile 10de3e3
David Chelimsky dchelimsky ci: bump to latest rails versions 24b0f3c
Jul 27, 2012
David Chelimsky dchelimsky ci: update git-sourced dependencies for master and 2-3-stable 274ae67
Jul 30, 2012
Jordan Goldstein mrjordangoldstein Include require 'spec_helper' in README code examples, fixes #581 72ceb3c
Aug 01, 2012
Henrik Nyh henrik Clarify when webrat/capybara autoloading applies.
Since I got it wrong: #360
3622324
David Chelimsky dchelimsky Merge pull request #585 from henrik/patch-1
Clarify when webrat/capybara autoloading applies.
f8ab2ba
Aug 03, 2012
David Chelimsky dchelimsky Add should and should_not to CollectionProxy
- Fixes #588.
- Fixes #445.
abfd0fc
Aug 05, 2012
David Chelimsky dchelimsky dev: update dev dependencies 4187a26
David Chelimsky dchelimsky Revert "Add should and should_not to CollectionProxy"
This reverts commit abfd0fc.
f9ebca7
Myron Marston myronmarston A better fix for CollectionProxy#should.
- Delay the fix so that users can configure a different expectation framework.
- Handle the right class for rails 3.0 (AssociationProxy) and 3.1+ (CollectionProxy).

- Fixes #588.
- Fixes #445.
6b4b5cf
Aug 06, 2012
Myron Marston myronmarston A couple fixes from @dchelimsky's comments. 48a0d0c
Andy Lindeman alindeman Merge pull request #591 from banyan/namespace-with-double-colon
Accept namespace with double-colon
506ca41
Andy Lindeman alindeman Changelog for #591
[ci skip]
d818afe
Andy Lindeman alindeman README uses expect() syntax 9324260
Andy Lindeman alindeman Merge pull request #582 from mrjordangoldstein/master
Include require 'spec_helper' in README code examples, fixes #581
e60f6e2
Andy Lindeman alindeman Features use new expect() syntax a65ff6e
Andy Lindeman alindeman Merge pull request #593 from rspec/features_use_expect_syntax
Features use new expect() syntax
1ff5c96
Aug 07, 2012
Kohei Hasegawa banyan Accept namespace with double-colon 909af09
David Chelimsky dchelimsky ci: run against rails-3.2.8.rc2 8d3ab42
Andy Lindeman alindeman Merge pull request #592 from rspec/readme_uses_expect_syntax
README uses expect() syntax
fb55955
Aug 18, 2012
Jonathan Hyman jonhyman Checking for existence of ActiveRecord in proxy.rb before getting con…
…stants from it.
780c42b
David Chelimsky dchelimsky only add should[_not] to ActiveRecord classes if AR defined 07d6a1a
David Chelimsky dchelimsky Revert "only add should[_not] to ActiveRecord classes if AR defined"
This reverts commit 07d6a1a.
faf8736
David Chelimsky dchelimsky Merge pull request #599 from jonhyman/feature/ar-check
Checking for existence of ActiveRecord in proxy.rb before getting constants from it.
928a3d2
Sep 08, 2012
David Chelimsky dchelimsky replace 'it "should' with 'it "does' (using should_clean gem) 69a63ce
Sep 11, 2012
Pat Maddox patmaddox Update README w/ links to Factory Girl & Capybara 63d9abc
Sep 12, 2012
David Chelimsky Gemfile-custom updates 8c93c27
Woody Peterson woahdae Support validation contexts when using #errors_on
Previously, Model#errors_on calls Model#valid?, which will both clear
the errors hash and run validations in the default context. This adds an
:context option to #errors_on that gets passed to #valid?, allowing using
errors_on with validation contexts.

Exmaple usage:

    class Foo
      validates :name, length: {minimum: 20}, on: :publication
    end

    describe Foo
      it 'should have a name greater than 20 characters on publication' do
        subject.name = 'too short'
        subject.name.should have(1).error_on(:name, context: :publication)
      end
    end
8bedbf0
Andy Lindeman alindeman Merge branch 'errors_on_with_validation_context' a875557
Andy Lindeman alindeman Changelog for #605
[ci skip]
0b24f14
Andy Lindeman alindeman Uses latest versions of Rails for CI 7a019a6
Andy Lindeman alindeman Fixes name of ActiveRecord deprecated finders gem f48946e
Sep 13, 2012
Andy Lindeman alindeman Installs bundler 1.2 on Travis which is required for Rails master 410ad03
Andy Lindeman alindeman Reduces time needed to install/compile gems on @travis-ci 171f869
Sep 14, 2012
Andy Lindeman alindeman Simply install the latest version of bundler f9d696b
Andy Lindeman alindeman --trace runs of tests inside the sample app (debugging travis weirdness) bc5956a
Andy Lindeman alindeman Fixes the build on Rails master
* `self.table_name=` has been preferred for a while (and supported since
  Rails 3.0.0); `set_table_name` is gone in Rails 4.
c771682
Sep 16, 2012
Andy Lindeman alindeman Abort with non-zero exit status if any command fails 4dddd85
Sep 18, 2012
Ægir Örn Símonarson agirorn Using contain in the View specs example is misleading because it does…
… not work without including an extra gem.
c268810
David Chelimsky dchelimsky Merge pull request #608 from agirorn/use_include_in_view_spec_example
Using contain in the View specs example is misleading.
be689da
Sep 24, 2012
Andy Lindeman alindeman Scaffolded controller specs are compatible with Rails 4
* Rails 4 introduces
  [strong_parameters](https://github.com/rails/strong_parameters).
* If a model is scaffolded with attributes (e.g., `rails generate
  scaffold foo bar:string`), Rails will generate a controller that only
  accepts `bar`. This means that the controller spec must be aware of
  the specific parameters when sending PUT (update) requests.
* Furthermore if a model is scaffolded with attributes, Rails generates
  a controller that *requires* the #presence of attributes. This means
  we cannot send in an empty Hash, as the Rails framework will return a
  400 Bad Request.
86b0799
Sep 25, 2012
Andy Lindeman alindeman Merge pull request #611 from alindeman/rails4
Scaffolded controller specs are compatible with Rails 4
87ebea1
Oct 01, 2012
Andy Lindeman alindeman Adds example of using render_template in a view spec
* This is currently failing under Rails 4.0
6185a5d
Andy Lindeman alindeman Correctly assign @gadgets so the view renders properly 8474e9d
Oct 04, 2012
blowmage blowmage Remove unnecessary require
The rake task doesn't use core, and doesn't need the DSL loaded to work.
Having core loaded stomps on minitest if in the same project.
90f3302
blowmage blowmage Update dependencies in the gemspec
Switch dependency away from 'rspec' because it loads core, which loads the DSL.
This change allows rspec-rails to live side-by-side with minitest-rails.
f5a5735
David Chelimsky dchelimsky Merge pull request #615 from blowmage/minitest-rails
Allow rspec-rails rake task to live with minitest-rails
0be66ba
Oct 06, 2012
David Chelimsky dchelimsky include Capybara::DSL and Capybara::RSpecMatchers in spec/features 9332167
David Chelimsky dchelimsky add RequestExampleGroup to specs in spec/api 1c9e2b7
David Chelimsky dchelimsky Changelog 0dbd908
David Chelimsky dchelimsky include RailsExampleGroup in spec/features (necessary when there is n…
…o AR)
a77de85
Oct 07, 2012
Andy Lindeman alindeman Sets `#controller_path` in all versions of Rails
* Fixes #316
724578d
Andy Lindeman alindeman Merge branch 'issue_316' 3214564
Oct 09, 2012
Andy Lindeman alindeman Improves developer documentation 1f8b20d
Andy Lindeman alindeman Be a little more forgiving when RAILS_VERSION or .rails-version does …
…not exist
1dd534b
Oct 12, 2012
Patrick Van Stee vanstee Identify ruby code for syntax highlighting
Fixes #617
78b151a
Andy Lindeman alindeman Merge pull request #619 from vanstee/ruby_file_doc_strings
Identify ruby code for syntax highlighting
662c9c8
Oct 13, 2012
Andy Lindeman alindeman Generated specs support module namespacing (e.g., in a Rails engine)
* Fixes #448
9ab382c
Oct 14, 2012
David Chelimsky dchelimsky add CAPYBARA.md a41a95b
David Chelimsky dchelimsky prep for 2.11.1 d568851
David Chelimsky dchelimsky need to add Capybara.md to .yardopts 3d54ead
David Chelimsky dchelimsky one more rename c5bdbfb
David Chelimsky dchelimsky better capy integration docs 6f551cd
David Chelimsky dchelimsky tweak capy integration docs 732e148
David Chelimsky dchelimsky gotta add files to gemspec too 2a1eac6
David Chelimsky dchelimsky OMG, DRY violations in docs - prep for 2.11.4 087f8f1
Oct 17, 2012
John Firebaugh jfirebaugh Fix bare #render in view specs on Rails 3.1
656ff3 made this compatible with 3.2 by splitting the
name of the template in the description into its base
name, locale, format and handler components, but in
doing so broke compatibility with 3.1 and earlier,
which does not support the extra options.
5f869c1
Oct 19, 2012
Andy Lindeman alindeman Merge pull request #624 from jfirebaugh/render_3.1
Fix bare #render in view specs on Rails 3.1
189fbdb
Andy Lindeman alindeman Changelog for #624 [ci skip] b8392ac
Oct 20, 2012
Brent J. Nordquist bjnord Removes AutoTest config/ exception
* Mappings for files under config/ will work
* Fixes #625
* Closes 627
738fd0d
Oct 23, 2012
Andy Lindeman alindeman Adds custom failure messages for #be_new_record matcher
* Fixes #628
60b4c27
Oct 26, 2012
Andy Lindeman alindeman A first stab of fixing `assert_template` in Rails 4 view specs
* It's relatively unobtrustive, but feels quite dirty. I'm hoping this
  is a temporary fix that produces feedback on something better.
601483f
Andy Lindeman alindeman Capybara feature specs may use Rails URL helpers 96e1c33
Andy Lindeman alindeman Documents how to customize `rake spec`
* Closes #521
00ee369
Nov 06, 2012
Johannes Faigle jayeff Fix link to Capybara.md on rubydoc.info
reflect rename
7d478ee
David Chelimsky dchelimsky Merge pull request #633 from jayeff/master
Capybara.md was renamed, reflect this change in Changelog.md
4211c07
Andy Lindeman alindeman Merge pull request #630 from alindeman/capybara_url_helpers
Capybara feature specs may use Rails URL helpers
fd25838
Nov 09, 2012
Thomas Billicsich TKAB Update Capybara.md
Fixed confusing type error.
a73dab4
Andy Lindeman alindeman Merge pull request #634 from TKAB/patch-1
Really rspec-2.11.1 or rspec-rails-2.11.1
3865507
Andy Lindeman alindeman Revert "Capybara feature specs may use Rails URL helpers"
This reverts commit 96e1c33.

* We'll instead use an implementation that adds a proper
  FeatureExampleGroup (see #632)
1152131
Nov 10, 2012
Jonas Nicklas jnicklas Add example group for features
This fixes various issues with the integration between RSpec and Capybara 2.0.

- It includes Route helpers, these were previously unavailable, due to
  the fact that the only reason they are available in request spec is
  that those delegate via method_missing to an IntegrationTest instance.

- It adds the `:feature` type to all features. This way people can
  include module into `:type => :feature` examples and they will work
  when their specs are places in this folder.

David previously commented that he didn't want to add Capybara specific
behaviour outside of `rspec/rails/capybara`. I was careful to avoid
doing that. The feature example group does not explicitly include
Capybara, instead, Capybara is included due to Capybara itself hooking
into `:type => :feature`. This is much cleaner than the way it was
before.

I tested this against both a freshly generated Rails app, as well as an
existing, rather large project, both worked well.
0fda98b
Nov 11, 2012
Andy Lindeman alindeman Adds cukes for feature specs (capybara integration) 6e68bdd
Andy Lindeman alindeman Replaces `match` with `get`. `match` is removed in Rails 4 56473fd
Nov 12, 2012
David Chelimsky dchelimsky Add rails-2.3.9 to travis config a731794
Andy Lindeman alindeman prep for 2.12 dcabc3a
Andy Lindeman alindeman Wraps code in backticks
[ci skip]
623c362
Andy Lindeman alindeman Updates cucumber feature for changes to ActiveRecord in Rails 4
* Rails 4 deprecates #scoped in favor of #all
1d9514f
Andy Lindeman alindeman Updates to rake 10 as 0.9.3 introduces incompatibilities bbd6f36
David Chelimsky dchelimsky --trace is now --backtrace fb9eda1
David Chelimsky dchelimsky bump version to 2.12 edd4a73